From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 744D2439F9D for ; Tue, 4 Aug 2026 21:36:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785879403; cv=none; b=vGnR4lvAt6qOL+G5o8ctk2SLNp5OzLsw2J7+bpHrhij0VVq4Len1alYxs/UI0/WAdVJg/DNqmzcSv37TP8tq8Vzv8qmrtVl51Z5miVj0ZOzHTUJ5jo5aolieTrwsMp96uQw5+OzoT03yzZRJobN476LlA+SJeFSZ1S3NTBUXsoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785879403; c=relaxed/simple; bh=YH1N+wRvSRBpaEPyBNpid6Jr+SC4it0QGTm+4oIdieU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=C4cZU093Yk+1iBDkM+kMExLaPlJzGQoq0RjWHInsVlJLbGBpnQK30QOL+P6sSXtmwBfKdEFskkwIvN6Gr0hF+7oymwhe1Ehp6yrP8P+UFGrtQXByltjtZtvQZi9dz8OhNRV6RCsVLpmmyfVE85fMr456cpaQ2lZn+sYq9/4G/Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mxlvdvuP; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mxlvdvuP" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cc891373e0so3984405ad.2 for ; Tue, 04 Aug 2026 14:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785879402; x=1786484202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yRZ9KtvM4Uvs1PJvqeEv2QOFNUN6xaam9dkuxhQtkew=; b=mxlvdvuPiwFfsAVbYOPmwiIoy1DyWvlb/PRdydqyzQ5hTwqSh3WUz02E8A8URuUHEh IJDFCiu9Rh8uezwIKUkFYaZ7KWfn7H6eQJkvEay6utGPmNJ2UZjRBj/I9NXvAU2b65p1 wrcCtLb/hdAlqIgg/0xAR8XLpRSVunAFdtrXRxkoYBxip+Tyhf6aZgIaKJGVrcoq7zuf a3oQTNc9wo99mYcJp5qbpzdZqDKQbcntpZuyaNNw7AA3V5O+P6H2ZItbs9Tu2m+kS2Zh 8FIs9OXw+KF8P33VpD+GakZ3Rak8uEwuUPbo5vgBzcVRraGlqNO0/8XkTud7arDBF3zv 8kJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785879402; x=1786484202; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yRZ9KtvM4Uvs1PJvqeEv2QOFNUN6xaam9dkuxhQtkew=; b=qAf5tVQ5rnwqKEsBTnjFLLN8wSwDa5Fcz7qWK5ysLt6bvBq5uxtQ7NBfFVM8db8P8o muE3RY/0mrXLD/WeVn1b6XKUQjwdRmUrVmzx/7jKxoxCJpVpO4RBU7ckPjOeWwH7XbEn GcHSuvVhed/8Jiy56KAUGHyWRfe7N/XRXPzbbe00b86PcK2Agtuyvw2SuyWDRgCdxdVe CIMxxkcmi3pY5EavOB0EiK9QMy/6Vo7zK3ERyvBbAt4MvWHbdXEP6aqr7Fz8NlS3fD1w P7t8QBVLnluKoZMILoKdAxMznqBrDryHxQzGhyhnfkzju8YmEJlLS+ivVvgOzggUjYUF 2uvw== X-Forwarded-Encrypted: i=1; AHgh+RqNHinsxz7AS6NLh3MzkSOuRHdAa8/1VmKE6pf7M+AbczNk4fzJzm7b7Tsn3626MncnevezAOtc3nhWN5M=@vger.kernel.org X-Gm-Message-State: AOJu0YykFeyPSBfIwrsoMT3B38tpjjuTitCWlriaCVmh3Tdi9jzcJE0y dyDWRl8UyYZz8wSDKmud3/2RP38xbpEh4G6pe3r1R4RzApoIWnkFZOjn X-Gm-Gg: AR+sD13WvfLho+RYVAz8MAyvuyjuV4WpkRI4euPFdC7ZkZdxvb28a4E/Rf5AbtJWzky iqCwAKdOsqnwAnKg8ODkyO+2Tww78lvUTLQH8gBr0gkxmNrRO7F1s3TCvo6YBSR5CbkCCJbXILz 0eoeDALl0BbYmh7oaispL+P0FlsKcfr2epg8AGvSEver0gpxIT24KJiWgyYGmWFe5LajmTaYhdQ pQ93tivCW8VHyg7snsxQq9GrJIxGjlFKwYWo6Lj8hoU1p7a/JVxmOsEvfhjoWSOGasKH2BAJysI 1vX6hOMv61XS4GupDvSA6xZMltELsPYFr3No7VLZpUJb0SLz4l3CmC8VDvWfVJJrcsr1BopeSXo 2ByxM2iQf5qs4G8AhOsMR2yzqBhHlxvvI7rgYE3BiXH+n02xdzyEyw17h7eivIg7zvxs00IbWb6 tV7U7JX+lEwFFqcbhxo6CVQ4moofu9HSO0Q4BwDtWX1gVuq4xEgJxTgMzeuDPnPzyPBAdpAZHLR W3eyxL3J1YcEvUdfO/gj3idfruSkuF5Q6cXCXm3uewFFz0HupElTw== X-Received: by 2002:a05:6a21:7a9c:b0:3b1:a9ce:507e with SMTP id adf61e73a8af0-3cb8607a666mr1715295637.32.1785879401687; Tue, 04 Aug 2026 14:36:41 -0700 (PDT) Received: from LAPTOP-DPAKMOI4.it.purdue.edu (pal-210-106-74.itap.purdue.edu. [128.210.106.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586777bcfsm12780536eec.21.2026.08.04.14.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:36:41 -0700 (PDT) From: Yifei Gao To: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Keith Busch , linux-nvme@lists.infradead.org Cc: Damien Le Moal , linux-kernel@vger.kernel.org, Yifei Gao , stable@vger.kernel.org Subject: [PATCH] nvmet: pci-epf: put CQ ref on create_cq mapping failure Date: Tue, 4 Aug 2026 21:36:25 +0000 Message-ID: <20260804213626.3410403-1-gyf161023@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit nvmet_pci_epf_create_cq() calls nvmet_cq_create(), which takes a reference on the controller and installs the completion queue. If the subsequent PCI address-space mapping fails or returns a too-small partial mapping, the function jumps to err_internal / err_unmap_queue without calling nvmet_cq_put(). The matching put in nvmet_pci_epf_delete_cq() is gated on NVMET_PCI_EPF_Q_LIVE, which is only set after the mapping succeeds, so teardown never releases these references. A remote PCI host that drives Create IO CQ commands with a failing PRP1/pci_addr therefore leaks the CQ and a controller reference on each attempt. Drop the CQ reference on the mapping-failure paths. The err_internal and err_unmap_queue labels are only reachable after nvmet_cq_create() has succeeded, so this pairs the create/put correctly. Fixes: 0faa0fe6f90e ("nvmet: New NVMe PCI endpoint function target driver") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yifei Gao --- drivers/nvme/target/pci-epf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nvme/target/pci-epf.c b/drivers/nvme/target/pci-epf.c index 4e9db96ebfec..794e88d1d9a5 100644 --- a/drivers/nvme/target/pci-epf.c +++ b/drivers/nvme/target/pci-epf.c @@ -1339,6 +1339,7 @@ static u16 nvmet_pci_epf_create_cq(struct nvmet_ctrl *tctrl, nvmet_pci_epf_mem_unmap(ctrl->nvme_epf, &cq->pci_map); err_internal: status = NVME_SC_INTERNAL | NVME_STATUS_DNR; + nvmet_cq_put(&cq->nvme_cq); err: if (test_and_clear_bit(NVMET_PCI_EPF_Q_IRQ_ENABLED, &cq->flags)) nvmet_pci_epf_remove_irq_vector(ctrl, cq->vector); -- 2.43.0