From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17611344D8C for ; Tue, 4 Aug 2026 22:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785882886; cv=none; b=kwGI4C6QBy9L/pZ/qsZK3VRvyE/gbHejJYiFtPd0/TXLkUm//nP9kj6dLBvPU99RslETtC3BuMCGlV1wf31VrdS5IDvMmvBYxTfm7d0dsPtStpl/wslxD06uLTRfa8e8M3y5q8CDfrlB9ifF0+Y7bedgbfAGwbXzWbvfLvPkXVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785882886; c=relaxed/simple; bh=aPohIqZFSeA6QSk/ADqrL84KJWRo0eb98WC5hGxERGQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=as/olcJ4RBAtCP+RTbKXEJE1EFmzLZ+xVaeJ+gq6QP2QeWYTi5G/zboWtnDm25qnjWx/1sce1RgzbDngpmWTyOr6yzkfm7wgsXjGBo0uHAjm5B5jGgEpffU6AETw1afjgEnEzwSis1JpH/ovdHhL/fQFxxelIPNQGQyvNd1nRvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VvdLXPi0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VvdLXPi0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D02D1F000E9; Tue, 4 Aug 2026 22:34:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785882884; bh=ug9aP3WaUOLsryR62qcZvNl9FWE7VVwGqjqgyehGoBI=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=VvdLXPi0OiBn7pFvzfDhAcNqzHbFL4Dvdwicit0qBAy6R6HREzkY4K4EF5qx15AYi bJY2mbNrJrQhN0jyFewz/UMPmW+t2OeagKPCVnUBXRA4+YYPbUU/C1ZSK8evFFz1+l aMjmhXi6bqfGZ6LL4j2JQWmbNZCEZhSN9+hRA00rbZjiZ7UQv7SZXbPE51mc/ywRO0 h6n8gIpz0NvTJ6MCGQc90RLcSs+u/4dDfnY7qraVBhy6i6uSq6gufpUCxav8bGJZuA ZrPBEtKlkmozeYS2a9uR6RK47k1Q9PPa61ZteiTaO4kiYzD1HfqTL+vLwwc2jMzbsN NEELy59iBOAVw== Date: Tue, 4 Aug 2026 23:34:40 +0100 From: Jonathan Cameron To: Pawel Zalewski via B4 Relay Cc: pzalewski@thegoodpenguin.co.uk, Yushan Wang , Conor Dooley , linux-kernel@vger.kernel.org Subject: Re: [PATCH] cache: hisi_soc_hha: use named initializers for acpi_device_id Message-ID: <20260804233440.48e389ac@jic23-huawei> In-Reply-To: <20260804-cache-v1-1-a1491610bb01@thegoodpenguin.co.uk> References: <20260804-cache-v1-1-a1491610bb01@thegoodpenguin.co.uk> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 04 Aug 2026 12:17:45 +0100 Pawel Zalewski via B4 Relay wrote: > From: "Pawel Zalewski (The Capable Hub)" > > Use a named initializer for the acpi_device_id fields which > makes the code more readable and consistent with how lists > are initialized in the rest of the kernel code base. > > Signed-off-by: Pawel Zalewski (The Capable Hub) Acked-by: Jonathan Cameron > --- > drivers/cache/hisi_soc_hha.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cache/hisi_soc_hha.c b/drivers/cache/hisi_soc_hha.c > index 756c43398515..f0f6c0354108 100644 > --- a/drivers/cache/hisi_soc_hha.c > +++ b/drivers/cache/hisi_soc_hha.c > @@ -170,7 +170,7 @@ static void hisi_soc_hha_remove(struct platform_device *pdev) > } > > static const struct acpi_device_id hisi_soc_hha_ids[] = { > - { "HISI0511", }, > + { .id = "HISI0511" }, > { } > }; > MODULE_DEVICE_TABLE(acpi, hisi_soc_hha_ids); > > --- > base-commit: 075b74841bd0065a3bda3440873c747938e69b68 > change-id: 20260803-cache-55f8e58f7d94 > > Best regards, > -- > Pawel Zalewski (The Capable Hub) > >