From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835E53F4105 for ; Wed, 5 Aug 2026 21:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785965638; cv=none; b=ICmjtdxkQOtAtEMDx+jjaV/IhvH2Ow3iiLNVqF4nUSTXVMxly3GWh9Zw0v4m+A+6uHfwrepcMCFIX7qsOFYe6ieeRHWqK4DJvNTkjq2IG0wzPKTHwFB3xEosiESLUzj6bPJcgrtKTkLA4Q8WFwNbhq+BzvkVgZl7uYk6d2HywFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785965638; c=relaxed/simple; bh=rEQB9j55XQ8igGPwemfS3N0gbAPOlhN3CcMoZha5xDg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o52XD2/0yd5f/GMbhY3iz1U0QDmIXUFEEvloHQo59zl5XRns6b9JcvEpyjc0BKAHjZ3om4cUIx151fn9X4Y1Vi42VH9TDqn6SdHQy/2WUQn7MF7f2VD6GhPikgPq3SyzDIZiqJ0j0R08KYl0ERXVlqbSoVh8lu9EMOnLS8X2bFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CP5DoTvD; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CP5DoTvD" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4956d1d9fb2so1348565e9.0 for ; Wed, 05 Aug 2026 14:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785965635; x=1786570435; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/sTTgLUY5GPNw6xzYiSteMCin6Bg9dthb3pni8zICBQ=; b=CP5DoTvDtUDS9t+rLHwHFXVMSzm6e7i6meibzfVrtZcJFit3uglaYOT8ge0uWNtFYO X1u4VJi0AxV/ZG7mm23K3oJKB1q4/X6auSzxaWNgxRtxHfScfzXGnl0nzjD+F/7i1iS0 T8vZ5CFBII4CmoinhVLuQlqX8qwyo5yNzLejnQB3HpfLx0JYSRwErU7MAA+HvCkTwrdF 0mxIb1y4WTlev5Xg4BO024EtKQYHchlFUePgnGEb+Jyj+JQBzQPyR2yoeKmjkOCAIhDa N1RyOfvn5f9/cWIxs7mAFZXpc2wMoCJw+0dOe6+TWrgB3h5Qp3GQZUa/ZW6wM76DO32u wvjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785965635; x=1786570435; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/sTTgLUY5GPNw6xzYiSteMCin6Bg9dthb3pni8zICBQ=; b=PhMWgzFtjt7lUqM9pc7XIq7MugZ60pVpp6pDZjRAQyIwNPmLXNoSaugetEKdcdqQNV lYLEcTqvsNRlVQuEMFjmNrq9cWplzjQCiYzrvF01KlwCQt2a0D7Z5Gq5EtOiOuT1yy77 NcCLUPde2z6MqFGLuxBEdvSwkWqKnBet6cj2d3jUiwxOunjwk5D3i+hu+9GQxiqR1gIx WaltHpnuTrhH+3ria1DNMMPsqL3Wbe6jDI+ROfgDzddHBPANWH75sfDRW0hxKPXbqQLc lbERZbVzEonf78HnQstydQzqj9JctMNSZJBqSvbAPcTGEANr457gZ3+r4SDnzJj60vtK cqDQ== X-Forwarded-Encrypted: i=1; AHgh+RpP2vBfArwDyu2CVkN0q/+dI1OIrK/uU7K4MiINKj8itC24BVkjHYmzekg81RgT2suoN+KZ6fBFp/Hp70k=@vger.kernel.org X-Gm-Message-State: AOJu0YyEyjasJfn9sqfe7KaXb4IaF16LT8PWbPFGjrmXoFBAJ3bdo6Wt 1fdYfczTyUGzCb9v1QC9/GKFT04MzRKtvKJdQY8GJ3LuVqjp68SyH760 X-Gm-Gg: AR+sD11htXqkz5Z8Qr9ow5oQrUaMooeQUIGXGDCAk23qihnPd0wxtL083DKRedCSajV vyaorKtRrkDpfZOMOtFMPXp0NJQuQ298P/1OG7iJwJOsmPITlWQiG51KfGe2IcVKSz+laJlN6jW PFNmxri5i2yy+WB8tOPXWtAcn4GRnNR/ZvKHvnujtR0KaWospT8Qav5kM7DW94ijDJifFgE64Ba /TEcjDT1LlFFaKfierzlPwGZpwIfG3K/8lMG8EDEaLGmUZWtYcElcXvrmOpP/T3cph3BS8k5xzX C17L1R5mFPL/ZWX0KBG0lbyegLWqhiNgguQsYk3QnpjC8EWNxpiM5ZjQrJAcBB2zPTVZgR6zesp mWIPuZ6ToIzeP06/qCjmQc2Lo+CjdFH0CNa80bB0yKwQq7ppA/ZAAjNCKWID8v5cyRyiKT/4pNx u7b99xCsxGtC2rEjklCDP6K28PIBZ2v7ZhQxr+BfCVFek= X-Received: by 2002:a05:600c:b85:b0:495:4505:dad0 with SMTP id 5b1f17b1804b1-4994e7ba5efmr68556855e9.2.1785965634615; Wed, 05 Aug 2026 14:33:54 -0700 (PDT) Received: from localhost ([2620:10d:c092:500::7:f900]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b18374sm409733f8f.23.2026.08.05.14.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 14:33:54 -0700 (PDT) From: Gustavo Luiz Duarte Date: Wed, 05 Aug 2026 22:33:01 +0100 Subject: [PATCH net-next 1/4] netconsole: add an address family to struct inet_addr Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260805-netcons_ipv6-v1-1-170a35b92da1@gmail.com> References: <20260805-netcons_ipv6-v1-0-170a35b92da1@gmail.com> In-Reply-To: <20260805-netcons_ipv6-v1-0-170a35b92da1@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.15.2 netconsole_target stores a single 'bool ipv6' to denote the target's address family. This makes it hard to detect conditions like "no address set" or ipv4/ipv6 mixup between local_ip and remote_ip. Add a 'family' field to inet_addr so each address stores its own address family: AF_UNSPEC while unset, else AF_INET or AF_INET6. Nothing reads the new field yet. The next patch switches the users over and removes the bool. No functional change. Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 22 ++++++++++++++-------- include/linux/netpoll.h | 10 +++++++--- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 03913302328c..d615a9256787 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -212,7 +212,7 @@ struct netconsole_target { bool extended; bool release; struct netpoll np; - union inet_addr local_ip, remote_ip; + struct inet_addr local_ip, remote_ip; bool ipv6; u16 local_port, remote_port; u8 remote_mac[ETH_ALEN]; @@ -415,6 +415,7 @@ static int netcons_take_ipv6(struct netconsole_target *nt, continue; /* Got the IP, let's return */ nt->local_ip.in6 = ifp->addr; + nt->local_ip.family = AF_INET6; err = 0; break; } @@ -456,6 +457,7 @@ static int netcons_take_ipv4(struct netconsole_target *nt, } nt->local_ip.ip = ifa->ifa_local; + nt->local_ip.family = AF_INET; np_info(np, "local IP %pI4\n", &nt->local_ip.ip); return 0; @@ -731,7 +733,7 @@ static void netconsole_print_banner(struct netconsole_target *nt) /* Parse the string and populate the `inet_addr` union. Return 0 if IPv4 is * populated, 1 if IPv6 is populated, and -1 upon failure. */ -static int netpoll_parse_ip_addr(const char *str, union inet_addr *addr) +static int netpoll_parse_ip_addr(const char *str, struct inet_addr *addr) { const char *end = NULL; int len; @@ -743,14 +745,18 @@ static int netpoll_parse_ip_addr(const char *str, union inet_addr *addr) if (str[len - 1] == '\n') len -= 1; - if (in4_pton(str, len, (void *)addr, -1, &end) > 0 && - (!end || *end == 0 || *end == '\n')) + if (in4_pton(str, len, (void *)&addr->ip, -1, &end) > 0 && + (!end || *end == 0 || *end == '\n')) { + addr->family = AF_INET; return 0; + } if (IS_ENABLED(CONFIG_IPV6) && - in6_pton(str, len, (void *)addr, -1, &end) > 0 && - (!end || *end == 0 || *end == '\n')) + in6_pton(str, len, (void *)&addr->in6, -1, &end) > 0 && + (!end || *end == 0 || *end == '\n')) { + addr->family = AF_INET6; return 1; + } return -1; } @@ -858,7 +864,7 @@ static ssize_t local_ip_show(struct config_item *item, char *buf) if (nt->ipv6) return sysfs_emit(buf, "%pI6c\n", &nt->local_ip.in6); else - return sysfs_emit(buf, "%pI4\n", &nt->local_ip); + return sysfs_emit(buf, "%pI4\n", &nt->local_ip.ip); } static ssize_t remote_ip_show(struct config_item *item, char *buf) @@ -868,7 +874,7 @@ static ssize_t remote_ip_show(struct config_item *item, char *buf) if (nt->ipv6) return sysfs_emit(buf, "%pI6c\n", &nt->remote_ip.in6); else - return sysfs_emit(buf, "%pI4\n", &nt->remote_ip); + return sysfs_emit(buf, "%pI4\n", &nt->remote_ip.ip); } static ssize_t local_mac_show(struct config_item *item, char *buf) diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index 1c6b1eec5efd..de97f001a0f9 100644 --- a/include/linux/netpoll.h +++ b/include/linux/netpoll.h @@ -16,9 +16,13 @@ #include #include -union inet_addr { - __be32 ip; - struct in6_addr in6; +struct inet_addr { + /* Address family: AF_UNSPEC when unset, else AF_INET or AF_INET6 */ + u8 family; + union { + __be32 ip; + struct in6_addr in6; + }; }; struct netpoll { -- 2.55.0