From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D139395AC7 for ; Wed, 5 Aug 2026 14:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785941592; cv=none; b=UAM2AzP6q6CV1THholU2UJCTC4Mcxw11GymoVh68Gzz3KJ2F/wBWLTLepy4hIE/EztbyR2B97Qz2XpnSqXLvfhsAcgsZyyBwuOsApjUl5nxFv5VVylvnFY512BPoQ/w+InZEahAaaOopthg9lzZ7ad04w6Vf8LIQpg8NipCnPAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785941592; c=relaxed/simple; bh=rdmdYMH2x++Ip0ojorw7l3QrxWNtPJvBUV4AjD3Yfr4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uLzduuAHRzj11s9AhV9JlnPJqnq8GSo7GHXpXyhPF5jGa/G9v2svwBjUR9PKe11XyKeL5bebYQL7gGHuM04Ku2sEsm3MIgX6exb9t8l/Glk00k6L4ZmZHvUDlN4oQAuw7CJ8Q8SUjZcY3ZroGQazI9whBJN/EoZ+PX78jg/UbUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=l1noytC7; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="l1noytC7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=YzoQJ6AmlrH3orHeyfqBwZHpTshYUKv4cOhOLhYMmhw=; b=l1noytC7ki97Z2vThpi/sX9PYF tHj+W4liMBKCNizgeucH+YnZa9yFZGeh7JQ6UQC5YORGXKM7A+Ac0eVUT42c5qf8MQx4Og3pO/48Z sT+v3AueBD4n+FgRXlQkbx9e040ysU1+Th0Nc4O4H9Mlp5k/v3RIzod5dwyt1ywb8FiRGB+CTlFg+ xRFTo36GeI4dCWIX9pMAPlXr6d872gnS63nYX5V6R6xujrwqVOcbb5NDo0Bn/ScKstPi5dervH5FJ hybTmduF1zsavdABtnVWyIvB5s7gDA0CihE9GFR6h9W3AaGqQyAHamS4qOY+o/DWElpc0HagyzjNZ 4th6kiIw==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1wrczR-00DzfP-20; Wed, 05 Aug 2026 14:53:05 +0000 From: Breno Leitao Date: Wed, 05 Aug 2026 07:52:28 -0700 Subject: [PATCH v2 1/9] workqueue: factor out get_percpu_pool() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260805-wq-pool-refactor-v2-1-fd498d01d695@debian.org> References: <20260805-wq-pool-refactor-v2-0-fd498d01d695@debian.org> In-Reply-To: <20260805-wq-pool-refactor-v2-0-fd498d01d695@debian.org> To: Tejun Heo , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, marco.crivellari@suse.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.16-dev-f8e9d X-Developer-Signature: v=1; a=openpgp-sha256; l=1943; i=leitao@debian.org; h=from:subject:message-id; bh=rdmdYMH2x++Ip0ojorw7l3QrxWNtPJvBUV4AjD3Yfr4=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBqc05Ku9bZyp0j07mlgyfpfmu/IcD3LQtDiQ1Os v7AQlw4m+2JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCanNOSgAKCRA1o5Of/Hh3 bSURD/wIo27Qdm9L7x/0RQsTOCXd5S2QCVDQpYyakZSis/wYGUqGj8XgwgFMrxxdmszBpPFTV2g WlTTyHnwuFh5cmyIXrIexk7zfTMIvfouY/Sf7Uop6sYdtfxVc2XvM1T+pHci48IAmMV0aCjBBvp AbulH6DMLHzznRs/966Is5e41UaffJjyqrgKF8Of6kfD0bq8YFoR/D48/dUblZXSYcqQQi3Hm9h h/XuREH6fQ11xBm8GZcHlZ0bOI0ZsbfNwqSj5pzI43lvsKn3H2Zkf/6wev4+jtpYv+zE74o7jmS hEr63UC4Z7e5SBXZfinpzd9J5SC21kjvv2OvJQOT6+nKTKwZEr9w60R0shx/2pmA/qjjsjzMBSg JAnueg7chYnNnEYbITyAo1i8mJtXwePaKVSR7FJ4UCsGVEtG9ElL6oebfXXQ0rA6JCs7QkgxujZ A6pwHK96FjDa4EZ7ezpGZ9qR7DlGIVC2CncqSlRGQsyjlcT8wh86u1GwjfNZBkNQ4LnI+3wyEo2 26slaZGNpTkoiUNwWTpZE5hfpuAa0+67kTgiKkqQ/Hp+jn/hF4ZMbrmIHPCjUftU5+cp2/8LUHf cVpuLoFgtuKif+o/s0XQI1ZfXoZhmM+jO7cuOlFa93uWl1MmgMvr1rsIbjeREUIUbMiBMvN3enO cLsu+qKChHzfbNA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Move the static per-cpu worker_pool lookup in alloc_and_link_pwqs() into a helper, get_percpu_pool(), so the lookup can be shared by other pool-selection paths. No functional change. Signed-off-by: Breno Leitao --- kernel/workqueue.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 4ec3db31493d2..63a39bb3f5e47 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -5350,6 +5350,20 @@ static void link_pwq(struct pool_workqueue *pwq) list_add_tail_rcu(&pwq->pwqs_node, &wq->pwqs); } +/* Return the static per-cpu worker_pool that backs @wq on @cpu. */ +static struct worker_pool *get_percpu_pool(struct workqueue_struct *wq, int cpu) +{ + struct worker_pool __percpu *pools; + bool highpri = wq->flags & WQ_HIGHPRI; + + if (wq->flags & WQ_BH) + pools = bh_worker_pools; + else + pools = cpu_worker_pools; + + return &per_cpu_ptr(pools, cpu)[highpri]; +} + /* obtain a pool matching @attr and create a pwq associating the pool and @wq */ static struct pool_workqueue *alloc_unbound_pwq(struct workqueue_struct *wq, const struct workqueue_attrs *attrs) @@ -5664,19 +5678,9 @@ static int alloc_and_link_pwqs(struct workqueue_struct *wq) goto enomem; if (!(wq->flags & WQ_UNBOUND)) { - struct worker_pool __percpu *pools; - - if (wq->flags & WQ_BH) - pools = bh_worker_pools; - else - pools = cpu_worker_pools; - for_each_possible_cpu(cpu) { - struct pool_workqueue **pwq_p; - struct worker_pool *pool; - - pool = &(per_cpu_ptr(pools, cpu)[highpri]); - pwq_p = per_cpu_ptr(wq->cpu_pwq, cpu); + struct pool_workqueue **pwq_p = per_cpu_ptr(wq->cpu_pwq, cpu); + struct worker_pool *pool = get_percpu_pool(wq, cpu); *pwq_p = kmem_cache_alloc_node(pwq_cache, GFP_KERNEL, pool->node); -- 2.53.0-Meta