From: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
viken.dadhaniya@oss.qualcomm.com
Cc: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
Subject: [PATCH] i2c: qcom-geni: Simplify PM resume error handling
Date: Wed, 5 Aug 2026 12:30:13 +0530 [thread overview]
Message-ID: <20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com> (raw)
The driver currently logs pm_runtime_resume_and_get() failures with
dev_err() and returns the error code separately.
Replace this with dev_err_probe(), which combines the dev_err() log
message and the return value propagation into a single call, consistent
with how all other error paths in this driver already report failures.
No functional change intended.
Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
---
drivers/i2c/busses/i2c-qcom-geni.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index d5c977e34994..96015e077b69 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -994,10 +994,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c)
int ret;
ret = pm_runtime_resume_and_get(gi2c->se.dev);
- if (ret < 0) {
- dev_err(gi2c->se.dev, "error turning on device :%d\n", ret);
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(gi2c->se.dev, ret, "error turning on device\n");
proto = geni_se_read_proto(&gi2c->se);
if (proto == GENI_SE_INVALID_PROTO) {
--
2.43.0
next reply other threads:[~2026-08-05 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 7:00 Mukesh Kumar Savaliya [this message]
2026-08-05 9:37 ` Praveen Talari
2026-08-05 9:50 ` Mukesh Savaliya
2026-08-06 10:19 ` Praveen Talari
2026-08-07 8:33 ` Viken Dadhaniya
2026-09-10 20:51 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805070013.494426-1-mukesh.savaliya@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®