From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2066C483BE5 for ; Wed, 5 Aug 2026 16:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785948551; cv=none; b=nkMdebkjS5TIVGAW+QB+ozGxBHkq614PMu+2BTM/AFaeHpP5wXDcVIKor8YQeEIBPQrEPVRTBegSj03K3ubipAhyFqSjETqRMb9geEtqOoHDuCLy+2AHG01FdF3msOWE5+WUXaZHBLOMa4dorOWgU8YaCVu4vt0mJrbIkaZGM5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785948551; c=relaxed/simple; bh=b1HPKupliAi6HSMVxqGMtCAfsW6WFVSIBXX9YkF/3XQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=DOVpCuX3xLocIKYqEXn07gGTZxeXawgxP3BsNTrukxErvs+newsyqe+ch3VeJ75SJ4Mr2qlQLE+VBjCwT+wOHmd3arlmpBdpHMSZlBvr/J/UacL9RP0Q2PyP92BhiXOJ+46eFJfeo3/vzzNOAribcKsLLbwTqT2DlMR2kCBRLfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ttigpe1E; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ttigpe1E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A6FF1F000E9; Wed, 5 Aug 2026 16:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1785948549; bh=0fwsujxxGIrrG1oVqUplWmjYHY8EgpYFJELsOGJkr30=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=ttigpe1E06HXLXOcMmPHIQUOl9Udzg0P2jmrNL0mvS3w2z2HZxchbtA7cPnUhl5QR MAyZG3eMk4LbMzlZ1xzAkl/mlOn0Dy2UfMat0UpHmtzA6P5tDCrUzKfPOSzGC8OCOC G0efsTXLOxd3c5k8dUrhscr9IZ+NE95E4moYCMAA= Date: Wed, 5 Aug 2026 09:49:09 -0700 From: Andrew Morton To: Ye Liu Cc: Vlastimil Babka , Ye Liu , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: debug_page_alloc: fix type mismatch for debug_guardpage_minorder Message-Id: <20260805094909.9e84940cc1f83502a41e2d96@linux-foundation.org> In-Reply-To: <20260805093108.2352900-1-ye.liu@linux.dev> References: <20260805093108.2352900-1-ye.liu@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 5 Aug 2026 17:31:07 +0800 Ye Liu wrote: > > The _debug_guardpage_minorder variable is declared as unsigned int, > but the debug_guardpage_minorder_setup() function uses unsigned long > and kstrtoul() to parse the value. > > Use kstrtouint() with unsigned int local variable to match the actual > type of _debug_guardpage_minorder. Also fix the format specifier > from %lu to %u accordingly. Fair enough, thanks. AI review seems to have found a little pre-existing bug in there, https://sashiko.dev/#/patchset/20260805093108.2352900-1-ye.liu@linux.dev