From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8337432BCD for ; Wed, 5 Aug 2026 11:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928874; cv=none; b=FbAQD1iBTbEITZT3oA3WdEICMPEVi95EsVH1EBXt1fWyeA8r13Ii8tGw46hl+acmiYC5mzBhxs3aIc6Z6QBDJlsYYgkOQ0ilAP03i9XGFJcgc01SgBX07YczJ5Cc3cqk08UwzlIQBY/BOGdciHqaXWtdcmb12OBkQ6i9rBSqm2c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785928874; c=relaxed/simple; bh=i7cJ3WItOXnznLVZRDOXLUAOINpUuL+YjVISTjP0qiA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bhLxIdDteUvMuIstN5spxY9OmFnpCKyBLK80nhmdYQZx4G4uMnvh9LT3qUXct75FJjtNhyreDEULaCa/dLQ/2rCTKsEg5Rb9GTTpFUEouR4CuSGosrzK+9CZaiT0yLsbC3umXd4m8Can1gfjlm7auKXQ8TDXKG43ufdd6g6Gc00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cMuYoaoL; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cMuYoaoL" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2cacf197759so13158115ad.2 for ; Wed, 05 Aug 2026 04:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785928872; x=1786533672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=m8URXW87BTcEyeGrusW01Botd2qLeyYetXeL00jvAgA=; b=cMuYoaoLg0kclQb/OQPBajmqkrcqCXO+CiNKVdAaKwCqfuPPKeq4l5F9mSZZUGT1v2 SDKgrB6AFULsdBAZ0bNTGsEG1q0j8M+15MLD3waQp+9ZqJOmWdpbVE+rmpgwJsUT4589 l3md9zmcdE+JW5gF42CDX0rwi1zq4K7RS6IRg8HHNspB2o+JP2RLjD2ziIw5XeCtSYQx vdDTZqvdDNMMnxBSA6XTuqk+6O9GM8e0MoLn1hHeGSpUXk8oMYTWeoAobWNLLhNzTlMb /xIDmn66eoR+13UeZD25hwNukV7nL5jdyRjC7GZBG1TfU/zuiCaLdZWj/N5KMH5UBRfx 6PHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785928872; x=1786533672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m8URXW87BTcEyeGrusW01Botd2qLeyYetXeL00jvAgA=; b=dd79J6ol8azfcV0LHXq6b5QpKGK6Ed2YHaPd4deVxUt9Xwag1MOkpLPOpJwiuMH1zh /bpdI5XujcPYK4gKzbwD3nfqFeVx5vtMqYZWBba4qDU6OJNOAvLKekyWvXXTYAAdbmA7 W7aic06OCncI4dYjs9akJaax27iDClMf5ihwCSHuS567cvE1W6F8az1xrj5eh+ySqswn BfKgLnw1TZFp9TI7FKjJgvePfVdK8WDLYbGHocikUuKfDlMBiKnhJpU0OUx44Pel3CPc sjn0WNBMFtk2i9B9UP+4fbTlNHJctifpLSDPSdPHZYeKTTnmr5xHeIYzidw0dhbd9JBM MYwg== X-Forwarded-Encrypted: i=1; AHgh+RopYL+UDI7sEZ6mVnVKnIM5I7/hJNljiEV6J8D9EJcKIjj+79tqgVi4o5Pc5qEMLiVekbCGnfyUrzkGbjo=@vger.kernel.org X-Gm-Message-State: AOJu0YzzSLUHzvruTPoO6F6S518IUGZdjlG6RJU/SjTwMtikYme+LPLP AA9XAgo1J9Tic6LM5H6ATlJFGG5SX1lH52V/xDTCLI9JEmSLXGBI4w3i X-Gm-Gg: AR+sD12T61IypPid9Esg3HsaTyhJTS2Wfkux+g0+j/sYgRs7IgAyTKpb5jtHMnHcHT8 HoF4TT3PeurL9QZF8NxzsKudyK1Bb2KR/jQWXr60jD9KtFFr95s/jf5f8qGpsnykOMYUX3GIN4l sMpKrIXquH7tp8CPFXmpjF02Uje4G995gEi9KMXS8zPx3LOBgViFczU27srO8ULWDcJNvF4zc5x lwBg30g1/QN1BcRVKYewTis6cAtYi0Hfb4QDzVRGaWeL+qGEDTZ5M9Cuj985YLXfHrEKm2yHyGV s0kQsntihXFul1ZhqpRWXJrd7awFsNtr/Mg6eUmop0R/b0RmyytNlSrrSq0jKYunzNw7uwi+Fqd uu6q+87jNRUYFOnb6YxwW3OknKEl7+5+niR3mw+L2ZgHZey3M1MAz9mrnOOtIaaGUjFZXjbUW6k udW5OXhHJzq5Z9FDlqsPG3SMAmpudnm4ztxurvN2+uJixiB/kFSIs8JeHHVA== X-Received: by 2002:a17:90b:560c:b0:38e:70d5:b12d with SMTP id 98e67ed59e1d1-3903c537991mr6370889a91.6.1785928872075; Wed, 05 Aug 2026 04:21:12 -0700 (PDT) Received: from dio ([103.161.231.136]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315863fd2b3sm16820648eec.7.2026.08.05.04.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 04:21:11 -0700 (PDT) From: singh.supreet14@gmail.com To: Viresh Kumar Cc: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Supreet Subject: [PATCH] staging: greybus: spilib: Handle SPI device types with a switch statement Date: Wed, 5 Aug 2026 16:49:57 +0530 Message-ID: <20260805111958.114209-1-singh.supreet14@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Supreet Replaced the if/else chain with switch statement. makes it easier to extend support for additional device types. Remove the temporary spidev variable since it is only used to test the return value of spi_new_device(). Call spi_new_device() directly in the conditional instead. checkpatch was run, had no warnings and errors. Signed-off-by: Supreet --- drivers/staging/greybus/spilib.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c index e4d1ae8308aa..53fc0c124754 100644 --- a/drivers/staging/greybus/spilib.c +++ b/drivers/staging/greybus/spilib.c @@ -444,7 +444,6 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) struct gb_spi_device_config_request request; struct gb_spi_device_config_response response; struct spi_board_info spi_board = { {0} }; - struct spi_device *spidev; int ret; u8 dev_type; @@ -458,25 +457,29 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) dev_type = response.device_type; - if (dev_type == GB_SPI_SPI_DEV) + switch (dev_type) { + case GB_SPI_SPI_DEV: strscpy(spi_board.modalias, "spidev", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_NOR) + break; + case GB_SPI_SPI_NOR: strscpy(spi_board.modalias, "spi-nor", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_MODALIAS) + break; + case GB_SPI_SPI_MODALIAS: memcpy(spi_board.modalias, response.name, - sizeof(spi_board.modalias)); - else + sizeof(spi_board.modalias)); + break; + default: return -EINVAL; + } spi_board.mode = le16_to_cpu(response.mode); spi_board.bus_num = ctlr->bus_num; spi_board.chip_select = cs; spi_board.max_speed_hz = le32_to_cpu(response.max_speed_hz); - spidev = spi_new_device(ctlr, &spi_board); - if (!spidev) + if (!spi_new_device(ctlr, &spi_board)) return -EINVAL; return 0; -- 2.55.0