From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD92324B24 for ; Wed, 5 Aug 2026 13:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785938206; cv=none; b=RhLU4tNpaeGojXXs1K+ivr8wPpQUaWLHn9lWxIFF0tJc8F0pugDPgvWIc5rVtRgOnjHZpkonrLlQ9wmXg0LzZuEQ6WACRDNgPdjDbdIrTWDdmbBNbXedpECa3RTjuPgEi5kxZfSZRBcSYS/bjb6avHNH2v6OgmLemxvR3wTwibU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785938206; c=relaxed/simple; bh=y4ReOv3/p2ZVUWLYVVuEtoSDpxFdCV6+NIAGilgmais=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lCzGpRaTs4kqSvzqJHMSzGz4YelWMDk3xv5F1OB1RTJFLx9ZHw2cZgn7F/SfXtbPC+XCwym9UjJ3KvN7GPNpvAzFi2Px5BZ66F0nta5d6j0ttHgS6DwZ5UoO0R7nssYP+fU+85i3p0G1+q/R+40+NwmmHkM2RXf29JH7FXznCWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ns5LMZv+; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ns5LMZv+" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84e507b079dso662278b3a.0 for ; Wed, 05 Aug 2026 06:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785938205; x=1786543005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=geCpgKFpv4eJyLP95gigsbi88GQYWiUgu3zzK9iLvoI=; b=Ns5LMZv+Ky06mKVrM1w017gT8VGFiUzgf5LQ1BPNBr+St4gDltwssTGkEhjSidXJjP 1afAvO/ycbMazVBO/MBeZRh2ROgQm1Ja3h3z+Rr+aG56nuYNbwbj+Md39yYv2MNPsXrf /t/KLgU1vGUo1m428TGKlSxnzv13BpmSh6TpwhqK3JyOqt/6Kkn5L3bBdSraRlpn8hIU BOFH2LMfbmUCXJWPkPoAm6oRuNcmHRkGeXx9PnD3+Be9k/Rk/pAsxppw3NRpoRDfrGKb vFP3jPj/3o4YIX0w+FX/2KbXrYApSXDIigNE0ypTZRaKKjUa+oBgkTrJHJzKTsLLNNhD 8zCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785938205; x=1786543005; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=geCpgKFpv4eJyLP95gigsbi88GQYWiUgu3zzK9iLvoI=; b=PDJtgQWi5aAWerINjzepeqwf77mEazijr1/stQmmTpqxKUZnZEC0bXQYN6mcKT/hYQ h2jMTgLSnGz6VdBA7uiXyP8dzbpDCTAQDR1s+3Pxzgtp/1wkTsjywDfMIplqEH4qOyNK B9e17yxWHZZwtllxsqCNp4wGmnRpABYuhNxk/JjUV6mq5N3i6ObCTGHuuMMUj9kwOAf8 th3eS0RGPj0p3q/9v8ql2KaPPPMOHpR46RWwzzCY6UTtbnqIaw6CdmN6frtRTuXzmHJh maGWXTOXd/7mN50oBekltVg3dax5dHXuMHBpCz3vrlwyC0Q9tHmqDh+DIz8W0mo4x1Wb rsgg== X-Forwarded-Encrypted: i=1; AHgh+Ro0vIL7Ph6RUlsWJYVI4XGxT7YGuMX/rSw3ra5Ly7qrOs35FTLtrrE+4dp9d0Uk6k0F27G+fG+O971Ovd4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1GBmOTHGJMW5IrlEaKaAb9JHAbFfQOWGBpO+Gh7+cT3DQrke1 KjegtE/CmL6WSqbV0pSuxUGTUdM+JgUa+Svys42WSuywBYRZwkrOjc4v X-Gm-Gg: AR+sD13K1n54JUPPD0/W2xWNYYgR93XWrc8TTt4OiYb8WskK3PACf+ASu9wzv7Rw6yo tTcBmm90er12nRNqGoXBThLqzm2dylgDNc0pvY8sAHMW14H7RFomITVCcIT2jRbNnNlCUX1EUa2 NBDbOgPLUaGtXwbkvyxfpRoLMIb3i4/fdCjP9XELu7SNy7dq8wQUPvPBLGhSYB/2hS38ot6+zOt mE+q8/xvYTyq0RMSl5k0a1stKCJWl6FAcjIk3NZgfywvIZu1o88G8j+u9IpjWxiBdoH/2ofUCe2 v/UlYwVFOtSdGRbBTTQ0pqC0BOdXBK7GSd9liFIfmbUfW+fic3Miw58T/X4+dWuOnHspuvwgK88 rDGyQh89nbDBNZcTTcEb/IqSb4vxZryT8yCKCxPA9g+iBGWJT9THM3tRi8oQ+GSAqnHp313usMY uNUkk2Up9uYqjW48sivQ19IApNUF0jZgUtmb3ZWXgMHZDInno7kGTplgzrCROohUm+yw== X-Received: by 2002:a05:6a21:178b:b0:3c3:fb32:a004 with SMTP id adf61e73a8af0-3cb85fac065mr8961897637.34.1785938204660; Wed, 05 Aug 2026 06:56:44 -0700 (PDT) Received: from ahmi-PC.. ([2401:4900:88f5:5e4b:e580:68e3:78da:9f5d]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3158673be4dsm22066935eec.16.2026.08.05.06.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 06:56:44 -0700 (PDT) From: Narasimharao Vadlamudi To: sakari.ailus@linux.intel.com, mchehab@kernel.org Cc: michael.riesch@collabora.com, jacopo.mondi@ideasonboard.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimharao Vadlamudi , stable@vger.kernel.org Subject: [PATCH v2 1/2] media: i2c: imx415: Return test pattern write errors Date: Wed, 5 Aug 2026 19:26:34 +0530 Message-ID: <20260805135635.56556-1-ahmisaranrao@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit imx415_set_testpattern() accumulates failures from cci_write(), but drops the value and always returns success. Return the accumulated error so V4L2 reports failures to userspace. Fixes: d5df1c7f3f83 ("media: i2c: imx415: Convert to new CCI register access helpers") Cc: stable@vger.kernel.org Reviewed-by: Michael Riesch Signed-off-by: Narasimharao Vadlamudi --- drivers/media/i2c/imx415.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx415.c b/drivers/media/i2c/imx415.c index 0b424c17e880..f5cd79da512c 100644 --- a/drivers/media/i2c/imx415.c +++ b/drivers/media/i2c/imx415.c @@ -686,7 +686,7 @@ static int imx415_set_testpattern(struct imx415 *sensor, int val) cci_write(sensor->regmap, IMX415_DIG_CLP_MODE, 0x01, &ret); cci_write(sensor->regmap, IMX415_WRJ_OPEN, 0x01, &ret); } - return 0; + return ret; } static int imx415_s_ctrl(struct v4l2_ctrl *ctrl) -- 2.43.0