From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C94142AF97 for ; Thu, 6 Aug 2026 09:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786007503; cv=none; b=ZX7f1cu0+opcg9E7rCw74P0mwimY5mRIqbUPRC+8Chkuw6kjV7pOk6Xl8mTYcB2EPFoYJOrlIq2qfBPMtTxhKCH5cZeGbp+HSW2ZlUY1Hxq+xiCjYXl61UdXhHzhHbvC/u+8Y2uon893MwzvO20EdFFl1yBbYAzy+UJZQDefT0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786007503; c=relaxed/simple; bh=uItlWXb8MPOhAwOvNC2QGMkec4Tf49Sn3KyLOnrdPe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L6NuK28gjNqtswT45EJpzCb/CqfI/uF5LuOgnZsbQFDajtFkMYvZLm8W1v1o4P2z49CYXQPrpbqkjM/aueY3Hx0tGA2VMF+PEBpN3iRBjK2RRKb2gGB6xC3wVpcYAN2tytHcWI6hfMKT41cuQ0rrXWAxzavpHeDTd8YQriuw4eI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=XCPX8c64; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="XCPX8c64" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so20493055e9.2 for ; Thu, 06 Aug 2026 02:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786007499; x=1786612299; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ctVxRTZld6mMfNeZZIDIMzyUTqfRuvudSqrKgHW0waM=; b=XCPX8c64SM5ZN3DxBegcSa0M+Ptke3o2E8De+TayD7zB1+CkzNRz47cXPNX3Xjr5NE OYsWV3oB48TJyCq5QuTTse0SzlrSXqtmiLi9pKyP5XrS4ZUeqlez1E45fcrjsbcacAvv P4x8FoVxcYaSWbI3djkdOu4PtIIZXMXPihq6G+s4CsIEbAMrLwnErdPw8w0TxrdNp+QF WHtdQFtY0hqi84lwU+H5UDRbqb8CFoAJccxvv49WS7DvX8iL53w+gqyHAIDcCuQe7XlF Is+7AsAl5oZuGBzvKleW9aRTxrYQRxo6UN3aYQN8yHsEfuJ2DnfzHY791KtTmuf61I93 hRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786007499; x=1786612299; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ctVxRTZld6mMfNeZZIDIMzyUTqfRuvudSqrKgHW0waM=; b=Hek+opL60u7HrNmHE2F84jBb7l0XkGaFjN2TkRCv35sC/gdRHJRwl+rI5tu/a1HSNv VpE5fQHR1EUaAQPkXQbhn3ilOQp1yd5SD47vtVHb6NVZJuKbTsNhpQdCi5pp0jifvU2d V6r3SAxzn3EYWlOkkyogRYcVrTKCoTYNnmz8C2lhNO3dF38BHtOEXxJ2Wy+ufJa0Chj9 3UthMF33Np+v8uZluI+tIb1oCOiBEJ5tj9wZkB0a+YGEGDlljras6kzyZfrU+OBCgHdw 8SpMwBlWovH4ha8jKlIdsf/WWozRl5FNUjVtLvXAHDRQGmgb35COlPcGHEvjjupHvxGl E4cQ== X-Forwarded-Encrypted: i=1; AHgh+RoUIu964hWHDwIa1pyHFdtWOQZv7n8j7ppN+2KB8Hl0cVM6ldqbTWVEeuGVzrLIQYLZLrlnsu64cytvJEA=@vger.kernel.org X-Gm-Message-State: AOJu0YyrubglQ5uYafii8yoRvVUG8+V2gQ7tNsmlFyN+rEAXjREErM16 6Dm1Nb3KKU4BbjMXD0IIZKcMfARZ5rYZA/S6bdc1oQDn8LuyVBGHv4Q5xM6n1iFPnaU= X-Gm-Gg: AR+sD101EDlawM5luPe6YkuYEVwQh7sNmAuluk+3/1Di02tzux8gafddvHXRWq6KAzp 2JdujHqBH1KwlS01Go7PMnvh0k4lAPKnzo2HSthcdQBMtfVFmilqQm0UXwy1YeM5QWKWloH2qEW 0KhuniopT5FQgzBD8FLAIkyVlgY6uESWpKT1aF/wwFlHPBfx9glGt96pNhgSQWSLqx5xuyD+wiv MhXyV2Ev06O2zvVuK7A6gGF/AEjuI/jS5MUYe9Y+7mLD17/UDt0yS+g7xYji98Iskqyk6XUnLiY kWpCMWRuLWBRTWIa1+D3MkpvVNvRl2y32Gfjr+F3xi4pYk5HXmVQy/DG8FVvPu6y7Z0HgrLSgcn rSDcJDFA3K0JQoi5n1AxLAgmg2ISSgEjpnd+kWLPRvamgXyx+PRYeJJm0x7QvrhRsE3oC5p4YTG HyWmN+v38np8cD/3XZwBSEjSOD5N5yCPCmvvwszyCK49fzMk2pUVZMxlqZ X-Received: by 2002:a05:600c:4514:b0:496:bbce:f3 with SMTP id 5b1f17b1804b1-4994e71ed7bmr166617635e9.6.1786007499010; Thu, 06 Aug 2026 02:11:39 -0700 (PDT) Received: from zovi.suse.cz ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e4c32e0sm93157095e9.0.2026.08.06.02.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 02:11:38 -0700 (PDT) From: Petr Pavlu To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen Cc: Aaron Tomlin , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 5/6] module/dups: Use strcmp() to compare module names Date: Thu, 6 Aug 2026 11:10:19 +0200 Message-ID: <20260806-module-stats-rcu-v3-5-2b0331106f00@suse.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260806-module-stats-rcu-v3-0-2b0331106f00@suse.com> References: <20260806-module-stats-rcu-v3-0-2b0331106f00@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Use strcmp() instead of strlen()+memcmp() to compare module names in kmod_dup_request_lookup(), since all strings are NUL-terminated. Reviewed-by: Aaron Tomlin Signed-off-by: Petr Pavlu --- kernel/module/dups.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module/dups.c b/kernel/module/dups.c index 201a7f4c151f..fa3a4e623543 100644 --- a/kernel/module/dups.c +++ b/kernel/module/dups.c @@ -72,11 +72,9 @@ static struct kmod_dup_req *kmod_dup_request_lookup(char *module_name) lockdep_assert_held(&kmod_dup_mutex); list_for_each_entry(kmod_req, &dup_kmod_reqs, list) { - if (strlen(kmod_req->name) == strlen(module_name) && - !memcmp(kmod_req->name, module_name, strlen(module_name))) { + if (!strcmp(kmod_req->name, module_name)) return kmod_req; - } - } + } return NULL; } -- 2.55.0