From: Borislav Petkov <bp@alien8.de>
To: Daniel Gibson <daniel@gibson.sh>
Cc: "Mario Limonciello" <superm1@kernel.org>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 2/2] Documentation/arch/x86/amd-debugging: Add section about delay_suspend
Date: Wed, 5 Aug 2026 18:41:51 -0700 [thread overview]
Message-ID: <20260806014151.GFanPmX5VhBUG_6DLS@fat_crate.local> (raw)
In-Reply-To: <87aa8f40-2c99-4bbc-88f4-1ef6d54f3c60@gibson.sh>
On Thu, Aug 06, 2026 at 12:54:04AM +0200, Daniel Gibson wrote:
> That document mainly talks about s2idle issues and lists issues that have
> been quirked in the past, so IMHO it fits there?
Did you not read the first sentence of that document?
> Also, Mario Limonciello (of AMD) suggested documenting it there in:
> https://lore.kernel.org/platform-driver-x86/f86d9af4-6415-427a-9f4e-639b2ae6203e@kernel.org/
Maybe he needs to read the first sentence of that document too.
> However, if there's a specific Wiki you think would be appropriate to
> document this in, I should probably document it there as well.
You have a pretty good commit message in
428b9fd2dce5 ("platform/x86/amd/pmc: Add delay_suspend module parameter")
You have a bugzilla entry, you have a mailing list thread, you have a module
param documentation.
How much more do you need to document this? People should be able to use
search engines or AI, right?
The problem with adding some hints as to how suspend can be fixed on some
laptops is that we'll open the floodgates. Do you know how many laptops need
quirks and fixes for suspend?
In any case, this doc is not for that.
Sorry.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2026-08-06 1:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:43 [PATCH 0/2] Document amd_pmc delay_suspend quirk Daniel Gibson
2026-06-24 12:43 ` [PATCH 1/2] Documentation/arch/x86/amd-debugging: Add example for reset register Daniel Gibson
2026-07-01 22:21 ` Mario Limonciello
2026-06-24 12:43 ` [PATCH 2/2] Documentation/arch/x86/amd-debugging: Add section about delay_suspend Daniel Gibson
2026-08-05 22:09 ` Daniel Gibson
2026-08-05 22:40 ` Borislav Petkov
2026-08-05 22:54 ` Daniel Gibson
2026-08-06 1:41 ` Borislav Petkov [this message]
2026-08-10 17:27 ` Mario Limonciello
2026-08-10 20:28 ` Daniel Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806014151.GFanPmX5VhBUG_6DLS@fat_crate.local \
--to=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel@gibson.sh \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=superm1@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®