From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC35931AABF for ; Thu, 6 Aug 2026 02:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983982; cv=none; b=jmkK8QbbCAD+l/Cw7aC3QlKB264eqikiuIvJb/vpCBTLiZX+rMyTOQA1YBp57zJAyW7V+j0fBiRWLZMaaDcuqgSM+ZypnuPchcZXklY1XI9nViCdLIZ3h3cYw2bG795q5klfpGMwnuKsM0zw1L4ucSsWCO2Ha35+nkd+l9F1jd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785983982; c=relaxed/simple; bh=5C7wceqaQFO2f4qXEFx21ohpcplYEZ+eV+kQkbGuCaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lqut1iUtEquFGEgDmwb4uVEQ4c5Fy47OACCTLYUjZXBZhM+jfJUMUXRTl72yjZPMrbDYtywO7fB9U19cDEt8rJ/tbdGQHRDtlBarDwn0B9bZEmpiyTyYi34lSWkDKa1BNlbFrCuVRI2mJAAcJ3wjNcjepJRh6tms3uSD9SAbR7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g0FA+eSA; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g0FA+eSA" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cc891373e0so21326145ad.2 for ; Wed, 05 Aug 2026 19:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785983979; x=1786588779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=g0FA+eSADRw2B6119f5psjPTMxSFsLI71y2D96eZDdxzSErTKUVi9TlvLcLanOm2va X/18z8nqaHoRzu2QiQ6h+94I2cngetdRuNdg9cP3Rk1x56d46OFQcr+075Uthx7L+n4h Tsz7uyKmt2us2tkI60bY4lm335es1ODUNVdqY3JsNIGTb/pbr+Ef7MzjPtKnRwL/ufx+ 7CTIMPuhiAkn183BcWEM292JD1NURmj0BhLcW5l/dRmoPXe9mhPFAIGL5ISUfHsm7+xh 3S8ZQi87ZodZJE7aMMbgSU2AQ/i43bImLWqe3wJda5SILd2AYSJgCouLtbANl0EznlqC 3csw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785983979; x=1786588779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+19O7nuCCtomwWmgwH/WqZ+QVpHVmBP+p+odMSd16YE=; b=ll/k50LFkIpJX4jktHVvMxj7Ui2YeELy4lxVZpYqzEbF+/L5rDL0u7xPJNwqJqi1xw CIq5ZCZ/XalKH5BoG+NN7iXD20npq9XY6KpDKm9ZEQN3A2uZThXNzMRTmJkLqd/LWXHz y6wvLQt3ZGVenup0I1j+0YCsthsKO/GPbPOxEmxfu16c2h64UWg/DtCZ8RWMDvdAfvzk Bjv2/T8RQslAz3m6up4QUzS0HDut+h/5YIiS2YXihNgbQF3d0PIa2Gh7z/QP9TAvG3fz fxyioYBdOmIJOMZwM8XL5hDEanqLb3bzfsq294Ld/M2qmEsQT2ycQh8eWf+1V12BZUSY zcAQ== X-Forwarded-Encrypted: i=1; AHgh+RrwO9/V3CkoPz+NzCClyPMOE2My3hkry6AI5f99cW3Ras8jObkxXFZ2Rlpf9PmK/HEcXEkE2BV+SfilO3k=@vger.kernel.org X-Gm-Message-State: AOJu0YxCqAuH2GQuHy3lu0DyoKKEdVhA2oUZ4d3M9CdsYecTiURII7xF LlUG0b5HA+MgtY5IfYON8YcUgzvQ7Kcbqby8Z9b0SGWks2q3Gnt1akIE X-Gm-Gg: AR+sD134OL3ipYEgFrtDPKJkIYvKuLwm4O+SV7jKVAZH8nPH1/tPnHiaxZWf6yv6q6L jeVLwdxZuMLOM+fw6fx/mTVXveSGLY15Q8Qvnt4UZTKOWjTChu4ACknNLmh5ooQt3iV9emfWzgl bp/01RsrO95PQK/5bBanJZKgcagtiyzAiE2xdnijM428u8dt2UMzAXFID206i4j1n3lXbzyZxoz D5pN1M3zXPb+UnxtR1UE8qSXL/YKjrEZQY6t+5R4ohCOGlfHOCpqkajnlHuCLXZnMbz0ySCUDNb T1M+JUEF6PPsAy/RCpxCtLHg8f5wxGMcMerlLp5AlSWG+pRrxqClWdROrs9upnwkGzEoBQSNM6p G4MwIQgP86xX0Z6plHoXXaBCjmSbw0UwEKiGLsJmMsup4TbWVfpzLKmDw6b0q7toAftv4q+2ry6 20miuH+6+oJlywgX4UtHjFoS57g5Otya1sYMJ/7PqJc5kf4qzEzTHp7meNgzqyC6nkSJMP6Q== X-Received: by 2002:a05:6a20:430b:b0:3bf:9b3d:61bb with SMTP id adf61e73a8af0-3cb85ee779fmr13430627637.16.1785983978646; Wed, 05 Aug 2026 19:39:38 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:3194:1e48:e141:80ab]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315867d4929sm22404383eec.30.2026.08.05.19.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 19:39:38 -0700 (PDT) From: mdshahid03@gmail.com To: Jonathan Cameron Cc: Andy Shevchenko , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Ray Jui , Scott Branden , Broadcom internal kernel review list , Markus Elfring , Joshua Crofts , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH v6 1/3] iio: adc: bcm_iproc_adc: Remove redundant probe error messages Date: Thu, 6 Aug 2026 08:09:00 +0530 Message-ID: <20260806023902.8608-2-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806023902.8608-1-mdshahid03@gmail.com> References: <20260806023902.8608-1-mdshahid03@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mohammad Shahid devm_request_threaded_irq() already logs an error when the request fails, making the explicit dev_err() redundant. Similarly, iproc_adc_enable() already reports failures, making the additional dev_err() in the probe path redundant. Remove both duplicate messages. Signed-off-by: Mohammad Shahid --- drivers/iio/adc/bcm_iproc_adc.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c index cf4738b16e62..7c2e2770cd61 100644 --- a/drivers/iio/adc/bcm_iproc_adc.c +++ b/drivers/iio/adc/bcm_iproc_adc.c @@ -551,10 +551,8 @@ static int iproc_adc_probe(struct platform_device *pdev) iproc_adc_interrupt_handler, iproc_adc_interrupt_thread, IRQF_SHARED, "iproc-adc", indio_dev); - if (ret) { - dev_err(&pdev->dev, "request_irq error %d\n", ret); + if (ret) return ret; - } ret = clk_prepare_enable(adc_priv->adc_clk); if (ret) { @@ -564,10 +562,8 @@ static int iproc_adc_probe(struct platform_device *pdev) } ret = iproc_adc_enable(indio_dev); - if (ret) { - dev_err(&pdev->dev, "failed to enable adc %d\n", ret); + if (ret) goto err_adc_enable; - } indio_dev->name = "iproc-static-adc"; indio_dev->info = &iproc_adc_iio_info; -- 2.43.0