From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C340F3F4139 for ; Thu, 6 Aug 2026 10:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011127; cv=none; b=luttZlyKCbCpF6OJ5iP3LY4LeYD5r/dZmbY/ZhY0nW3kWwFZt8zymGlR1fZzvgQxIey+mB4B6PrBQXiN3zCHGDVOfM9arKhyeaKLMQT7jCbGLBkWV10XyslBYn1iACn/FvXYaMC+Aohlj1FQbpdb2F5s1ShFh3SjB18wElcc7o4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011127; c=relaxed/simple; bh=dDFkiOZCR6vFnvQRyi43vYP3khgC2hrP5tR5WhrCVGE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b7zSKUdLVeA3LrdrIh4hXm7pE0V8JJW69caZzxPZhqU3aQAAA1RN6+APUe/Id/Gqk9+DU1C7rBpoCmjhuVmQcRA4r2yIePAZ16GBPm3VUt3cuiar56rEwimoa9sizhQTkkutjWpKbo0QIUfdQ9BsofedctzLGjw59z0jS+zCzdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bISHegOR; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bISHegOR" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca97d139d8dso1324106a12.2 for ; Thu, 06 Aug 2026 03:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786011124; x=1786615924; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3XtAiplxMmMFNrwGgH3OvUxuzrJYevo4RilZFtq691U=; b=bISHegOR8XPxXXH/ktIcTJO4Y9m72Wto6aDwHTFbRmGTgfptEIaAIBMxhOOkZe7LoY GsLi9Jy1JVvsVCR2XlrexA+T1k1eePOLOabbSsvWee7ShzRzmHRpu76RSgAAAvoQ+LdO fZwdeYM+3nN9EOliJXvTlptqhIhpuy5bchIMa5xnHVwX3KAfAW+D3iRMj2mMJjNfh87+ UF/ObiX/8st233yaBANq93t6rqQA6vYLWP5Uw3DGcG7FZYAwj6sl1wRMdaSQ7UaQbJc3 Vno65zbf9tmHlbwSKgDoR4mgi7oUJ6ZUTjM4ugWbEbC945gXIHFF14jdwJKjnY9LTxTy kjeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786011124; x=1786615924; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3XtAiplxMmMFNrwGgH3OvUxuzrJYevo4RilZFtq691U=; b=hBR80tBFtk95abHGfJuzB9LKmxPdHbFjvmbgJVtSJmje+sOmEUNOoaueTyjMRIMHv1 wnNCJV7L3w/HjF+vqRt4Y+9UCGXv4ryYzktEIn3W2mePu5Wt/oytTShXG7FRyugwt+H/ g4/HJBhri9hmxY3MCIrNF4pIy+vrTA7GBWYqcP0sbTNnODG/tsd7QcXhHUP+MMw1sVH/ 6mMwYo5esGsV+AKSUIRNYWFtj0q8qezGLTC9rCLojlutKNpzXRH4NqSWSgBwWSTZnzZ+ PZDUHrkWC4NdYWOVpWuJOAiMKipMKms5ufstFMVNPhMy6aGxV0AZEYFmhNk6IZZnDwMi fETw== X-Forwarded-Encrypted: i=1; AHgh+Rou9KrwOuOoeTmQeCjLQaCdO14PsbLlvoi50i5+C2u3pc/sz2PEu9ZeOGw9LvWmAJwZGVFnVeyPQXM1Q/M=@vger.kernel.org X-Gm-Message-State: AOJu0YxIWV61tQbWNr8yiB1fKftoWtbrCNO9b0HdLr1QpADaVK9GAHSQ rCMdikinbdnxADZCloqj3Ur4Su93Ky+P4mpyqdbgvwZpxOmfSJe3u2HT X-Gm-Gg: AR+sD112+Obh8AqFvDElQFndOs8/UDYcAgMjQcr6ghBnzni/YQXS6uYSSmC0w4XeD45 yb8RxPsdi6e+su+cI7w15uHm0b262Z1qc7ZVeKfriJDkfNU1B03uygi/eGLW/5ZlHU0T7ckwdxC 9xOfNSu01GxrcrGHyYrzH3mxgw119qvbik453H3jkkI1mt71G/1CWhBU+N++PQY+u5yWrmZ8D4w hU5BKJX5RmeRy+ty5nDMR+7f4TUa+Yz3i5w6jjJIm2H5w0jl6859Lq4arJOMBIslGf9qbGB8eGM y5E8nYiG908ktIeSt9nJ+sMnFVSVwP5zHwbqXx6r+Vpe6Wgyfnc3lCmwENi2ZPYNI0BSUlCkGy9 h3Ns6Oz6Jpce9VqWwUzxAT3LNmZ18jAu8xWizsUF9eGsyRMWKynq9RjOfZJs+dTVpOWc2O7vBYG Dyhg8assSIEQb/y4Daj9dHMFOHW3nc5bsCBY4pJC+Dzlr20tjPZm6sVmoBEg== X-Received: by 2002:a05:6a20:d12e:b0:3b4:71c1:ab29 with SMTP id adf61e73a8af0-3cb85e3e76cmr17461336637.16.1786011123966; Thu, 06 Aug 2026 03:12:03 -0700 (PDT) Received: from dio ([103.161.231.150]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3158676f579sm24414248eec.20.2026.08.06.03.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 03:12:03 -0700 (PDT) From: singh.supreet14@gmail.com To: Viresh Kumar Cc: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Supreet Singh Subject: [PATCH v2] staging: greybus: spilib: Handle SPI device types with a switch statement Date: Thu, 6 Aug 2026 15:41:18 +0530 Message-ID: <20260806101118.146685-1-singh.supreet14@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260805111958.114209-1-singh.supreet14@gmail.com> References: <20260805111958.114209-1-singh.supreet14@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Supreet Singh Replace the if/else chain that selects the SPI device type with a switch statement. This makes the code easier to extend when additional device types are introduced and improves readability. Signed-off-by: Supreet Singh --- Changes in v2: - Restore the temporary variable spidev - Use the contributor's full name in the From and Signed-off-by lines. drivers/staging/greybus/spilib.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c index e4d1ae8308aa..d1b7ca9c4ee3 100644 --- a/drivers/staging/greybus/spilib.c +++ b/drivers/staging/greybus/spilib.c @@ -458,17 +458,22 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) dev_type = response.device_type; - if (dev_type == GB_SPI_SPI_DEV) + switch (dev_type) { + case GB_SPI_SPI_DEV: strscpy(spi_board.modalias, "spidev", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_NOR) + break; + case GB_SPI_SPI_NOR: strscpy(spi_board.modalias, "spi-nor", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_MODALIAS) + break; + case GB_SPI_SPI_MODALIAS: memcpy(spi_board.modalias, response.name, - sizeof(spi_board.modalias)); - else + sizeof(spi_board.modalias)); + break; + default: return -EINVAL; + } spi_board.mode = le16_to_cpu(response.mode); spi_board.bus_num = ctlr->bus_num; -- 2.55.0