From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055C243F08F for ; Thu, 6 Aug 2026 10:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011814; cv=none; b=dcjdlYHIBZvZe1i2UjMryJBv6ynnpmDBaloQWixiC/LxTZI+1MdLe4Pl+pJd88UeDpXy9Xr4P8Bh5/OLrY3hLi8jnCwYKg4i5b/Zm1l0Q9t4yvyRFMNCNlTwFuCtUFIbFor99lpmSSUyVtA7aMEgvvqI/GExqPT1VXp74bSlf2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786011814; c=relaxed/simple; bh=DPPGMlhCK/Jt0HlEn24QqXQAUu9fpcor/f2kkCNnxOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rWeWXZeaO792Uk3IWikDf23MHinZT33eeLQKz3qeu5ZvrjNRQFAKret6vtvz9+ZdPX8ktuZUbWv0dIEyUdQ0/S9VBmUMCoM6oIqHYNb9Di99HzI99rhcnih0PaW07ceqNCL6OJ+mVjkP4zchwuZPY+KHTILNJqFUNpdstzTCElc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A3YZNMQa; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3YZNMQa" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4994d41ceb9so2282555e9.2 for ; Thu, 06 Aug 2026 03:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786011811; x=1786616611; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=E08fZo9KB48N6tVhom0sp2LFhhwJahQDfyCHAaGb0WQ=; b=A3YZNMQaqz+4ocB+uim8xCwr+IT7F0F5SF26EZtwevj3DREXF1fwd543eWbwv7da+U dZfja/5T6+ofVQS1A11sDjICCnfuOo/8co7kv5199YOCKmeXn23g/I52ktdhcu/ZEJIK ZyCYIMOGSjFSdvFmgpNdaUbad3fIe8mYpkvX+mypypNKjOsninqfKevidy0GExarWwuv O64XBIO3twA4Qj3mDW4B5Xf54PpiVVdQAN/VidiQgj0X824KbQdiEVDAkOy685sW7KYr 9lKvZmc1DJHlby/4HM8shGki1m/pQC2Yu/JeQOwO+xMfegdG6GF3ecDcDdSsbTPnMXOp 92Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786011811; x=1786616611; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=E08fZo9KB48N6tVhom0sp2LFhhwJahQDfyCHAaGb0WQ=; b=dLDSA0IS05y94Xq5Ir+pEPFjncrXFLV6m1kerUIy50qOtMpsQcrlO1glogpOSG0L2s w3781QWAhgn1BKG3PHqRLUOiJIprtka3eDlnGvpnzbNGPBYRBdhLwdac0D3fgtsdCyVB ApCTuVN93Nk2loM/piaRcmzM19ICL+0skovE4vldPkUlktOj/OJDLTZDx6vo/1UWRfF4 fh2ACHwekx80zBQGENsiLm10Wr0D6X4QobStUii7R6fZTthvs/K43ippbhUap6Jzei2T atwnecX+c9YR+7akUjH+1HMhLZm2KKfuZ5kti0ZpJbx/Uhq9dbE21AllYqYe+SZxlhgx bMMw== X-Forwarded-Encrypted: i=1; AHgh+RqUg6rbwevCKCB5JOkOY30pNyrfxu4+hdTVXeu8vbPoMDo2At1uUTfWr3bCw6SEOPXhM2c522z4Z9HvHW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwaZE68vMe190dzNpsUo/4Uo84RMQF8Y1gKH+k8ig3mTWtrj/DX VobfHg9ikfpkQF2I6LMJ60mUGcCuptttaLZ9DPzl13/kb4SGfXQyvk+G X-Gm-Gg: AR+sD137TENZP1VsyhY4b+kyDvzZJmT1AeIOvn+LiAQ1RD93UQ/8bXuCEpZoefr7kAu KYN7U9j1BrEP9zw3l7zp2+vrWSnSAAJR9eIwugRmYaZ3pK6FSCperPEh+B5si64Fu5eXIaBdxGe ojJoefsRnJ4S49aUSJL+OO8To4OwPoZEl42ndGkyWojCpsOA9jScpS7D7jYCoEELVXKKd/FyM9b aLit5pSRgzaseDpoVSYA0Se4wySIS+EgxVnknd0BVULApZ9SLI7zK6ceLzPHH4UYtAfEDeBzl/0 5HRuHlz7f5sPILC20sxSWXGk82E8EFKBtoBwBpfJ7sGHJtkL32KphImL4AoHztHw9V/DFH5jzW3 coyoIOwoQS8EA3VYapJ23VzLNfDCx2VFKkdo+ggUl/46i9TtrKKW0vefS6hEqzVFIY4qbI7Nzwe oKGXyCObiO0LmUSAsZ2vvHwNIrunkmmCvQSW3znKp9jKfBX20JDvW0 X-Received: by 2002:a05:600c:1c22:b0:495:71ff:598d with SMTP id 5b1f17b1804b1-4994edf895dmr82139575e9.1.1786011811067; Thu, 06 Aug 2026 03:23:31 -0700 (PDT) Received: from skbuf ([2a02:2f04:d801:b100:3c1b:726e:a458:5bcf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542241c4sm49032335e9.11.2026.08.06.03.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 03:23:30 -0700 (PDT) Date: Thu, 6 Aug 2026 13:23:27 +0300 From: Vladimir Oltean To: Jonas Gorski Cc: Semih Baskan , florian.fainelli@broadcom.com, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: b53: be VLAN unaware when not filtering Message-ID: <20260806102327.wrig23oltjzogyi7@skbuf> References: <20260805072641.402-1-strst.gs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 05, 2026 at 09:44:51AM +0200, Jonas Gorski wrote: > While SVL is active, any ARL add/remove operations ignore the VID > field/register and force it to 0, making existing static ARL entries > with VID != 0 inaccessible, and any (static) ARL entries added will > have their VID set to 0, regardless what the software entry said. Is this a hardware limitation, or is it because global state (dev->vlan_enabled) blinds b53_arl_rw_op()'s attempts to look at FDB entries of the other type? static int b53_arl_rw_op(struct b53_device *dev, unsigned int op) { u8 reg; if (op > ARLTBL_RW) return -EINVAL; b53_read8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, ®); reg |= ARLTBL_START_DONE; if (op) reg |= ARLTBL_RW; else reg &= ~ARLTBL_RW; if (dev->vlan_enabled) reg &= ~ARLTBL_IVL_SVL_SELECT; else reg |= ARLTBL_IVL_SVL_SELECT; b53_write8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, reg); return b53_arl_op_wait(dev); }