From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FD042466A for ; Thu, 6 Aug 2026 11:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786014030; cv=none; b=dGnXTu91LUg4IZPXeDOytT8SWkZH/rX4Igkh5miiM8Zt2gxpqga2sQTHZ+70eZ4IxlgKGLlUdiptkpdhdObw0OGIQ92Fh3dzi26Y8Sl6+AzPBL4noEZpoXPnB/8wRKGR72goMauVnUW2eyMI5LpUMB06WZAvtMBEGmYw677Qp+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786014030; c=relaxed/simple; bh=RtRGD0hmoKuCpcgom91M7cTePbPST/NQpWJB4dWXO0Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jf07cKgGZjmE9gJFusK15WPYvdb6JRku5jfyKnPMDBsy9cxYx1tJqn+eXPG09/UaKVJiRI8CVUm5nj3+OddFts3aY5jLuJjGiXV5s0O2D9QKVL+++pI6XX2MD1rN8sh0N0TeistWdgZcYJksSs+B4GO2VnQME2poT3YYUQuLPzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NxK2WM6u; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NxK2WM6u" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-c15e03c2763so152923966b.0 for ; Thu, 06 Aug 2026 04:00:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786014027; x=1786618827; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RtRGD0hmoKuCpcgom91M7cTePbPST/NQpWJB4dWXO0Y=; b=NxK2WM6uwyvB0lGPh8aYz7oIb9HoMdPn9L71elQj2G0lcLFfU71H3hkOInRrw7FEbD arEw8hud/tcQ2RFFOk1IQzI0/CbUEx94m08akk0tOJxe9K9IjdlMjzc6ysgh91ejnaiw DLN5ze8eo4L0284yUBAok/5fbJb7C9FLL3vWkrlbD2SRCIuOYT3OscGllFriqf7jrW/y KNGEptA9NdRFbNgLSAndglJptAtkdwPmAi98VftnfceaiD8aKcMQT0aj7xgu0AMvN3W1 Wj35pAOw17XPGIX3HvUm5YkV1PQirHhelYxBBQUQC6IzrVY2yTrY6pI64VP9klvZa/iL +P2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786014027; x=1786618827; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RtRGD0hmoKuCpcgom91M7cTePbPST/NQpWJB4dWXO0Y=; b=GGwyS5gOwNZYfJQ/jROxe3LaKLtoK8P2VRKKmrkA3NqmhpUGEhkVt9RGUUT8DpC0WD gqgdUmVTTHkMo2S3uFDdSbz0yTG0sxFqkyr+iXHBhokWZB/ESyj1mScflwv4/ot3Rok1 4DLVc5TeIutoEIApsXZGY8mwbyfbiF/+zVU636FqHyLGtIXsZ8qR42oJPXmENpp3BTs7 Q+qUL76LyM67bagQ+o/yHxih0M7H0hmdDT5PMepKZ17vTvpF/m6KCup+MwvgiFsQXQZ8 fb8MZrZtd8lrG/BVeZ+ZIiOGH3AFE7o2WggN1UfmMCOLuZMCx7BlNx+G5MlMoYd0VX2V OObQ== X-Forwarded-Encrypted: i=1; AHgh+RoBPh8rYPdtsI+tMFIsknSVampcNex6kCdzqOZI6fW0MBgy4GtS0S1Ta0liQb0zr8VKfAbTcyP8fr5Xbts=@vger.kernel.org X-Gm-Message-State: AOJu0YwWWQt2xiLrxLo+WIPLpm/luroVHMdFxqTC943cBkMX1jllUV+Z Op+979+Jg/agkF3SMufJqn+r/Q8644X2ZsXq5KOGqMImQOLWLWXcm9Pi X-Gm-Gg: AR+sD11t1Qpmqebgb98Kwf5SopTp/7EORHSp/7JewTRK3nz6w+3FGktESl76T7qY9OX +7l5aqVLnPwb7514/3JY9Xd6bHfjTtes8FRMys7h/TuySKlRKdyFv5OURc2oLYYgSQPXV4+3Mye h+uoVD5ILTJ0CJvyG9rNASILCw3RSDCRC2JTezaaahBfjxPfzImXiNzFImzQPYsjfJmr3aPHv9k oCnKA7DstvKRnGKk3N+g90AnRAvEyeen/r+KIhxOit6zCxYVLVBMecN6BZCENCTUKxLYoRymiom 2kf5pmhMAY+g3TXqnT+ejEVh5kr4WvyeP450aLq0IpYPdrN6ObaDWRfgf3lEIgCNL4dwDXl7dt6 gn72V+TeSVk07vIb2Hb/N9NMMb9Z92ZlJrAlFvnA9CKpnWi+iwu5xykyiXZpMjtfqumCPZ9elNq 2YRiQFodGcVXsMlxJVY7fF/0/cBbrXS3jktumVMVlxEwBo5RCzUK2nTTG62gb1AajDTRFyOK9A X-Received: by 2002:a17:906:6a25:b0:c20:53d8:6fac with SMTP id a640c23a62f3a-c20635f3a9fmr175302266b.14.1786014027330; Thu, 06 Aug 2026 04:00:27 -0700 (PDT) Received: from foxbook (bgt135.neoplus.adsl.tpnet.pl. [83.28.83.135]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c20364613b2sm227501466b.61.2026.08.06.04.00.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 06 Aug 2026 04:00:27 -0700 (PDT) Date: Thu, 6 Aug 2026 13:00:22 +0200 From: Michal Pecio To: Mathias Nyman Cc: Mathias Nyman , Greg Kroah-Hartman , Bart Nagel , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] usb: xhci: Rework and improve the TD matching and skipping logic Message-ID: <20260806130022.77401337.michal.pecio@gmail.com> In-Reply-To: <20260805213028.78a73f18.michal.pecio@gmail.com> References: <20260804120110.01bda0e2.michal.pecio@gmail.com> <20260804120537.5c30554e.michal.pecio@gmail.com> <20260805213028.78a73f18.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit > On Wed, 5 Aug 2026 20:39:12 +0300, Mathias Nyman wrote: > If the event points to a valid trb ahead of last trb in td, but > before the enqueue pointer, then we know hardware has passed this td > and we can give it back. Actually, we don't, because of a race condition (and driver bug). A very long TD completes with Short Packet on the first TRB. We give back the TD and advance ep_ring->dequeue past it (bug). Some event is generated later in the TD but we don't know yet. We queue a lot of TRBs and move enqueue into the completed TD. We handle the event and it appears to be "before" enqueue. But the HW not only hasn't passed, it hasn't even begun executing any TD after the initially completed one. We give them back and later get their events, or IOMMU faults. Regards, Michal