From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F438381AF4 for ; Thu, 6 Aug 2026 13:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786022490; cv=none; b=ZU8g+bHxKWM2hl2TjAYYtx9fNd0n2RXZ+X4uaTNb/7IMPfPCA6YjGYKrBb7gO96L4I9a3p7DDiClNdTiDivrp36gMHAWiYxn8BzkPZoUJDjmKNy8tk4peUVBjLEaAGIh+IZfqYOk9py3Am6pcqaHVNTa8Y74Fcq6rNVi+7zvEB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786022490; c=relaxed/simple; bh=gfadCGLtggEJAurd/FZ9mhDOfgHYg0iKq+ncOchBJ8M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=S/akgtmz+VcoeLRQ/debouO9Kzad9hldMhvIgI9Oltq1mUqfpJUHZKQokuKZBr9Jx12b8RlKT2NaBmhsB9iSrguxPT85j74qUmK9Shj+JViQ6Zix656g1XcFGaAHdw85ysDqKjkUw0Ew+bXkv1tWrWwqs3GvVSGrtbFuy0jswP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmmu8SLe; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmmu8SLe" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-47f3b39f2a1so1652227f8f.2 for ; Thu, 06 Aug 2026 06:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786022479; x=1786627279; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+AL4CvOtEmUlLWL3axPw38b/ZnvPXXb2xlZ3xTvT71U=; b=nmmu8SLesk1Gw5RLh6QTm/iMRWBRdcYi4TySjTksf13PYAQlf8YWX37rvmU4MyoCVQ XLmJrzuYECdLuiyuD9BhxIoWd1Yp/GYCfMPimhoonY7NLw01Uq/XJqq2JU1iuTf9m68T uIQzpdTIx9lL8Pgu6Kw6SdW8BBqc1Av3nNAOyRglKxnQo8h21oLVyYEwvYKORbKvIOm1 0RgGAMLUl5WXn/kVc/PwCZxB9K9Ab+Ph8QiUZfaCSCWQvG1F1IKliKV2dJSL7Kvol5zc pvsKV6oQOZO45L7MGuDW3cvfRo+70RvO/8PraxihWpJYkjzZHfdTDa99HAfHuX6pw+CX Sv7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786022479; x=1786627279; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+AL4CvOtEmUlLWL3axPw38b/ZnvPXXb2xlZ3xTvT71U=; b=Kv6hc750uCiX577NJDHK2LbX93zXZSUbJ2LbCX1Pn4EN8Y1VfgGzRDCjszQp2261X5 E6drb7KRRbJVOGq5kIod2pZTNMpe3rMS5sp2OPxGhQFkd5LOpIKOWlnxRI1kBbOwHYKT vHL8fyAcweL8Xw4yU2/YD+PmKDUKJeeSXWsy382iwJWY2cOrcRKk0Z538vP0w8sWD+8O +MFMHFPNTGWAE5pnDwV+Siw3x31QOuHfs6dJ/4/HL4v3XETRRAxRUlTvk3V8J9Ms+Pll tlDM+enR0rWss++2ZlhFxw1bUFrhlVAOQe0AsBC8021qAhgu1jufkZf/b1+3NMvJJYRN GrHQ== X-Forwarded-Encrypted: i=1; AHgh+RqyIKdsxnbpMLm73vl6XgWfyKh8gQi4/UB5No0QC4POZwM+Sp3r2uE+D9FNANMFc713xmI2qgnhL9osDB0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyqr1eTxOo98O0wZdYcE+wB3Yn1id6Wbq1t2c+8WhBf0kjVYVSm mgIfIUQB/mMM07p/Lr+7m5H/Ggi79IoUMZwThveaEgGAcFB/QFelB+qH X-Gm-Gg: AR+sD11INo9xWWEJbB7DMaUQuTtP3quYVmdSOPqhsGhdd1T9DMewhEuc5s1tkmTECKZ OSNnMtU+bX6H1+J6Hdc7+XgzBp32KzshA4OOROxQszNFdb9MaU32/otqSa9JfFSH7NAZ2hGWjPn JPhnj8+ASXBsIcbe3Kk//atIg9FwWpKzepakfAdE8k7iU0Tk+yFNEeRKtp8qv+9GzSLDm82trih XAMWhZNs4MbVWgwUGfzI90PJiv5IiFtlJhgEYLtXUbHW2ZSHqsgVsy4haRPH2fBgc+1nLPUPraK epk/fqF1QZZutpj3O4hn50m8svLBPbGP+giygrgkC4HKbcVyCqHOksyE1Tb62LMLX0LaLKpNAbU gisy1DtoJJDqBg7/BjBstMMNetc+4DRhTo+I05q8TjplhAqWZfHxgXHWFPSrHGC/7xfoBrtQwu6 H0zlMjjecyKnfbcsSnrVfqzK5THDgJ5YcGez2sIWVz03mkBVIFQiv8Aty9u9sYItgkdM4A8Q== X-Received: by 2002:a05:6000:25ca:b0:47f:8480:4abd with SMTP id ffacd0b85a97d-47fec62f995mr21583099f8f.29.1786022479251; Thu, 06 Aug 2026 06:21:19 -0700 (PDT) Received: from fedora ([2a02:2f0a:7305:1100:2d17:dc4a:b635:9a95]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b183b2sm6884124f8f.24.2026.08.06.06.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 06:21:18 -0700 (PDT) From: Robert-Andrei Mercea To: Greg Kroah-Hartman Cc: Kuen-Han Tsai , Al Viro , Xu Yang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Robert-Andrei Mercea , syzbot+7cc26dd73231714cecd4@syzkaller.appspotmail.com Subject: [PATCH] usb: gadget: f_uac1: fix memory leak in f_uac1_opts_*_store Date: Thu, 6 Aug 2026 16:21:02 +0300 Message-ID: <20260806132102.88183-1-robertandreimercea@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit f_uac1_opts_*_store() duplicates the page given as parameter using kstrdup(). It parses the duplicate (stored as split_page) using strsep(). Upon completion, it frees split_page. strsep() mutates the string given as parameter (split_page in this case). When it is fully parsed it becomes NULL. Instead, if an error arises, split_page will be a pointer somewhere in the string. In both cases, kfree() is called and the original memory is not freed. Fix this by creating a copy of the original pointer and passing that to kfree() instead. Fixes: 695d39ffc2b59 ("usb: gadget: f_uac1: Support multiple sampling rates") Reported-by: syzbot+7cc26dd73231714cecd4@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=7cc26dd73231714cecd4 Signed-off-by: Robert-Andrei Mercea --- drivers/usb/gadget/function/f_uac1.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c index 85c502e98f57..ce399e4b80c4 100644 --- a/drivers/usb/gadget/function/f_uac1.c +++ b/drivers/usb/gadget/function/f_uac1.c @@ -1595,6 +1595,7 @@ static ssize_t f_uac1_opts_##name##_store(struct config_item *item, \ { \ struct f_uac1_opts *opts = to_f_uac1_opts(item); \ char *split_page = NULL; \ + char *split_page_orig = NULL; \ int ret = -EINVAL; \ char *token; \ u32 num; \ @@ -1609,6 +1610,8 @@ static ssize_t f_uac1_opts_##name##_store(struct config_item *item, \ i = 0; \ memset(opts->name##s, 0x00, sizeof(opts->name##s)); \ split_page = kstrdup(page, GFP_KERNEL); \ + \ + split_page_orig = split_page; \ while ((token = strsep(&split_page, ",")) != NULL) { \ ret = kstrtou32(token, 0, &num); \ if (ret) \ @@ -1619,7 +1622,7 @@ static ssize_t f_uac1_opts_##name##_store(struct config_item *item, \ }; \ \ end: \ - kfree(split_page); \ + kfree(split_page_orig); \ mutex_unlock(&opts->lock); \ return ret; \ } \ -- 2.55.0