From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C2B84503E3 for ; Thu, 6 Aug 2026 14:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786027608; cv=none; b=rACBzFjCtRnNqz2JVby+AXp7uB/SrixxjjKKHN74LpE7Q/DRmKvk/XdDzXCPoY6CrmpJqRfyF+bPWfA03+STxTZdKDHJh6oFQpa5+qoIUDVG/GEnef+MHXJ7ESJ+TTgkp4bvkpqi7Tz2hfc6kZGwJwVFpApcQ8cJSVRBexeyy6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786027608; c=relaxed/simple; bh=YEqhi0ns9dOGIwkKaThAPGwuXkqZjMn1/micDNziDLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zja056x/7jTChj0AO0ZY+0zx8bcQahYzPIM5ANOgGJExLAoyKA6VzYUuMRwsxM+qRpvrzg4KqpjtceyDhEr849qsVJDOICTWTjQhpdRhgfsudRJUpgMzfH+EOmVn2HGUI5PWqPSqE/XAeqfjKIah/WSUKRURjhl8J0VVL4J7gQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=j4qyDf51; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="j4qyDf51" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BAC419F0; Thu, 6 Aug 2026 07:46:41 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.2.212.8]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 7CEE63F9A2; Thu, 6 Aug 2026 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786027605; bh=YEqhi0ns9dOGIwkKaThAPGwuXkqZjMn1/micDNziDLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j4qyDf51HPdHHwZ35q1LnwXeGXMd+tqFMfkZh8KVXk806CqCOX4YXKR1PzJvd+ck+ Af1EUm+0rhxhjXMqXOjclSpKqmpf5FrDpzDI55QTwpTzsC0CCAFJpnrjqrpkPsaqMU ESnfaRRardigZ3zp2H0nxM9EGleAssHJi3ePJLos= From: Ben Horgan To: ben.horgan@arm.com Cc: james.morse@arm.com, reinette.chatre@intel.com, fenghuay@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dave.martin@arm.com, andre.przywara@arm.com, will@kernel.org, catalin.marinas@kernel.org Subject: [PATCH v1 1/2] arm_mpam: Fix a NULL pointer dereference on unbinding after an error interrupt Date: Thu, 6 Aug 2026 15:46:30 +0100 Message-ID: <20260806144631.2502918-2-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260806144631.2502918-1-ben.horgan@arm.com> References: <20260806144631.2502918-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If a user unbinds an MSC after mpam_disable() has been run in response to an error interrupt then a dereference of a NULL pointer occurs as mpam_disable() sets the drvdata to NULL. Add an early return to the driver remove callback to avoid this. Fixes: f04046f2577a ("arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate") Signed-off-by: Ben Horgan --- drivers/resctrl/mpam_devices.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index 2f09f4b78bd3..bc6cc0b5c96b 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -2025,6 +2025,9 @@ static void mpam_msc_drv_remove(struct platform_device *pdev) { struct mpam_msc *msc = platform_get_drvdata(pdev); + if (!msc) + return; + mutex_lock(&mpam_list_lock); mpam_msc_destroy(msc); mutex_unlock(&mpam_list_lock); -- 2.43.0