mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: johannes@sipsolutions.net
Cc: emmanuel.grumbach@intel.com, jtornosm@redhat.com,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	miriam.rachel.korenblit@intel.com
Subject: Re: [PATCH 1/2] wifi: iwlwifi: enable MFP_CAPABLE in FIPS mode
Date: Thu,  6 Aug 2026 18:32:12 +0200	[thread overview]
Message-ID: <20260806163214.63077-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20260630074702.202759-1-jtornosm@redhat.com>

Hi Johannes,

Sorry for the delay.

Regarding the requested information, we can only say that our customers
are US government agencies and US government contractors, and these
entities are required to use FIPS.

From internal discussions, we understand and accept the firmware limitation
with robust action frames (CSA, Block-Ack) not being integrity-protected.
But these users are primarily concerned with the data encryption paths
being FIPS-compliant, which mac80211 software crypto already provided.
And they would accept the known management frame integrity gap as a
documented trade-off to restore WiFi connectivity.

Since no firmware modification might be expected to address this, 
would it be acceptable to introduce an opt-in exception (e.g. a kernel
parameter) that re-enables MFP with a clear warning, so users who
understand the limitation can explicitly choose connectivity over
strict compliance?
The default behavior would remain exactly as you implemented it.

For example, something like this:

   if (!fips_enabled) {
        ieee80211_hw_set(hw, MFP_CAPABLE);
  +} else if (fips_exception & FIPS_EXCEPTION_IWLWIFI_MFP) {
  +     ieee80211_hw_set(hw, MFP_CAPABLE);
  +     IWL_WARN(mvm, "FIPS: MFP enabled with known firmware limitation\n");
   }

If you think this approach could be acceptable, I can prepare a following
patch series with a concrete proposal for your review.

Thanks

Best regards,
José Ignacio


  reply	other threads:[~2026-08-06 16:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29 12:12 [PATCH 0/2] wifi: iwlwifi: Fix WiFi operation " Jose Ignacio Tornos Martinez
2026-06-29 12:12 ` [PATCH 1/2] wifi: iwlwifi: enable MFP_CAPABLE " Jose Ignacio Tornos Martinez
2026-06-29 12:16   ` Johannes Berg
2026-06-29 12:45     ` Jose Ignacio Tornos Martinez
2026-06-29 13:02       ` Johannes Berg
2026-06-30  6:50         ` Jose Ignacio Tornos Martinez
2026-06-30  6:54           ` Johannes Berg
2026-06-30  7:20             ` Jose Ignacio Tornos Martinez
2026-06-30  7:25               ` Johannes Berg
2026-06-30  7:46                 ` Jose Ignacio Tornos Martinez
2026-08-06 16:32                   ` Jose Ignacio Tornos Martinez [this message]
2026-06-29 12:12 ` [PATCH 2/2] wifi: iwlwifi: reduce encryption error message to debug level " Jose Ignacio Tornos Martinez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260806163214.63077-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®