From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E76D64749EF for ; Fri, 7 Aug 2026 16:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786118659; cv=none; b=qGi6CLyTPJVZ4hNAs7mTIoF2l4uv5DIu5li8ljK75dm7bXpIPm1Iot+uq2zpzw3sc37/36LoFn5Wuk3mHx9qnit2TrK/CNzaUuGriJFAcHznec6F7udPL5kumpzdTiQ2j+/f/vPi2Fx2yPV5xrxLZw9NJxXNmEtqnshoS5xeCt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786118659; c=relaxed/simple; bh=RTHMKxogHTIVdAiFZGs5J+GGbqRIMipvqbZrX801VyI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J3Lx5E01NsHTyleyWi6Mh9j6YH2oaE57osrDjH07DB7QLRcZYd6qMvV27zOK56kqYuRqRi9nZg9m7NIml3OnkqWunE+xQFNXBYWQUIkLgPmXfXgRi9sFII/Y7hHjxfsfPtRymhG/umGiFS5dUXKVwiAbEYMJgW473LjpGzmUXaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BPJkqmk5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fg76XiL1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BPJkqmk5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fg76XiL1" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677FRiWL1680007 for ; Fri, 7 Aug 2026 16:04:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 33TYFwncrN46/2iN8rzuq/WUVc3WbHSRn/5XMBLGW3E=; b=BPJkqmk5xiiSKIkk /ckRYGErHWsuHeXCA4oA2j5STN9JCMZAKT/9bg3MaFkVUOOfPJ9KGQoiUgMk62db ntA5MSPm07aWlksqvIF+lYMdBwPF/zvnMhRI0tKYZhwmYUK3ELozV7Q6W58QiN0v Ei0X9Xa89KLjvCjI+VgbBvpj/89LtrWOOQdnjEhyaczjnhI/vQbbDBD5kf61uKiZ VdpE2MvXl5B+Rn33GyKLGVMTnbNCeWtTojLdykGyiTzPW0Ud4Dk2BlG/MsFRMK54 hde9fepDPfqOvkghY1uoyh00YDNSeWQPaZjdRhMPTUYKFOgzKjJLE3tGNPF2c0zT cQsppA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fwgewgk75-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 16:04:16 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e11baa66eso3330626a91.2 for ; Fri, 07 Aug 2026 09:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786118656; x=1786723456; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=33TYFwncrN46/2iN8rzuq/WUVc3WbHSRn/5XMBLGW3E=; b=fg76XiL14PIkmKGjYK1I7wvP3yV4KzsTc1utaSCejTyz1ppZMsZ0pTvc5SJXKHd3ZW ihBMgkb9gtRG6xaJMgBMeIbgf1p6haChLg2VBBkPm/Fhe63b/D2X7IA4UJvTAiYDC1q9 n0wUdiket+MVhs+C1CCoEGQDP1KIx4M0P1wJWBkNr61/uXWfGjBF2DnKg314CrbW9SdM H4ivsHWai9H2HTVyfAHD/QoVG04r4357++A0Gwk3NTM46urRVglB/Loj0MC8H+L/znap ySnKzC7L/8xFtImtD+sBx+bMQwU1SwsZhATry7LsM3wf2yuMDa/hySLF/2PiMeOlOdCo ShXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786118656; x=1786723456; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=33TYFwncrN46/2iN8rzuq/WUVc3WbHSRn/5XMBLGW3E=; b=sBvJ9rPphkLvRD2Vjp8dlbSTQFqut0quuVMq653d5fOt9X1g5yGv8jQ6kMz4TK70DO ga3GcmEkFMp/+s2LrzySBBltYCSlf78TxcGOUO5cwlKGMq/grcHec5IoFI9RcaaKIW+9 7zn/OIWgDETzeE8xy76v8oEK6to7erc76hyWfstZ7E4Lhgk8x+nZqWI3BWlH0gy0ES3a uNsMA+fzmZGbXe48rjhs8X7Ie3Y1bXU/Qkq9RgqNGif1ztTzgxo9ruJgyzc+GXm0rEt3 iHxySljKJ0JVnf9Q1mParmPxMTJVf1YJGZns8r12c4IFiBaesTnMTlWT6ChIJ2SA/8vz 2kXg== X-Forwarded-Encrypted: i=1; AHgh+RqJor01VHENeVjnbECVxh/arkQR4JKzdRocgmE3oqK0EQn8KNUT3GYoFK74wB1eRrqtGe1BJHYezyhyV0A=@vger.kernel.org X-Gm-Message-State: AOJu0YzLMNkk/eP13+9Y6rbWhjh7OFvP6nx/cJRXfyX1BIhpPg38ET6J LwIxgHT+CKv2GmcyitgoB4sGiU4YWq6cqJyhdGW7VO63JizPJb44GNbU8WXm6fLFBNiFnAHGscN HWuVzJLo4icQc5EZW1LBwf88iXr3zaXQ9YrwzsK590/E6KrJJvvVanJOhibSy2oO0Thmeu5Ne/W M= X-Gm-Gg: AR+sD13Qf9fGY1DAXMFMlFvJoZLav/ierj71v65drb1NtiO1DXP+WbHEzVl20sioyP4 rgLRBOwdnqz6Hyz8YLVweVzZiDuLP7EEFanxCgcll4zkc2G+8bfwrD5w80Sd7w76evmkuDVKrR6 Nke/Mk/GXzTa4l3imNWRUc31wxjX87TKdAJmkHhmkmNeXIidZncYo1dqI9creaGf+cFal0v+Ib3 hdomFGfNFfmBalhk+LMl8LB2WYkXkZfU5gDa6WmuGue+oAggYap0VWmfbwJt5mc1ldGWpVD0bY5 tZIQRw/hkNFtXOBhOmNPmwBvIb+8/Hmb5bifZEHcTlRPWMrBji9+BMZkFd11/9qhLIEm4lc9g2L 7yd2KuNKfnrMIcvpb1xYaSY37jah3Avh2linZt0vKzzRDeut3QB/2Kn7CE/x3X0Ht5duCEP0GA5 Fm4RrkceaJrqU= X-Received: by 2002:a17:90b:2dc5:b0:38e:ad9d:1151 with SMTP id 98e67ed59e1d1-3909d79f314mr12715379a91.4.1786118655711; Fri, 07 Aug 2026 09:04:15 -0700 (PDT) X-Received: by 2002:a17:90b:2dc5:b0:38e:ad9d:1151 with SMTP id 98e67ed59e1d1-3909d79f314mr12715044a91.4.1786118653692; Fri, 07 Aug 2026 09:04:13 -0700 (PDT) Received: from hu-mdalam-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1410199bfd8sm8337541c88.2.2026.08.07.09.04.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:04:13 -0700 (PDT) From: Md Sadre Alam Date: Fri, 07 Aug 2026 21:33:55 +0530 Subject: [PATCH v2 1/3] spi: spi-qpic-snand: move command mapping helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260807-quad-v2-1-8ec821e2f22b@oss.qualcomm.com> References: <20260807-quad-v2-0-8ec821e2f22b@oss.qualcomm.com> In-Reply-To: <20260807-quad-v2-0-8ec821e2f22b@oss.qualcomm.com> To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Md Sadre Alam , Md Sadre Alam X-Mailer: b4 0.14.3 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDEyNSBTYWx0ZWRfX8HwpjFD/jx5G 2yivKwH42WLlQH2ZqGmzY5oQeClrCuVOIhJYZSaCVYvIXUY8r6fYYDZ3yMa5q9fromTv+29Bi9t EWgQ0jSRTxuwf8H61p8kzVwMJS2UhsA= X-Authority-Analysis: v=2.4 cv=N5cZ0W9B c=1 sm=1 tr=0 ts=6a760200 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=a1To8mgfp0J-3_lObMEA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: RKyWxu4WF67ylbvUGMbmpdmp4HcYK9-O X-Proofpoint-ORIG-GUID: RKyWxu4WF67ylbvUGMbmpdmp4HcYK9-O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDEyNSBTYWx0ZWRfX+q7sxGgSusCj WMrnYrRcZJR9puoEMTYviD6U8UFaT0c7g2hmQDTDmYxcEqDE01+8h9fXMWnncqtRdac4YzBLAxE 1+L0cPpBZb1VpWKv8C0llfFDi13cjNrVX+HxW00nVZw49BE2UFo7lRksrKxlosIp6zhyojwKKV4 c5HjU/e6lpymSF5vQcSVaPhBp9cURlut3fns6YD9Ez49RhiUB9589muP4Nn+lU+zvkGXfC25PRf ox6BfYd1ZODR1jmbKGUYtDVslRjWAllt26kre7Tuw2cxy9SZKKSk6iS+1ng4hNLqpqdfn+xLyg6 YAw6R/7CUvJ5XJefPUqqVzROyJ2KP8+QPKtXsTd9bYgoUeBBLa53tjc/VIPmARFXcQlplmXk7T9 ehM0m6+O+5dP4060XegAmAEDNOrzA33v0WmY7qQB+LdfabAs3OukorEBoUUgGI9wUxYfQcRp8Na W+oQfvjeCsqYo7KUNcQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_02,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070125 Move qcom_spi_cmd_mapping() above qcom_spi_read_page() so it can be used by read path changes added in a subsequent patch. No functional change. Signed-off-by: Md Sadre Alam --- drivers/spi/spi-qpic-snand.c | 96 ++++++++++++++++++++++---------------------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index 1e2fc875cd66..db105b3fd601 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -1004,6 +1004,54 @@ static int qcom_spi_read_page_oob(struct qcom_nand_controller *snandc, return qcom_spi_check_error(snandc); } +static int qcom_spi_cmd_mapping(struct qcom_nand_controller *snandc, u32 opcode, u32 *cmd) +{ + switch (opcode) { + case SPINAND_RESET: + *cmd = (SPI_WP | SPI_HOLD | SPI_TRANSFER_MODE_x1 | OP_RESET_DEVICE); + break; + case SPINAND_READID: + *cmd = (SPI_WP | SPI_HOLD | SPI_TRANSFER_MODE_x1 | OP_FETCH_ID); + break; + case SPINAND_GET_FEATURE: + *cmd = (SPI_TRANSFER_MODE_x1 | SPI_WP | SPI_HOLD | ACC_FEATURE); + break; + case SPINAND_SET_FEATURE: + *cmd = (SPI_TRANSFER_MODE_x1 | SPI_WP | SPI_HOLD | ACC_FEATURE | + QPIC_SET_FEATURE); + break; + case SPINAND_READ: + if (snandc->qspi->raw_rw) { + *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | + SPI_WP | SPI_HOLD | OP_PAGE_READ); + } else { + *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | + SPI_WP | SPI_HOLD | OP_PAGE_READ_WITH_ECC); + } + + break; + case SPINAND_ERASE: + *cmd = OP_BLOCK_ERASE | PAGE_ACC | LAST_PAGE | SPI_WP | + SPI_HOLD | SPI_TRANSFER_MODE_x1; + break; + case SPINAND_WRITE_EN: + *cmd = SPINAND_WRITE_EN; + break; + case SPINAND_PROGRAM_EXECUTE: + *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | + SPI_WP | SPI_HOLD | OP_PROGRAM_PAGE); + break; + case SPINAND_PROGRAM_LOAD: + *cmd = SPINAND_PROGRAM_LOAD; + break; + default: + dev_err(snandc->dev, "Opcode not supported: %u\n", opcode); + return -EOPNOTSUPP; + } + + return 0; +} + static int qcom_spi_read_page(struct qcom_nand_controller *snandc, const struct spi_mem_op *op) { @@ -1268,54 +1316,6 @@ static int qcom_spi_program_execute(struct qcom_nand_controller *snandc, return 0; } -static int qcom_spi_cmd_mapping(struct qcom_nand_controller *snandc, u32 opcode, u32 *cmd) -{ - switch (opcode) { - case SPINAND_RESET: - *cmd = (SPI_WP | SPI_HOLD | SPI_TRANSFER_MODE_x1 | OP_RESET_DEVICE); - break; - case SPINAND_READID: - *cmd = (SPI_WP | SPI_HOLD | SPI_TRANSFER_MODE_x1 | OP_FETCH_ID); - break; - case SPINAND_GET_FEATURE: - *cmd = (SPI_TRANSFER_MODE_x1 | SPI_WP | SPI_HOLD | ACC_FEATURE); - break; - case SPINAND_SET_FEATURE: - *cmd = (SPI_TRANSFER_MODE_x1 | SPI_WP | SPI_HOLD | ACC_FEATURE | - QPIC_SET_FEATURE); - break; - case SPINAND_READ: - if (snandc->qspi->raw_rw) { - *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | - SPI_WP | SPI_HOLD | OP_PAGE_READ); - } else { - *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | - SPI_WP | SPI_HOLD | OP_PAGE_READ_WITH_ECC); - } - - break; - case SPINAND_ERASE: - *cmd = OP_BLOCK_ERASE | PAGE_ACC | LAST_PAGE | SPI_WP | - SPI_HOLD | SPI_TRANSFER_MODE_x1; - break; - case SPINAND_WRITE_EN: - *cmd = SPINAND_WRITE_EN; - break; - case SPINAND_PROGRAM_EXECUTE: - *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | - SPI_WP | SPI_HOLD | OP_PROGRAM_PAGE); - break; - case SPINAND_PROGRAM_LOAD: - *cmd = SPINAND_PROGRAM_LOAD; - break; - default: - dev_err(snandc->dev, "Opcode not supported: %u\n", opcode); - return -EOPNOTSUPP; - } - - return 0; -} - static int qcom_spi_write_page(struct qcom_nand_controller *snandc, const struct spi_mem_op *op) { -- 2.34.1