From: "André Almeida" <andrealmeid@igalia.com>
To: Thomas Gleixner <tglx@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Arnd Bergmanon <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
kernel-dev@igalia.com, "André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH RFC v3 1/8] syscalls: Make --abis parsing more robust
Date: Fri, 07 Aug 2026 16:34:28 -0300 [thread overview]
Message-ID: <20260807-tonyk-syscall_table-v3-1-7c45a23c50b5@igalia.com> (raw)
In-Reply-To: <20260807-tonyk-syscall_table-v3-0-7c45a23c50b5@igalia.com>
Some archs Makefile have the something like this as the rule for making the
syscall files:
cmd_systbl = $(CONFIG_SHELL) $(systbl) --abis common,$* $< $@
The $* symbol is evaluated to the variable found at $(uapi)/unistd-%.h,
where % is 32 or 64, resulting in e.g. `--abis common,32`. Sometimes the
rule for the file won't have a %, resulting in a trailing comma e.g.
`--abis common,`.
Currently this input is transformed into (common|). This is problematic
because grep will then match any ABI because of the trailing `|`. Make the
syscalls scripts more robust by removing any trailing comma.
Signed-off-by: André Almeida <andrealmeid@igalia.com>
---
scripts/syscallhdr.sh | 2 +-
scripts/syscalltbl.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/syscallhdr.sh b/scripts/syscallhdr.sh
index 22e34cd46b9b..bad1ab606a0f 100755
--- a/scripts/syscallhdr.sh
+++ b/scripts/syscallhdr.sh
@@ -39,7 +39,7 @@ while [ $# -gt 0 ]
do
case $1 in
--abis)
- abis=$(echo "($2)" | tr ',' '|')
+ abis="($(echo "${2%,}" | tr ',' '|'))"
shift 2;;
--emit-nr)
emit_nr=1
diff --git a/scripts/syscalltbl.sh b/scripts/syscalltbl.sh
index 6a903b87a7c2..c4b1f85c2dd6 100755
--- a/scripts/syscalltbl.sh
+++ b/scripts/syscalltbl.sh
@@ -33,7 +33,7 @@ while [ $# -gt 0 ]
do
case $1 in
--abis)
- abis=$(echo "($2)" | tr ',' '|')
+ abis="($(echo "${2%,}" | tr ',' '|'))"
shift 2;;
-*)
echo "$1: unknown option" >&2
--
2.55.0
next prev parent reply other threads:[~2026-08-07 20:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 19:34 [PATCH RFC v3 0/8] syscalls: Add a shared table for all archs André Almeida
2026-08-07 19:34 ` André Almeida [this message]
2026-08-07 19:34 ` [PATCH RFC v3 2/8] syscalls: Create unified partial " André Almeida
2026-08-07 20:40 ` Arnd Bergmann
2026-08-10 13:19 ` André Almeida
2026-08-10 14:22 ` Arnd Bergmann
2026-08-07 19:34 ` [PATCH RFC v3 3/8] scripts/syscall.tbl: Use the common table André Almeida
2026-08-07 19:34 ` [PATCH RFC v3 4/8] arm: Use the common syscall table André Almeida
2026-08-07 19:34 ` [PATCH RFC v3 5/8] s390: " André Almeida
2026-08-07 19:34 ` [PATCH RFC v3 6/8] sparc: " André Almeida
2026-08-07 19:34 ` [PATCH RFC v3 7/8] mips: Remove duplicated syscallnr.sh André Almeida
2026-08-07 19:34 ` [PATCH RFC v3 8/8] mips: Use the common syscall table André Almeida
2026-08-07 21:02 ` Arnd Bergmann
2026-08-10 13:20 ` André Almeida
2026-08-07 20:43 ` [PATCH RFC v3 0/8] syscalls: Add a shared table for all archs Arnd Bergmann
2026-08-10 13:25 ` André Almeida
2026-08-10 14:18 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807-tonyk-syscall_table-v3-1-7c45a23c50b5@igalia.com \
--to=andrealmeid@igalia.com \
--cc=arnd@arndb.de \
--cc=kernel-dev@igalia.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®