From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0578F383980 for ; Fri, 7 Aug 2026 03:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073142; cv=none; b=jwpFDsZcHmAHJeDzJff2ocSFPra7V6y6dDDNGJqrs+oJf4u3sVemurequ60ryZTOaRBSNMOQDKg3hvkvYfV+16pHJQ2xkkxural6vZjIaL6g/JK604qjjYiPehop1HEKr9ef4SHHoYiZcz2nErNyN4zJ6OoGiBReVLlFkA1506Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073142; c=relaxed/simple; bh=5DWHTyV/pH+3MdDwtmbB7rkHS/t6yPLT6Xj+jVdd9cU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qpJhGW9jf6FunCaLZoWfijMYUZl5seIOGohprXG1UYIjeLwDZWHIq4GB/G53GCIu/17LbjmkKvs8L9Dd9iWwgWStC2j5qa9ykSSTw/WuFZngLHWCSTt1sS+AzMRaMsAZWJsffknLdxdnHuW0kFiA7htdRSiZg3FU5Z6c9VCjm70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XmlVLwZn; arc=none smtp.client-ip=209.85.210.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XmlVLwZn" Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-7edd6e6a327so368494a34.0 for ; Thu, 06 Aug 2026 20:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786073140; x=1786677940; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1+6XE7Yc3wed4LEk38MwpLFA21L8FO91QUtlY5oe2OY=; b=XmlVLwZnH3GVLX7Qa71gCGaXQGrasc2svQM5rm07SFiO7TmbuoaA+FSl992Lx8DYuE DQdY6JGm66x0MkxNJ7iJoJyM+njYCuGaEYcXuzejPhh+nhXwWb+oX+pQ1IuEN+gzua61 EATV4NHjC4tSc4kr1YPveYGRO1xus6kfWKbeZYkIV9s2CvSa08zP8XuI1Au557P7okS6 4w+88GRSLztxXrQYupvLu2YabXUgVW70OZyl22bcsTGc1mtBVhiBFKlAwZ4L7/H2wHw9 XVBoBCgx1kKrWdn/5IdusxCSFFy1Jj1qYJPFuA/FhVhfpxp4aW/keQDoew8u24mXEF9A tZ0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786073140; x=1786677940; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1+6XE7Yc3wed4LEk38MwpLFA21L8FO91QUtlY5oe2OY=; b=p4dIodgkyi8vm/wGVNz36+24yMxtQ4h2Tiskc3BF9sQ/bSxqXCoAwJJ29F4Y17Q6cD SV0KLVx7naPlhfyP9QKwFfb68vcEvw7ZTq+1ThIU3rqqkcAV/60tXhl4bvpMELgeORpH dYN1BfRzFT64FHjvjwvmypt7IeyAOOukKGgwcVW+R86a3IiOGBPwc8A3ia+I21iGRbaj KVRbyUUDBlrW3OiYiS8Y3llxFhERvu0tloaxqALKdwpu85LU0YE29pBBHfMO4OnK64bI +Qfrk7ap5oTYu0TMzyOpQQKUd7BFUDMgk5sSyYmZEa34w6KU1C6w3xhFU2Y3IuMajQsg YXVQ== X-Forwarded-Encrypted: i=1; AHgh+RrTe3vdX0WRB0t3RFL61046nMD0e2tD4ygy2SOOba1FW0U2r4Dy3rrAj+J3fQ51uCwGgkAOPH4x/titJx0=@vger.kernel.org X-Gm-Message-State: AOJu0YzvuOyZNp6U+yLMl7G/7/xuWzzHn204ZeLsKZEW1LuO+0a6+Jid u1uCUmvMLZA1mwBnQodZUf1xFaTRda+s+CNBQ8gQtDexRoELHUwmoI5p X-Gm-Gg: AR+sD12hH/GUVRuXDI38XqrIJJMaLQeUr12a8vuUzmeDqCEuecxqiQJEp326VY6p8UN rb3x+dMdFENiJQI9YNAWQUE4iF8BAsctJHg+shdqU6UWAD6YDomzxGYB74U+l57N9mYD5BV2+1U g0rB2UehbmwNwuhE/OS2bh3Rt05NnTq4NUU6VhJzTcY5oKuI33UtPuzX2FYNqP3bkQfe6x8huQa IOH6eePt1Qe9RO3hWo/EOBIC6CVSWTtVzx72Sc0jUdcHS2YcFUxLCbzBoD1phxliaFGFlhNxH0Z nAKeUnfEaVCOdi03c2YpL6/9nIlaRFnWw6cndb8Z5cwRSoh4DnRoMtv++NUlNXKlYdxGOfBOMIJ 5eaRy+eFfVfHNX3ybMSzIBDB/tzIo7xsWDdNpe+Em7RqobYant1vN409wxv1FCStJXe5wjrN/n6 fdJVF2wv5XPFh+31mL7/c/F6GrEDiKnqQA3WBASQiw2we8HYa/80hYuPyf5zZ9+OvCOogQ5l9wn vq777/pTdO45MbfAETMUxiNjaZAca+f/5Q6dmS8Ay8wOxt3PjpzVTUUUI7UH0oT4JTYsHif1w== X-Received: by 2002:a05:6830:8d1:b0:7dc:d6b1:48b7 with SMTP id 46e09a7af769-7f1e5c6e96amr7295657a34.1.1786073139763; Thu, 06 Aug 2026 20:25:39 -0700 (PDT) Received: from antares ([149.88.25.215]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f35b563b04sm405786a34.6.2026.08.06.20.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 20:25:39 -0700 (PDT) From: Bogdan Nicolae To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v5] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Thu, 6 Aug 2026 22:22:09 -0500 Message-ID: <20260807032209.447044-1-bogdan.nicolae@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero out auth_status on initialization. Otherwise, garbage will leak from the stack to the firmware (when ssid is less than 32 bytes and/or when params->pmkid is set). Then, pass the params->pmkid to the firmware (without it, the firmware caches a garbage PMKID on successful authentication and denies a subsequent association request that includes the PMKID). Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") Signed-off-by: Bogdan Nicolae Acked-by: Arend van Spriel --- v5: Fixed line length > 80 chars v4: Fixed indentation v3: Added Fixes, Cc: stable, and Acked-by tags v2: Split into a separate patch drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index 873754be5..2c59b5e57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, { struct brcmf_if *ifp; struct brcmf_pub *drvr; - struct brcmf_auth_req_status_le auth_status; + struct brcmf_auth_req_status_le auth_status = {}; int ret = 0; brcmf_dbg(TRACE, "Enter\n"); @@ -208,6 +208,8 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, ifp = netdev_priv(dev); drvr = ifp->drvr; if (params->status == WLAN_STATUS_SUCCESS) { + if (params->pmkid) + memcpy(auth_status.pmkid, params->pmkid, + WLAN_PMKID_LEN); auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); } else { bphy_err(drvr, "External authentication failed: status=%d\n", -- 2.55.0