From: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
To: andriy.shevchenko@intel.com, jic23@kernel.org,
dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com
Cc: gregkh@linuxfoundation.org, joshua.crofts1@gmail.com,
skhan@linuxfoundation.org, me@brighamcampbell.com,
jkoolstra@xs4all.nl, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
Subject: [PATCH v3] staging: iio: frequency: ad9832/ad9834: add comment explaining do_div usage
Date: Fri, 7 Aug 2026 11:33:48 +0530 [thread overview]
Message-ID: <20260807060348.6477-1-raizudeen.kerneldev@gmail.com> (raw)
Previous attempts to change do_div() to div64_ul were rejected because
mclk will always fit within 32 fits for this hardware, making do_div()
safe to use.
However, Coccinelle continues to flag this as a false positive. To
prevent future developers from submitting unnecessary fixes, add a
comment explaining why do_div() is intentionally kept.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@gmail.com>
---
drivers/staging/iio/frequency/ad9832.c | 6 ++++++
drivers/staging/iio/frequency/ad9834.c | 6 ++++++
2 files changed, 12 insertions(+)
diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
index 60c33e10c46f..2e216c950c53 100644
--- a/drivers/staging/iio/frequency/ad9832.c
+++ b/drivers/staging/iio/frequency/ad9832.c
@@ -118,6 +118,12 @@ static unsigned long ad9832_calc_freqreg(unsigned long mclk, unsigned long fout)
{
u64 freqreg = (u64)fout << AD9832_FREQ_BITS;
+ /*
+ * mclk is an unsigned long, which triggers a Coccinelle false positive
+ * warning about using do_div() for 64-by-32 division. However, mclk
+ * for this hardware will always fit within 32 bits, so do_div() is
+ * safe to use here.
+ */
do_div(freqreg, mclk);
return freqreg;
}
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c
index 33dfd723923c..85f39ceb3c4c 100644
--- a/drivers/staging/iio/frequency/ad9834.c
+++ b/drivers/staging/iio/frequency/ad9834.c
@@ -103,6 +103,12 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout)
{
unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS);
+ /*
+ * mclk is an unsigned long, which triggers a Coccinelle false positive
+ * warning about using a do_div() for 64-by-32 division. However, mclk
+ * for this hardware will always fir within 32 bits, so do_div() is
+ * safe to use here
+ */
do_div(freqreg, mclk);
return freqreg;
}
--
2.53.0
next reply other threads:[~2026-08-07 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 6:03 Mohamad Raizudeen [this message]
2026-08-07 7:36 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807060348.6477-1-raizudeen.kerneldev@gmail.com \
--to=raizudeen.kerneldev@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jkoolstra@xs4all.nl \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=me@brighamcampbell.com \
--cc=nuno.sa@analog.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®