From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01ECF3A9DA9 for ; Fri, 7 Aug 2026 07:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786086969; cv=none; b=Zf1SCyOa8LdaHwhwRYVccfc7M9WNNqhQM+2MaOsB7nhQW+mbY2/m6gPpJC9lcq2yGtzLCUVgtmkIcYtUDJ1ysjkGcqy3Zo0Wu21OiKPuUEj1561GF4jTGT7+96qv9ut3g6qaKb2IO3br+K4vxjOIAeY4ZFa7mVgUD69upkQgxr4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786086969; c=relaxed/simple; bh=kQqz3hsk1y2iV4xeE5C9ALU/9J5Bfxq8H+CjBpgjeog=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QyWZJchfixAxso3JI7fgM04G94H5GZ7YiHd+JeQjdUu9/jC8BLaUgKQQ7IKPlZrYXsRbwuj/bQcgz2IK9ExjTjR1UjOB3LIGTl0dumAysfUCOWq00t+B7bAGrtrPaOUwFGe8EnZJiCsc1UxWRaT1LDx80SaW6UAxfk1XAb60jww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZvENPAmM; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZvENPAmM" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso3818807a91.1 for ; Fri, 07 Aug 2026 00:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786086967; x=1786691767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8GKuiDEG88B3UVF8xtTuPaQDFcoPyLRCeG2JmgopU+E=; b=ZvENPAmMoEBTEvHNPrP5S/w9SYTjJ1dt0H9bW1Ju3vgzttvuF3qVxqtOQZ6WQwIdnS yC+2e7dSJbdujqChGnTVHgtqBukLNMty8dYynzwrZt0w7g+TGAENZec5bj8BTFliyASl VIfqQvGT9p+m+5Gb1ppp/NHItZ6SNIozJN0v7ZRWxHx912hOXm1cTJagQ2w3BGG6Icst TTsIuMqJDTt2/ZVkiiFVPm1AJ6vpM6FeHS9mAEC0HTPYvFJyAqmri0Agoq6FxjPNejU+ gTWOgFA2yIQppx3zNsQkZY1H/QbZO6ozajJnucpCPmEyhBaYveq/Kx1Tkj8bVDstxP5F XaFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786086967; x=1786691767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=8GKuiDEG88B3UVF8xtTuPaQDFcoPyLRCeG2JmgopU+E=; b=WR5Qr9BYOBovNBnX34E8+QB+4fYfq7iX+rEy78MRNiN9O5Fl9AwOR0aP9aw/r+YyPR pIHju22wVWE+Xxz8RdJgRcVcJFSrALdMXGxkZPU8kd82V7SybvFrsrGHQICK3Mu5tguj Clot+rfJaS6rxor+/nY5VdU3EIXRlUwba4RLwHx7zjm5VLIM7eF33haukzZJ35iXyfAj NBya5RL3kzSHGJv5oYyu5BkcVWSEhSm2uaEpc5XjOt0+pWeX/wFC8q6W9k6XuFni+6+T z161846BOgsrEp2rQxeUicMD3BOIgKGIrcMr0Kzsl8kOnV36xmM2FwZOU4ObkZ+Ejm4t AZCg== X-Forwarded-Encrypted: i=1; AHgh+RpaNbWov16Ylu1r9KhuwzNSMvk3wJyMTJa8ibKqMQ3WjbIW2kSeEqbkWXKqBjUgWWKjW9dP9PSFbv+SZvM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1XIcV4CWzwNkUMsLAXh35EqVxeY7HhVjRERBpEqFCtZnS1FJ5 sA25LgnCzXr0i4Hlcxyp2yrqJX5f0a1/fivBei5qNkpnznkgQAfEVq3O X-Gm-Gg: AR+sD13w39hE7fA+jRq7xCT7+yS9NUOV50E8IpttQ8LOVKQqLpu9YpUFnDzukIidibV b1LnJsf1wi1hb8QwfCUJznWrUTQsF1zjzYfafyozjYputnrohkWxjjMIK8+fsh6HpVvTrRUpnDR FT6f9mUui2QUYL2NTSqT19Tgsa1/wXVnYTz8y9AyRABgFhSc4RdsJrhV9edERcZQpihjNLwJ5uB Wr2Hr6o+JgRuRjoMJ7xCsjOqy510zxD3mlxk7CwcsZnjeshv5gonL95rPijMkw4yKTdE6b/uVBV wfdWBDnYp0JpVQIfQkpOdvAWDBvCFx8qJWzW8PagcmtIbnzpP1BOFUS+nWNsZNF9xgi+N3odzwl t153VFPB34U/pEWTiqSZ6MhdEaTpHrx/HFQqWzoBcQqSSfKIqS39STHqEoDz9S+qaViaKh6ob0t Ug3WRwSKmeQRJfgKs+DxCOdFwVChuU3ArC/oNYzpEccsL0UMjdGg0tqD6IEw== X-Received: by 2002:a17:90b:1f8e:b0:38d:f096:a1dc with SMTP id 98e67ed59e1d1-392620e71c6mr2232422a91.11.1786086967193; Fri, 07 Aug 2026 00:16:07 -0700 (PDT) Received: from dio ([103.161.231.220]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-14101b7b39bsm4347753c88.14.2026.08.07.00.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 00:16:06 -0700 (PDT) From: singh.supreet14@gmail.com To: Viresh Kumar Cc: Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Supreet Singh Subject: [PATCH v3] staging: greybus: spilib: Handle SPI device types with a switch statement Date: Fri, 7 Aug 2026 12:45:42 +0530 Message-ID: <20260807071542.200192-1-singh.supreet14@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260806101118.146685-1-singh.supreet14@gmail.com> References: <20260806101118.146685-1-singh.supreet14@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Supreet Singh Replace the if/else chain that selects the SPI device type with a switch statement. This makes the code easier to extend when additional device types are introduced and improves readability. Signed-off-by: Supreet Singh --- Changes in v3: - Fixed the memcpy indentation issue - Removed the extra blank line in the commit message drivers/staging/greybus/spilib.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c index e4d1ae8308aa..39d5bf234c61 100644 --- a/drivers/staging/greybus/spilib.c +++ b/drivers/staging/greybus/spilib.c @@ -458,17 +458,22 @@ static int gb_spi_setup_device(struct gb_spilib *spi, u8 cs) dev_type = response.device_type; - if (dev_type == GB_SPI_SPI_DEV) + switch (dev_type) { + case GB_SPI_SPI_DEV: strscpy(spi_board.modalias, "spidev", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_NOR) + break; + case GB_SPI_SPI_NOR: strscpy(spi_board.modalias, "spi-nor", sizeof(spi_board.modalias)); - else if (dev_type == GB_SPI_SPI_MODALIAS) + break; + case GB_SPI_SPI_MODALIAS: memcpy(spi_board.modalias, response.name, sizeof(spi_board.modalias)); - else + break; + default: return -EINVAL; + } spi_board.mode = le16_to_cpu(response.mode); spi_board.bus_num = ctlr->bus_num; -- 2.55.0