From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07564391832 for ; Fri, 7 Aug 2026 07:36:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786088201; cv=none; b=H+yh8eCgFuSNkC8oFqzpQ+PQjg3Ha1D18J41P96BZZaub8qNx7U/XrQW5dBEeG3M7eqSHvqTt1/XDWp0mlknQLQzS7wKQKziPDuWPuuSNQ+aQIvGYPHYAr+mnt/W8mrQ66pjB0bVJ1hszZcOWTEbioY87abICFxXE2Lv56iXypA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786088201; c=relaxed/simple; bh=wQAVvH1tNXlAzIGB7zvqrPD5lgABH9gvcOKmiSO8R/o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ou4+R2j0NpMiyykydh9qL6tOyNVW4hcJ2sW6Eb2ap4HMn2PqDmPmMNYPxkSSd19285uCc/0jGsOQ+1Vh1/qEBeVweLenf4QgoUNsTvATnpZ+sVjsWi8u2zL2ZNyD/+KEZS1QiaHA8wnrErySyQfJm91ZK9WKY+SBM0NxRxGEjjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ccRn9nIz; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ccRn9nIz" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49555a0e68bso14812005e9.2 for ; Fri, 07 Aug 2026 00:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786088198; x=1786692998; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=z/WXJlREgBQORjV26H3RvXyQimV7YRpmumUNnx9xtAU=; b=ccRn9nIzx7L9Vka7iA+tdMHJbYrCwPzXJVWb+B7rSbCXRv88t9sU5uKBhrBS9lIepd o2s7AuTZURm+YzcfMvROXpcLZzsxBG1KBq+WaOgPFuKItIS7/5yjAfE/xD6TjOcIl0pq J2OfKuvHH5jhl82EqjCfaUm7YZ2JdYfmHjEO+GiebA1HMrE2ETZGFME+kuxZjIzLqZxA yDb85tfXfBC+LegcTY1K9+cC3EAIBWygx/DkImskR5x3M0KOHtkRUwJcUPkCpEcorENi NwCRl5Vn1kodIVRTDe6Sdw+Oy757ss5bzEseePT3wm8wmL4YLAvqNqLbNe5f/HjwiI5r G3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786088198; x=1786692998; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z/WXJlREgBQORjV26H3RvXyQimV7YRpmumUNnx9xtAU=; b=b4QVDELvFAhYi2mU3xTQJRoUlK2BK3gSPC2n7uX1tqYZhxoOecSZ60woi43SF4UlZx XqALAoifsW6pQCuKJ37a0yLdslp9qwlJvSFOvYsOvfKysiAzHTB4BfTRuzB8nZDiJZhY 8xY9Ov0ZUP2q7/qVUEmXVu11b44lUAa24cepyxL0VmdryIIYxcRh6oq+NvBIYktdhb28 GiX3ejlPZFO8Zms8eyRl0JBgS/NtoMPS54iapWa9Yk28VQ4tH1i1H3gDSjrgdVZ6vnR6 FpMmdY77L4lLpFfVhKMx7dmRMIRA2G2EwmNEQi7ccACEk3E/RbBZvWZzVrxShzEjp6A/ UrmA== X-Forwarded-Encrypted: i=1; AHgh+RruyNxNpp+XGkSsZS6F+f4ULsKH0TovQ+LuiGcSVYVDmN/U5bmG+Jv2Ah45oJLjoafhD3MckpEgx6QK5j4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7bT054p+kUhnSsZQg2BgRgAOdMpDSZpWxoMZIu8mFqoc5CvQA YNP14HRks8RkgnjE+z/kU8o9MGrrdhaCAONwpxnOjnjnbAfhgsT5n0rk X-Gm-Gg: AR+sD107xLG7iJJQdpPF/cUA+0iJ1llBbuZQgn2rb6ncHZTs3nI5xVInhsdOT4NpK0Z 6vTYgW8On9p1GdMoRLBtUu+/zJset/pf9F9oVVTuBVjVwBfxxs7EFHElmBksej0khS4rv10j+ln SgeW4al2TTv8YIMA9dqI0o16rk4Dfj6J96qx8SP/tDvDoJagehsK0fuXffLY2/tOzzhhMcbyehR 0N4HXKZKLZVZ1cKOBwulXSQCBW7sGSBaO1uUu6/pE5IN3ydU/2Xh+1Mh2Ez39Ga0o0d93dDbAY9 0lmKwyeqaxc6F9chStOZhfoY14eP9oCzD9J7QckaqjWWYg3eraDyDI9FZ91UOqmmoUD6NyrddMH OHXUjEti/lLeTDQVwlVNXqODk6JkInmc+vlz8pAzvUFdT0R+Z1+iJUAat19RpLkSL6+YFio04H2 7sl6sBwmUjhqamJkIMT9kgQMDqBE7ik74+6MS3pvae4sInazXEq6j7e/LveTB73ogxF/UP0/yn1 x18/dNqVyB48rVsKmmDe3DCf1CtFeibIVF3bXI42uvF2EVRY+Byr5qZV9csv8MYBXqjlgBBOBT3 vIBmne1vQXaDMPVbH3w91uOjoKhAhqf/iSeqGabXhVpvj1kgN7YuNUQvv5/Ymg0HvKsZkeGuoVW NzvmLTmQILLeVdpeAk71y5pM6Hex5kEn4md2SkvB1PETqEFI4u9bhF2OQHTLEYu/FpKioYmc= X-Received: by 2002:a05:600c:c8c:b0:496:c18c:f9a3 with SMTP id 5b1f17b1804b1-4994e79dc76mr250053215e9.5.1786088198056; Fri, 07 Aug 2026 00:36:38 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995e9f0230sm13148745e9.6.2026.08.07.00.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 00:36:37 -0700 (PDT) Date: Fri, 7 Aug 2026 09:36:37 +0200 From: Joshua Crofts To: Mohamad Raizudeen Cc: andriy.shevchenko@intel.com, jic23@kernel.org, dlechner@baylibre.com, andy@kernel.org, nuno.sa@analog.com, gregkh@linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com, jkoolstra@xs4all.nl, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: iio: frequency: ad9832/ad9834: add comment explaining do_div usage Message-ID: <20260807093637.00002bfa@gmail.com> In-Reply-To: <20260807060348.6477-1-raizudeen.kerneldev@gmail.com> References: <20260807060348.6477-1-raizudeen.kerneldev@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 7 Aug 2026 11:33:48 +0530 Mohamad Raizudeen wrote: > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c > index 33dfd723923c..85f39ceb3c4c 100644 > --- a/drivers/staging/iio/frequency/ad9834.c > +++ b/drivers/staging/iio/frequency/ad9834.c > @@ -103,6 +103,12 @@ static unsigned int ad9834_calc_freqreg(unsigned long mclk, unsigned long fout) > { > unsigned long long freqreg = (u64)fout * (u64)BIT(AD9834_FREQ_BITS); > > + /* > + * mclk is an unsigned long, which triggers a Coccinelle false positive > + * warning about using a do_div() for 64-by-32 division. However, mclk > + * for this hardware will always fir within 32 bits, so do_div() is You have a typo here, fir -> fit. -- Kind regards, Joshua Crofts