From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC5A42AF81 for ; Fri, 7 Aug 2026 11:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101083; cv=none; b=uN+RdBXLhcaVNkIfTBsYmKiMLQ0zJVVxB8YW70tugMn9+s1mlF+aUZTTPyMcg+iby6WLhlYDEQkgC8IafgDnDtzFYKgpyP35gKqKCMf8S6mnAcGN2pIeQ+ZNk+BbBlDkQ3IPr7I/HtZapuw64stjOVpSpVf5LzAdhZrY/uMvVfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786101083; c=relaxed/simple; bh=poRqZEkU5LvJyeyCSdOUxxVBUHjhkd4vvFnKz160lK4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aE8r722qBWd1SJRYpr2lmd3DFoFvWU9NDdk3m9uVdlWWixS1yfObnEWcFV/NrEXJRHB1lt5YQqHRa47UOJ4UriEpROt07Tf/3T5qxdDk8HgVDO+xOkib75G0R6orktwmcow612OTkJ/WnNu+Fvz2n90gv8C4lpOEnmZVRcccwqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jHk8nKDK; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jHk8nKDK" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2d049069377so34363085ad.0 for ; Fri, 07 Aug 2026 04:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786101081; x=1786705881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=DHrUp83qwVhXD9+7xChIl8P9YZjyW3n7qetzxlCU6VQ=; b=jHk8nKDKK2pFQBlGUzDf/Qkysqg8X1oYBvlaV2ZTWqf/yp2HUrJMVvV1BRYc5sPHW1 viTEztxE6x6rj8IdwxAKy66urbqQubpHz2UMLo6Gi1PF+9O6YdrWGxiwlio0fxsulsgK gd8Z7cpa8zFieYKIC8J/uPzvnHKaU8HBr7zP3i8dHD2+jvf67DYKZM6gXGN/6fv/0zWD hzavNGSC6vH6zv1ypPIDrcn+kKuhivpk+juuzm2MooKnPYhClR3ZhM2/BaQlj4E+bBID 65PPQc9BpdZD1CepDtKZstJeYHrt+78boCh30bcxz95YoBBvry9H/1qATLQx2gN6QbPx FRug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786101081; x=1786705881; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DHrUp83qwVhXD9+7xChIl8P9YZjyW3n7qetzxlCU6VQ=; b=jLqnQOLk6i1pv1fxaD34lKVetziphlm6cmaVsrxN6Sb0GkGOs1xoJQeFZvf46f7AGE GLAe1UmX2EAjXYWdXygqenWsXAQbCBtd1fzafFzraIdyqfZ1s5zaDMYFSTZDtJCz5uWA OJgDuo0WTksMt0TwGcrFDyLGQbK/Sa35IMnbQddAl3Doc1o8Qnr1ItVBxb3g71WfMk5R jsYq+C/0pIdvg/4hUGnfUrwQ7Zoaez2+p+r1i6BJeNNa6KKQpEtyfRRx2Hit2UhG0coI 382e3OXOTKc4djSIKSg6xQuX/MoOl6Rc5204XtX3TG2UoDj3lQIUhE7lhhIekh9XsAKm xbwA== X-Forwarded-Encrypted: i=1; AHgh+RraTaUYYTKDK9dnZqRWwXal73lWrL3YwRya/4FKGykZBo83SLlcUYUf4uPbYZFMxdcVIKta6rby3El1wr4=@vger.kernel.org X-Gm-Message-State: AOJu0YwSVAVJObSHKEL4tPvNaoFEB1RZdRqLe99/sctQpMVyd/r+KLb1 v7FtB2U/l/w/vB7zEpDkj6hGXeylS9DmgxjKw3ivfUvmNjoa/MyxFsSD X-Gm-Gg: AR+sD13/wnZHu63CxzNUMViqGCtfXpAFXdhdk6+7laXGlKmc9UpqWq0gTEhwo1qBkgr Aeo6viel2Xt3a+1A3oI+LPqcZn2cfUdexwv3BBazPgxMynkZAvACgrK3/9GD99dAgatwJpl9/GK OzlSBCo73vCUmEJfm1jFCl3Rq4p0i5mf/JACnKHMXCnkJTmHa9VWZBbr2cuujhiQ9mtq020iCUX hdVbmUg8dc8e4j6wGLDp8RUX/0uELE72PI2vhVxxbOG8j90EUdnX/SseksIzBhoOYwrkRtuOQtO 541o7NwSubMNBlDg85qfszrH4T4L2q/mk2ddvQhaV5HeyBenuABMeCVanLeXTuvKJXas3PBVKvH 7ifyLc01EXxDfO/TUQRcZ0xer2EsoFMUtqBgqr1VQyLmKXO01kl93YRrevmUHfkxix9KcISBQCr WziCWGSBxi3rqcVdMH80BGenSLhIiNmHwZiAaRhu/OJr99/hNs3dt6tuWThQOj9iNjWwbvX8eHh wI= X-Received: by 2002:a17:90b:5343:b0:37f:a915:1c29 with SMTP id 98e67ed59e1d1-3909d9174b2mr8132294a91.19.1786101081076; Fri, 07 Aug 2026 04:11:21 -0700 (PDT) Received: from ubuntu.. ([152.57.97.22]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-390b31fc026sm1088705a91.3.2026.08.07.04.11.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 04:11:20 -0700 (PDT) From: Ajith P V To: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org Cc: speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Ajith P V Subject: [PATCH] accessibility: speakup: refactor deprecated strcpy Date: Fri, 7 Aug 2026 11:10:58 +0000 Message-ID: <20260807111058.91464-1-ajithpv.linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit strcpy() is deprecated, use strscpy() instead. As strcpy() performs no bounds checking on the destination buffer. This could result in buffer overflow. The safe replacement is strscpy() [1][2]. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1] Link: https://github.com/KSPP/linux/issues/88 [2] Signed-off-by: Ajith P V --- drivers/accessibility/speakup/varhandlers.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/accessibility/speakup/varhandlers.c b/drivers/accessibility/speakup/varhandlers.c index 462f8d879053..c6d3b4cc1af8 100644 --- a/drivers/accessibility/speakup/varhandlers.c +++ b/drivers/accessibility/speakup/varhandlers.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include "spk_types.h" #include "spk_priv.h" #include "speakup.h" @@ -265,10 +266,10 @@ int spk_set_string_var(const char *page, struct st_var_header *var, int len) if (!var->p_val) var->p_val = var_data->u.s.default_val; if (var->p_val != var_data->u.s.default_val) - strcpy((char *)var->p_val, var_data->u.s.default_val); + strscpy((char *)var->p_val, var_data->u.s.default_val, MAXVARLEN + 1); return -ERESTART; } else if (var->p_val) { - strcpy((char *)var->p_val, page); + strscpy((char *)var->p_val, page, MAXVARLEN + 1); } else { return -E2BIG; } -- 2.43.0