From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDA3381B05 for ; Fri, 7 Aug 2026 14:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111312; cv=none; b=MYI8elPmXy0rHv/w2e26CgGjNrjYkodCX0F6SF1XGgxlzwpKD9nYhBUBmdbQqiqaHj/wvWLVuphki4l3HfZ8AHXUcg7s/pLruJ6UclOS/KIGnf9IVi/hAepjVaRJlvYWC+uYA3y0VvU4UUy48tMdXbiCJgdFAdT8UZN7/zoEdIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111312; c=relaxed/simple; bh=3dAOEbykdIHnPZ8b2z88NXhsFkV7doBfxxXeLwInc4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WRWoZtTRlF38+eF7oO7ebuDGGQfJRp5iQOl677hU+YT8nUd/j/G/5+bcc6OKbqI1z2c44KLRMaePcKSc5q8RA1/iXka6gBHdRtoUTH+WQt3GERy7QWtIUGOHST57IBMGQTzkoYxvqViWhgObX38L0Gfn0FsPc9FsZLA192uaQUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=A4J55L71; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="A4J55L71" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c2a76536bso30473541cf.1 for ; Fri, 07 Aug 2026 07:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786111307; x=1786716107; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BEsWznd+rLSTyIhbQ+J6RqU737I1qVHQOa8vM59Wd7k=; b=A4J55L71f5jmSzdB3KSqvutAHMdcRDF2Ehdrznmaey3rmEze62zGIE3JwQ2v6WEuf9 c8c2nxi6Vz23lrQEsx7sSnKKXfL5wPxqmRbFBpz25Gc2HERY0a2pPWekdTr9evPqjxTl Re3mQjcDRwj1jS6mMxXrALLeRvPfuxWJmrcJSq2ME3idD1UufZ87WM7iRX46SiVxEwn0 alaGfGgDEqsrKDur4xTKPKeb3TyjT0hUiLepSlduHQzXYHX7RrQyBeE70wVIMkvS5mMX KZvhWhZLDI1RDpSla/hWtq/E+7FTdBxoWjdNqyGM/aHdBaUkJ8rvzFe8aUw6PyYiktWm xW9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786111307; x=1786716107; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BEsWznd+rLSTyIhbQ+J6RqU737I1qVHQOa8vM59Wd7k=; b=Rovz3fHvF0VMZSfWQC67w6HJ6Xu7NDew8BjeOPLNHZRrNZO+AQL8JZwV2+1TNRNVHr PMlqwh8OgcX54KioYkhP9Qip6Ss/fOLqPC+A1xXcS/V60lwg5zKgqBVk6ahhA2otDHAQ KBapFW63StezJCbsuanfSadBP4iEsxPdNLOk5pDHV17veCTcQ4BHwUrQyHCKL7x8P7JV uIKls2fExDSsTmEk97TCO7l7F0nK0Yxd9tm9NTuRBAHVEepkqImfbVcjKGu1LDVHh7C1 3rDupxGxVdYwMQAtCV0nxiq9plVqKZoU8R6BWGa1UMRk5/fmm2B8mgSpcv61c+IFvlR2 kZdg== X-Forwarded-Encrypted: i=1; AHgh+Rr2cp7+ALGr1LOai72QkDGo9Pn82eENrdvNZtGTXxowvPfmsWgQr0W2nbPbu8X3xj5XMiXPFkkxQUJzWkk=@vger.kernel.org X-Gm-Message-State: AOJu0YxM1cgKhEp/fhO23TFJmmGgPtiqhAhbS0zt6LOpTsNlU0Zzw5GE hBXqm4zXM1Luq2ECOYyE2RrUu3wmpUZbGsIGjQqRjO/vy29XLQzfzwT+Y6AxVT1EqkQ= X-Gm-Gg: AR+sD12AKGKdvFpql21PrmE584+mPZp/jaqUgKhCSj8RH6gI1ffWUwTwhTF4AAT9d5r NZgk18wSvy+AxaZB0gJCWwCEyYmFFR4X13zyqq4PL7n1Jazwsp/XUj67HfsjOMyvSgzENMVTN1U 7otjDB3LNOq3mzw3MUQAKbQ5SkdCAc2MVCx7mlHLKPmTftCD17B9NDUAxWb9rFXkCJyu5Dm9l3F AYIxWjsiBHBI97r2m3iZJqF2k1mBjyeO5zsIL8Qh6kZ55rV81d2dlc9HTpxPHbIIv5tvvRqh9Fa sUNt2zek9rYSa9aNxZhAsJeW0w/LBRi07fQHA9p3aBcpJIDGggq2Rgcx2NGueD0jj4us5PWKLcl BxVvgaQMunC08R9T9JHEeITLfJnE1Hcg1ukp5DIol7tfBM7gOOkaOtHIqOeguz8x/U/yk5MzpLb sDx7tO9Bsa0GZnRvDDmHcps9mJydzqtpGhzYq2Vw== X-Received: by 2002:ac8:5ac4:0:b0:51c:775:c175 with SMTP id d75a77b69052e-52d20a8e763mr9083261cf.40.1786111307065; Fri, 07 Aug 2026 07:01:47 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d1637f4a1sm12604881cf.9.2026.08.07.07.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 07:01:46 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wsL8r-000000012Kq-232W; Fri, 07 Aug 2026 11:01:45 -0300 Date: Fri, 7 Aug 2026 11:01:45 -0300 From: Jason Gunthorpe To: Pavan Chebbi Cc: michael.chan@broadcom.com, linux-kernel@vger.kernel.org, dave.jiang@intel.com, saeedm@nvidia.com, jic23@kernel.org, gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org, kalesh-anakkur.purayil@broadcom.com Subject: Re: [PATCH v5 fwctl 3/3] fwctl/bnxt: add DMA buffer support for HWRM commands Message-ID: <20260807140145.GB200537@ziepe.ca> References: <20260707100019.60553-1-pavan.chebbi@broadcom.com> <20260707100019.60553-4-pavan.chebbi@broadcom.com> <20260806175739.GG28508@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 09:32:34AM +0530, Pavan Chebbi wrote: > > struct hwrm_dbg_ptrace_input { > > __le16 req_type; > > __le16 cmpl_ring; > > __le16 seq_id; > > __le16 target_id; > > __le64 resp_addr; > > __le32 pdi_cmd_buf_addr[2]; > > __le32 pdi_resp_buf_addr[2]; > > ^^^ > > > > This is really sketchy to cast an array to a __le64. If it really > > means a __le64 then the struct should say that, if it doesn't mean a > > __le64 then this is broken right? > > > > Since hsi.h is generated from the HWRM spec rather than hand authored, > it'd need to be fixed at that source. > I will take this as a follow up change that we need to do internally.. But it is correct to be a le64 and the sketchy cast is Ok? Jason