From: Guangshuo Li <lgs201920130244@gmail.com>
To: Min Ma <mamin506@gmail.com>, Lizhi Hou <lizhi.hou@amd.com>,
Oded Gabbay <ogabbay@kernel.org>,
Karol Wachowski <karol.wachowski@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Guangshuo Li <lgs201920130244@gmail.com>
Subject: [PATCH] accel/amdxdna: fix usage_count leak when autosuspend_delay is negative
Date: Fri, 7 Aug 2026 22:32:00 +0800 [thread overview]
Message-ID: <20260807143200.2500342-1-lgs201920130244@gmail.com> (raw)
amdxdna_pm_init() calls pm_runtime_use_autosuspend(), but
amdxdna_pm_fini() does not call the matching
pm_runtime_dont_use_autosuspend() when tearing down runtime PM.
If autosuspend_delay is set to a negative value while autosuspend is
enabled, the runtime PM core increments usage_count to prevent runtime
suspend. Without calling pm_runtime_dont_use_autosuspend() during
driver teardown, this reference is not dropped and usage_count remains
unbalanced.
Add the missing pm_runtime_dont_use_autosuspend() call in
amdxdna_pm_fini() before restoring the runtime PM usage reference and
forbidding runtime PM.
This issue was found by manual code inspection.
Fixes: 063db451832b ("accel/amdxdna: Enhance runtime power management")
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/accel/amdxdna/amdxdna_pm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accel/amdxdna/amdxdna_pm.c b/drivers/accel/amdxdna/amdxdna_pm.c
index b1fafddd7ad5..7dcedb7c105f 100644
--- a/drivers/accel/amdxdna/amdxdna_pm.c
+++ b/drivers/accel/amdxdna/amdxdna_pm.c
@@ -73,6 +73,7 @@ void amdxdna_pm_fini(struct amdxdna_dev *xdna)
{
struct device *dev = xdna->ddev.dev;
+ pm_runtime_dont_use_autosuspend(dev);
pm_runtime_get_noresume(dev);
pm_runtime_forbid(dev);
}
--
2.43.0
next reply other threads:[~2026-08-07 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 14:32 Guangshuo Li [this message]
2026-08-18 9:20 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807143200.2500342-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karol.wachowski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=mamin506@gmail.com \
--cc=ogabbay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®