From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726843AAF54 for ; Fri, 7 Aug 2026 14:40:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113647; cv=none; b=C3R4Nc5LHNsMk/BcPY/ODdMEc/yaiitmxeD8Lju5CeG4DNzb16SKr6e1aZWFWsIvqu2pdv2m3CIuOKS7WE9vnp7SWkhk8q60EUEqUF2QCJTiAffGA7Lco8nf7vYjt4/aE5QTg+esUaQPrcmcjukROPgttT0vxGAVIUfHvFqC1Tk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113647; c=relaxed/simple; bh=1BKnXr1/MB/NkXRWCaUFR9AAMwMUPnEGjKZQWbfUj4g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X4UOoamE6dht+1g9gEwr4Eos/UguZ5mIzPsfr2X3R0dcp+s5UFBEFvLh5SDPRMrUyG13oesgQ9Izr0DnV1cMTr3kX8srZmxaAM6htr3SlR42C/upydC1PwZzGQ5efDR5cHs1k0zyEyofDmdAKsGC2jRkMVekRaC/46gej6qJZAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SFcjkl1q; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SFcjkl1q" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so2353363a91.1 for ; Fri, 07 Aug 2026 07:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786113636; x=1786718436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CcJguZmeHN+kiaiUR9y3o5cAga+xVBYwoL/bbx1DrYw=; b=SFcjkl1qgfOns3w0nr+/XbYj03NBnXnnsbuQEGg6rYrgUTtuyORcmUTV3aX3XoTiuT +fDhJewSSZaBNyh9G0pohSQEIA19st6qd2lh6UMJthxyQ7Cc4nne0qWrNxpAEEeYpY4H 6rgdU2iLGxKBvxIyuRs4816CtRm5GbVmSSXkZo6nc6BaPTS5Q6FZbnBdYlaB8naetxKy iIls3nsoYkoAUJ4JIfQXtHkAiF62odW/l/BEc4zzOBklmOk0GNkytsBzahuxJC3t0aBU nLuvZpJ6tcQ8ummmY3oicRJvQDPpCjBDzp03cf5YVMCCXhgB7wb7H7oWJ+v3Yof2+/EX JyTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786113636; x=1786718436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CcJguZmeHN+kiaiUR9y3o5cAga+xVBYwoL/bbx1DrYw=; b=lIKPjjhV4Ar6wjC4gTE8MY/syDo0n0mJtLb81gy+p5nJSXeoaYQd4vPmR5vkvsVMiY NNJuJaO+ygJzS2dBYHcsI0NjrZcnZp0Nluln8Ho+tdmR078x6p4U8i61iKpSn7Uxn8iv b/fDOD/kkOIzVkaK80IaHiTn1EsptN8IYtZlWyUvi4DoQW/pMHqr9HKKUA64Ptjc3/Ec rp6omuoA++SCfDd5wz3ftxuqt/eSC7wjityVu0Qwnh5ak/+5XAL4083SujYvxo1hta6W r4byZkHHoqvKihaxMakmLzgPnhJvLgD0Rl0M0oHXGYK9X68lGAc4RNameAtVxfSJ6Sqa 7iAg== X-Forwarded-Encrypted: i=1; AHgh+RrztnR+CZCyzNyKmP2uMl6ybLs/F6HlA1HuXBuc5J3zhU+dk7MC7QTbEC4LpJMfH/xNy6SCM8/iZAoWzTg=@vger.kernel.org X-Gm-Message-State: AOJu0YzW9IPjkLAE+YX2jMx6MzX6Dr6PLg/iIpYDGXc9kjxsXX6pJmR4 3RDYjTuTcsNUMsHNocvz3sAGBB3Rqf1WPL+jRMtwkf+qlgmCtSEYvoLk X-Gm-Gg: AR+sD13DB2JBPZeh7McaEZTh95xs7C0JtBGnFsfaI9b37RUz45nivuNZpFMSiK2kUvB 0/weFx+F+axcdawSlZOBX9LJB2JSZWHRE5juIq6EnXOz2qAD+i04mcBD9O84sClIZSW1+419jvK m3YNTiV+maKFcCMC4j+tace3cmGH01RtzWNLUGlsxIOS6H0MoVxJtffYMYekZX1DndxxNXw6XXO S8ipZ3I6rqXtdxTfEwFNqPqSgGC5vKYLGG26jdI9DuFZnL8uuI5ftc1VzzU54HE+DGqCW7CGlBR nL/Or1GQhUguuLJNga2nLmPLUPzfF6rThWxObYIPEPjdGlZrROHvllo8/KeesOohSO9gMzDSWEs M9UhwrMTzXOkCJ90E0ZDih2zhV4ECq0KJLRh7gC1T+ji8KEFrNIrniQx9btACsKRoVgR/neKDSQ dU1LqkfThU9nTesnZ3yfWAoqNaSP0liM0mF7oQIYQ7tx3ipN21Kj335L6E/T6rPaLmu3FocvOHY gk3fc1UwxY41LniISMnnmWNIJtrF+PmJFlkzTA/uoQpIpfe/TMUEw== X-Received: by 2002:a17:90a:ec85:b0:380:f85c:94b4 with SMTP id 98e67ed59e1d1-3909d8075eamr10896910a91.7.1786113636367; Fri, 07 Aug 2026 07:40:36 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925ff24b91sm2917026a91.9.2026.08.07.07.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 07:40:35 -0700 (PDT) From: HyeongJun An To: Srinivas Pandruvada , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, HyeongJun An Subject: [PATCH 1/2] platform/x86: ISST: Validate socket ID in clos_assoc ioctl Date: Fri, 7 Aug 2026 23:40:02 +0900 Message-ID: <20260807144003.3498972-2-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260807144003.3498972-1-sammiee5311@gmail.com> References: <20260807144003.3498972-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isst_if_clos_assoc() validates the user-supplied socket_id with 'socket_id > topology_max_packages()', but isst_common.sst_inst[] is allocated with topology_max_packages() entries, so the valid index range is [0, topology_max_packages()). The '>' comparison lets socket_id == topology_max_packages() pass and index one entry past the array. In addition, isst_common.sst_inst[socket_id] is NULL for an in-range package that has no bound TPMI SST instance, and the pointer is used without a NULL check. Both the out-of-bounds entry and the NULL pointer are then dereferenced by map_partition_power_domain_id() and the following power_domain_info access. Reject socket_id >= topology_max_packages() and a NULL sst_inst, matching the checks already performed by get_instance(). Fixes: 12a7d2cb811d ("platform/x86: ISST: Add SST-CP support via TPMI") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: HyeongJun An --- drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c index 24334ae70d82..b2965baeaa36 100644 --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c @@ -729,7 +729,7 @@ static long isst_if_clos_assoc(void __user *argp) if (copy_from_user(&clos_assoc, ptr, sizeof(clos_assoc))) return -EFAULT; - if (clos_assoc.socket_id > topology_max_packages()) + if (clos_assoc.socket_id >= topology_max_packages()) return -EINVAL; cpu = clos_assoc.logical_cpu; @@ -747,6 +747,8 @@ static long isst_if_clos_assoc(void __user *argp) pkg_id = clos_assoc.socket_id; sst_inst = isst_common.sst_inst[pkg_id]; + if (!sst_inst) + return -EINVAL; punit_id = map_partition_power_domain_id(sst_inst, punit_id, &part); if (punit_id < 0) -- 2.43.0