From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F8037BE89 for ; Fri, 7 Aug 2026 14:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113662; cv=none; b=c+D9pMwFPp3YRBgS3G0Y9knkKBxBBmzp2APznCStI2csHVqH/8/2TGg+LNPzOXBBqSySWgBeWVOjxSHBwwReiY8gjrHvGil2VMl8Lp/db9G4CoLdxt2V6qituqXfqlxblyuyBXjrA+Ov2bl1SinuldRmM6oHt16BCFxJ+2VfVJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786113662; c=relaxed/simple; bh=oI0oe6VrTB67fmNgGEWtYeo5Q1VrP79oiuVCB75VHIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mlsRrbFmrhc62SHurpHDfZR9GIlSi79LOzuYnD6ZTS4GBx6iX5jL4NKUn9a+d448mkII/I/SiGFto0R8QkYrHdmt0G7N4eNnxo3g1NQLxF9GVPD9suew/49vMqws4qfHElWpuBdeZn4v6RnXVxmJZOyStBcZqiLhq2Fh+VZorkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X7mJkZjd; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X7mJkZjd" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ccf2360620so33882155ad.3 for ; Fri, 07 Aug 2026 07:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786113645; x=1786718445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LShjbJeEqOu9xhr0m6OP6Zlw5WppQjCW7XffJzXc/YM=; b=X7mJkZjdQFpfgvNH6bIAxBKFmj4utiRNfINNGRbt3eXpVJeNaN7BhS/CmoVPHD0/qF tE6+tRnqN+LA70+t7H/Cq2rFq5dBYENBmJykcFj2sy7jdNAagx3GZ81XS3l+3KFG0ioq AFbCJ8y57lYhf7/f5BUFmLlRLmJofZIq3e2MjxmjGjh4uOHv2rmbZqgjB1eXUwiYmal8 iI1VhK0Kzqh/TLoJqowoRSgyj4cpajxso1+r+1sXdoBpJt8qvH5eS5s9JVkHm4vRefD6 vY1NJ+A3IOkQShFvzEFzeOrkeEp//QT0KZIWb7ch2AlwpTwvDWdB1RFlhyfJxl92rCx6 uZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786113645; x=1786718445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=LShjbJeEqOu9xhr0m6OP6Zlw5WppQjCW7XffJzXc/YM=; b=jmvCnFIvFwwxA2WQ1Qy4G+5b06nevYm5lcELp+sOQGkvd1fj1KxnxhDVp6bYouurC4 dq8jOPI0t3rdqD+dTwPdwPrVGjzE4aAvTF++P5ld89EmXVGwUDBWA22C5pJFgMSIW69g R4HQsh4X7dmakXmZghqQfqC9gfI85PVYf8+mWuTVfK+RKSp8LdzC3Gb/aKEc9qL+VRTt WA0wF0mJJud1J4IvT09aQf9C9N6+72Xy46Fsggl9vAPNsiFDGo4ByhpLDF7d2w/R05YZ 146cagaFQLSS3dHC8oDceomqQNJ8RqbU4Aes4UOzuVuAPkFajQLDTY5I9thF8ntCyftp kz0g== X-Forwarded-Encrypted: i=1; AHgh+RpXlllti8IQEjQAXoiEiwgOhoskVEuR9kf24BePC2Q5NMLPo+zflDtvhSP4VbXomjEZO86jh86j9vvjcg4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn98KAqiV3yay3gyQJBIqPDOKbmQu5z8IJ3FsEu71OSVlqFGth 0yt/bs+M/a/YHilWgd2gJzeUQI0OT/IP+20O03abB3wtygstcZT9uA3M X-Gm-Gg: AR+sD11xtMvrA7sVRxdNHW71LShhOhGwPkWeAk1xx7kQqI8PIvZzvoBzbxJReD0KatL ZUK0+r9eKnnBXRs5gEGE2h1h/6qkgHPGf3DA462Axqn9YJ8il8XWKk2rnbp796BGyaQDlilL3vJ DNlhlViB+OlVy1UJbv8uq9N1r1xehVL62SbzU7N0woBdMx5tlhkyIMUK0T1xqzFETXPhzIDQ71S PPC+nO5YEEu0eF7DCtWwdFtN/33VJjC7tLBM4z+uB0S5I9h4RC4xtuksousbCtCkq3vIfPFevcZ 7imOdNacK1J0MqBlgUaFqi38UBHcxAqq/Voh4kf37KajdaIJBAct9gA1MU/kBqAugSaSmLxJwEX jd5MX56riL1T+8gNDPCJo7VS/9kxqKk8zqOMvqLOAXoZonzKYBY/i/nMOrniVDGrT/YP+jZkLUs 5H7OLT4oXdYQaF+bi7ZSwPL3ovxfr+vXxt5JyPtgi6p6FsY/YojZVtIttVzqpfq8JTcz68Ao4vi eiNUtvEh2zJXZ+7Xa0sIyygEIo3u2JMLbsk+u11VtzrEvxuLpWD1g== X-Received: by 2002:a17:90b:2e42:b0:382:1a6f:ba3b with SMTP id 98e67ed59e1d1-3909d7d2f85mr11461420a91.5.1786113644715; Fri, 07 Aug 2026 07:40:44 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925ff24b91sm2917026a91.9.2026.08.07.07.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 07:40:44 -0700 (PDT) From: HyeongJun An To: Srinivas Pandruvada , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, HyeongJun An Subject: [PATCH 2/2] platform/x86: ISST: Validate level in perf mask ioctls Date: Fri, 7 Aug 2026 23:40:03 +0900 Message-ID: <20260807144003.3498972-3-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260807144003.3498972-1-sammiee5311@gmail.com> References: <20260807144003.3498972-1-sammiee5311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit isst_if_get_perf_level_mask() and isst_if_get_base_freq_mask() use the user-provided level as an index into perf_levels[] via _read_pp_level_info() and _read_bf_level_info(), but neither helper validates it first. The adjacent level-info helpers reject levels above max_level before reading the same per-level register block. Add the same bounds checks to the mask helpers, and reject disabled SST-PP levels in isst_if_get_perf_level_mask() to match isst_if_get_perf_level_info(). This prevents out-of-bounds reads from the per-level offset table on invalid ioctl input. Fixes: ea009e4769fa3 ("platform/x86: ISST: Add SST-PP support via TPMI") Fixes: 06a61df83209 ("platform/x86: ISST: Add SST-BF support via TPMI") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: HyeongJun An --- .../platform/x86/intel/speed_select_if/isst_tpmi_core.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c index b2965baeaa36..f1b6109521c5 100644 --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c @@ -1263,6 +1263,12 @@ static int isst_if_get_perf_level_mask(void __user *argp) if (!power_domain_info) return -EINVAL; + if (cpumask.level > power_domain_info->max_level) + return -EINVAL; + + if (!(power_domain_info->pp_header.level_en_mask & BIT(cpumask.level))) + return -EINVAL; + _read_pp_level_info("mask", mask, cpumask.level, SST_PP_INFO_2_OFFSET, SST_PP_RSLVD_CORE_MASK_START, SST_PP_RSLVD_CORE_MASK_WIDTH, SST_MUL_FACTOR_NONE) @@ -1344,6 +1350,9 @@ static int isst_if_get_base_freq_mask(void __user *argp) if (!power_domain_info) return -EINVAL; + if (cpumask.level > power_domain_info->max_level) + return -EINVAL; + _read_bf_level_info("BF-cpumask", mask, cpumask.level, SST_BF_INFO_1_OFFSET, P1_HI_CORE_MASK_START, P1_HI_CORE_MASK_WIDTH, SST_MUL_FACTOR_NONE) -- 2.43.0