From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0B242F71B for ; Fri, 7 Aug 2026 16:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120672; cv=none; b=iuGpqYG4U9FcEdgkGOgt6n5M9VtbP7OX0cVK7FHj59iRWA4uXXZq3b+33vhOzYeLw8ND3f23P0bB2ZMq6SRSd064oh75edyx+WwnUZRKCoSQoL8ltoiDXMvSJ+MTDKl9IRhK3eppniIEe6YVMcXp8wVrHfzRPOzEYTdmEJxSIp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120672; c=relaxed/simple; bh=W2vPaAvbBFaEnI5PS+wWp9fGPFM0lRF90ZCyeiQzTGA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N4uYo8YAe0jQRJlQk40MiY9WE/fFpx1M4PR7KxOCTjPM0TkuWBQE7T+kNNO8gb/zxJa54iI5iUcSN280P7Rio2BpKxSa5DVVg/VzgkHKjSsHhTOe3rIProgj6s4fk2kkBp92y8xVSOYMoRF97Hkc0Q229slA1GHKvjk4p706oY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DHt8Ax+q; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DHt8Ax+q" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-4a450c8ddffso525627b6e.2 for ; Fri, 07 Aug 2026 09:37:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786120668; x=1786725468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=RYnU/CjNnSldiurArBMef+rqNUycTmCsidAIhbgMp9k=; b=DHt8Ax+qYqOHOoWvUdhpnMRIVBkxqKnIdxQ7tdmDFFySm92vEYggSVFloJb/tidux3 ihfnuTzADaYMF8ARHfD7yLJQc/zGABeW9XSe3wqDRjJYcNWtxc0sg2YOl/NIeQXQX//j xpL5dtDkGx30iuT1TqxEBqSBC7BmTHNaUssGxVHSGdgEArDQmwxPWSXvwkFI1iXwkExX 46imgyIpN6Ydo4Qcl5JGxO1kYfg4wqkU5tivfMIvvaUj1/R9lgBKiv6Acc/sfwY0v1Dz FxJQV3pioqK1KMH1eQaV1WaNp6oDUD55dxqSYz5njHMeZfzpr7JsdjxwH4owbGWpiT4w Jdxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786120668; x=1786725468; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RYnU/CjNnSldiurArBMef+rqNUycTmCsidAIhbgMp9k=; b=q91cj6h+CDuQPgdXn3YJk6QqH8d/hIZ+Y/eu3k+chAJu9ScclIKAR6q8AW4XHixVG6 jaNYgUwIaf2iJfN/sKquAhQ+8QN9VujQhD+BJSjBtd7yUe6527kHHF+dat4MvGi/KDE0 HBFwUGRTHeIEhhBvURk5s/NGrvOmK9wO4fsVE3uQmAiKCsUl1Gd/r2GpWqHiQGTDF31t L2QSCkULm19ztyDKs5dsKD7MLVjTKjyGR1ShDTlRA/ewY/sekERjThRNc7+kx3WmQ716 R2hT8SbnLFHqUAQ3bSvvPNdDcvixuUsHJwBUdSZu4GQQVnb7OyWVaxgyHLx+Lb73Ta5P PoRQ== X-Forwarded-Encrypted: i=1; AHgh+RrqidQ4o9n6n/4CeF834cSGLQV+8uZimaP6d/DNCmwH3LKrPg2hUoQ8Kcg3YQlTWMnFb6/pT2iDFgQz3K8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5BZ7Ejwubw3tR85J8IVxHOx71le2QoFN/X6SgSI3nkHbZ6hZ3 26QH9AxsI2FFuXHREW1dfYznzcP4kpbjjyNPozqWqLx6rgjABus7btVBQ52bpJC7 X-Gm-Gg: AR+sD12yBNhVMVUi/2muiwpFM0Jr9+hj6Ax6+wsEOxXxCKxD1aeelMhsU9CWwkFzRtw AsCob/d7lBjHbcpRrLlBZaPviiHyusJiGSN+nOU+oCNmpz+KMpRhspQlpkmXahL29H/sq49qTt+ JTpC+LdhA9B7xpuUaMjV5/4EyEElKQdGbletnPSq9NONLyKW0VSLfyqQIRXBcAfPixejrD7JCEq 08Wxu0ii41EPU27ozJpR55Baf9jIu6P5VcQ2DiAu8iEy1b8g3Wv/+W11/Y3acz8AykHW4KSZJXN x+O6JfVUxmsVyWIvoLgDqzCzVy+1KDYDe8OxDgnnF9bEFc91O854c19q0gQIOjgI/9kKrxCcL8b QNnln5R9T5i2/ZsaFs57yGGEm75Na1UEBzWPMy9ccVEx7yfg8uWPjDGmXMrRCM7IAuPxHu8oGVX 4uAkcOa0Ul0R736TVorJstqSfihgqIGVj2unF/mEFS8/YQ+VrALZzkYpmOCSXWlsm04s1f8jfhj oT0jkSwS34A3drq08L9rfkLaVkn2Fzje78H3qdHCRvusaiWTdmZs68X/kp/VrY= X-Received: by 2002:a05:6808:13c2:b0:495:d9fc:238a with SMTP id 5614622812f47-4afae30e48cmr8312577b6e.3.1786120667910; Fri, 07 Aug 2026 09:37:47 -0700 (PDT) Received: from antares ([149.88.25.215]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae769393sm7731773b6e.16.2026.08.07.09.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:37:47 -0700 (PDT) From: Bogdan Nicolae To: Arend van Spriel Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v6] wifi: brcmfmac: cyw: pass PMKID to firmware if present Date: Fri, 7 Aug 2026 11:34:18 -0500 Message-ID: <20260807163418.487508-1-bogdan.nicolae@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Zero out auth_status on initialization. Otherwise, garbage will leak from the stack to the firmware (when ssid is less than 32 bytes and/or when params->pmkid is set). Then, pass the params->pmkid to the firmware (without it, the firmware caches a garbage PMKID on successful authentication and denies a subsequent association request that includes the PMKID). Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode") Signed-off-by: Bogdan Nicolae Acked-by: Arend van Spriel --- v6: Fixed diff line number v5: Fixed line length > 80 chars v4: Fixed indentation v3: Added Fixes, Cc: stable, and Acked-by tags v2: Split into a separate patch drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index 873754be5..2c59b5e57 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -200,7 +200,7 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, { struct brcmf_if *ifp; struct brcmf_pub *drvr; - struct brcmf_auth_req_status_le auth_status; + struct brcmf_auth_req_status_le auth_status = {}; int ret = 0; brcmf_dbg(TRACE, "Enter\n"); @@ -208,6 +208,9 @@ brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev, ifp = netdev_priv(dev); drvr = ifp->drvr; if (params->status == WLAN_STATUS_SUCCESS) { + if (params->pmkid) + memcpy(auth_status.pmkid, params->pmkid, + WLAN_PMKID_LEN); auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS); } else { bphy_err(drvr, "External authentication failed: status=%d\n", -- 2.55.0