From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: michael.chan@broadcom.com, linux-kernel@vger.kernel.org,
dave.jiang@intel.com, saeedm@nvidia.com, jic23@kernel.org,
gospo@broadcom.com, selvin.xavier@broadcom.com, leon@kernel.org,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH v6 fwctl 0/2] fwctl/bnxt: DMA buffer support for HWRM commands
Date: Fri, 7 Aug 2026 14:49:45 -0300 [thread overview]
Message-ID: <20260807174945.GG200537@ziepe.ca> (raw)
In-Reply-To: <20260807125846.45570-1-pavan.chebbi@broadcom.com>
On Fri, Aug 07, 2026 at 06:28:44PM +0530, Pavan Chebbi wrote:
> Several HWRM (HardWare Resource Manager) commands used for diagnostics,
> firmware management, and NVM access carry one or more DMA address fields
> in their input structures. Until now these commands could not be issued
> through the fwctl interface because the driver had no mechanism to safely
> broker the host-side DMA buffers on userspace's behalf.
>
> This series adds that mechanism in three steps.
>
> In patch #1, the fwctl core UAPI adds a new driver_data field in struct
> fwctl_rpc. Drivers that need a driver_data payload receive the value and
> are free to interpret it. Drivers that do not define one will reject any
> non-zero value with -EOPNOTSUPP. Existing mlx5 and pds fwctl drivers are
> updated accordingly.
>
> In patch #2, the bnxt HSI header is updated to add the missing struct
> definitions for the HWRM commands that the bnxt fwctl driver will support.
>
> In patch #3, the bnxt fwctl driver consumes driver_data as a pointer to
> a new bnxt UAPI struct fwctl_bnxt_driver_data, which describes indirect
> DMA buffers.
> Pavan Chebbi (2):
> bnxt_en: Update bnxt firmware spec
> fwctl/bnxt: add DMA buffer support for HWRM commands
>
> drivers/fwctl/bnxt/main.c | 396 +++++++++++++++++++++++++-
> include/linux/bnxt/hsi.h | 585 ++++++++++++++++++++++++++++++++++++++
> include/uapi/fwctl/bnxt.h | 4 +
> 3 files changed, 980 insertions(+), 5 deletions(-)
Applied to for-next thanks
Jason
prev parent reply other threads:[~2026-08-07 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 12:58 Pavan Chebbi
2026-08-07 12:58 ` [PATCH v6 fwctl 1/2] bnxt_en: Update bnxt firmware spec Pavan Chebbi
2026-08-07 12:58 ` [PATCH v6 fwctl 2/2] fwctl/bnxt: add DMA buffer support for HWRM commands Pavan Chebbi
2026-08-07 17:49 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260807174945.GG200537@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dave.jiang@intel.com \
--cc=gospo@broadcom.com \
--cc=jic23@kernel.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=pavan.chebbi@broadcom.com \
--cc=saeedm@nvidia.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®