From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5E10346E54 for ; Fri, 7 Aug 2026 18:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786127731; cv=none; b=TzxGUO0qQjxrdpgx1tzQ/52pbugu+GceU6nELNtfXClihNdIq5rDaCZBrtRvC99UeFJXmD/DYD+lkecefkdL4u5RcvRSDDXg4ywmygeP2FkAqcgwxh0WDXp16Ax35cMwYtocb4CoKpyPUslHkehrMaY/+5nH1VOkYOd1JIKsYaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786127731; c=relaxed/simple; bh=aolz0CiZatKyYk/CfTXhIN7vFfsQB1RuyO8bvJfZhHs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KAjljFgCjyyiNQF762UvJQCH9Ot+3K8YTW5QbTJxLEqIPNZR96T/AXqotxXPnxE00zfJSbUOj+zyI3A2+4z5FwRaDv9Pt/liWDkDo6EaR+vlby2hbDa1OVR7Kwuchdhg1HTl7lID9Jzc5KKBf1LJXw+kbqSYYFZURd0tPku1/qs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d/tGV5RW; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d/tGV5RW" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2d049069377so39816985ad.0 for ; Fri, 07 Aug 2026 11:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786127729; x=1786732529; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=71FmqS/PHvl7o8NluFQ2/b2PDwnrkoEGcwVSYjd4tqw=; b=d/tGV5RWpVDuXdMz5fXRIsAL/wfkZi+s0615IJknZ12OtJLLgHgTR92/55/gcJbZBG c3ZTicons9UeRH2BPPKJPjFKuw3tlVt78WDwTAY7bgwenWPyqA3JbTnEf4cAJ6Oky5TA eksTI8gqd7I7w9EoFBti2yzWFDTCHdoWFBp8tVamgH6lBvKlrBytCk68fldoIfoB+Vq6 qYle4RSBrGTiGGJ4AB3cnEtqb1mM2ygZwXp1g9wkmz1UQBqZX8vkmcPSUhLnp5f4I5xG icrGHRzwC2fr1O3PMfyBD0hbEIfx6Qq4uqxUzRfBlG20EuVfOAyyj7WhmdZPaMmT+O47 LFXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786127729; x=1786732529; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=71FmqS/PHvl7o8NluFQ2/b2PDwnrkoEGcwVSYjd4tqw=; b=Lh2mYe1tPwl6t3pFqk3wVDkVwJLuHNJb5oJHOphZ0QlWK4rdBj+zhIrdszvR2BXRsm IHUIm/ZT0TfS697lhJBjEDtTZi6//hYkWLFsIxaxF15BIza3qkxZoy+dbSGJVxxuACbk dhPZHjRsiYOAycpnaY3iN27Pk+n7yje6bWsAvL2wyyiFx360t1bFiTHLXfGxL1spZ82c T1bI2pcvlZZm16923gKl5/dknYFLWRG1bcKvyGw5Sa9poa2mm9SsAIU0zVc9zkbHtkGU gid3TadgAD5w2npYhIhUqfr1JXVcM4yRgzXDPOoIbVrUUUz/TR7rxtxXae+s8z+xojkb r+7g== X-Forwarded-Encrypted: i=1; AHgh+RpyrzgTEG+/YSx98Y0vEPBUa9UZeXXzx99Ocw89haUUK5ImQMZKACn2KqTPZdn68RCrbRnUtdmY5QVuNxk=@vger.kernel.org X-Gm-Message-State: AOJu0YycEtOnY6jNCZfLKxUqJPB4YhylJQrZnGbvFVV1+IyPG+WYCLA4 j2U/DERXNjOV7capasyd4OMpAJtC5IAHWdv17rOcGZkJ+YoKdchba7VF X-Gm-Gg: AR+sD13hnddiMw97nx0mrRWQjisE7kwi02jpgmnaLlxPVO0i1M90EzkydM8VK1mur/6 BUaenyBW4S2TV54R3/qbdpW+/gGfS1ETCrhcVZtM1TuJ34UQu5b2M+FTDEn2txDB1dWC+dD6Rei ZQqlxPkzFuD/Lzr8U1s/JNtl5dtWdn0Iqq0VbMIZ2KsW7h5ObY1MHQsMhuw5LTtUbXl/hY8HTrC 3REjgJK9awuv+D9ErfV5wWxoev/UpBQWE7uuFKfsp1VoEtZ2ncWiKevHn1q0zGmd/nHcsvy6sJa 8o1C3kBhFZXMSN5g9u5X2t06mS5OG0jXVAT1Ws1ijGxvp/eu1Tl9XEdb8F+mhCRz/sE366DqmBr LPHL4PplXosVUQO90R6B0FeHMzXq0dmxZTsRWn4N7kddy5Slp4jijgphJR09LFt5FzE7UWAmBjl bvuqKhIjV0CmOe1JenpByLmLdYoLlW5u+47lOaJD16FpGTBSxxkeP4Jy/ZQC9tUybu7XaDnULFe gkq3ty+5Ok/rfwaTQz29ksDjll0vQ== X-Received: by 2002:a05:6a21:6089:b0:3c4:2fe1:fa36 with SMTP id adf61e73a8af0-3cbadd74818mr15000583637.36.1786127729266; Fri, 07 Aug 2026 11:35:29 -0700 (PDT) Received: from localhost ([2401:4900:1c70:5a7c:d1d2:a457:c3e3:35a1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec128a0sm11483405eec.25.2026.08.07.11.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 11:35:28 -0700 (PDT) From: Punnay Sharma To: gregkh@linuxfoundation.org, mchehab@kernel.org Cc: error27@gmail.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Punnay Sharma Subject: [PATCH v2 1/2] staging: media: av7110: fix corrupted BER reporting in sp8870 Date: Sat, 8 Aug 2026 00:04:42 +0530 Message-ID: <20260807183443.13912-1-punnaysharma805@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In sp8870_read_ber(), the 14-bit Bit Error Rate (BER) is assembled by reading two I2C registers: 0xC08 (lower 6 bits) and 0xC07 (upper 8 bits). The current implementation masks the lower bits via `tmp = ret & 0x3F;` but subsequently overwrites `tmp` entirely when processing the upper bits using a direct assignment (`tmp = ret << 6;`). This logical error causes the lower 6 bits of the BER hardware metric to be silently discarded. Fix this by using a bitwise OR (`tmp |= ret << 6;`) to correctly merge the MSB and LSB payloads before returning the metric to the DVB core. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Punnay Sharma --- drivers/staging/media/av7110/sp8870.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/av7110/sp8870.c b/drivers/staging/media/av7110/sp8870.c index 29fb4934c..77bebf2c7 100644 --- a/drivers/staging/media/av7110/sp8870.c +++ b/drivers/staging/media/av7110/sp8870.c @@ -401,7 +401,7 @@ static int sp8870_read_ber(struct dvb_frontend *fe, u32 *ber) if (ret < 0) return -EIO; - tmp = ret << 6; + tmp |= ret << 6; if (tmp >= 0x3FFF0) tmp = ~0; -- 2.55.0