From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81F5331ED4 for ; Fri, 7 Aug 2026 20:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786135855; cv=none; b=XzNnfU8Iyp/1pBiuD/cMRYTicg5NkcN8iY7DWAvYR3j5xA4DGnUVPyfCdJpxkcbREWSmFnU6mtjRc2KLBsVTl31pD26kaYmTIaPHg5PJWYwFXb8Ln3IzdMLiqcVCtuxrSDwwCssSVf6y25Cahi8PY6tzuoVBa7Qtu1wpednw9Cs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786135855; c=relaxed/simple; bh=ovBootHlmPwMO9Q4aAGQU97zSZBvoeOXU5XO8Xv0k+4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=taEOOQ0OUbs1CUgAKXtN0Z7IalXD8sQQOz6r7EcZzlDzdnDPY5ROrmTS5pkxyStDPFkLKBK/gonxjvUg3U52uP4AvYf+vJCHw8CGelr5DURNnNH3mDqGUkF0/dsU3qvRu66u7aU4XU6E4Pa6YbW+NN5xHhVZZ59kJ7wxYJZDXSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QL2rIumA; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QL2rIumA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-495590dde14so5475e9.0 for ; Fri, 07 Aug 2026 13:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786135852; x=1786740652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I5BZy2hwsKHXRFfC3cUWApKwBxDn8y4JzUdYjcaPm6s=; b=QL2rIumATxgYkdIPuT6p3YL2DOD11Lx2cQJ9tsMYL7skSJPVcxyHJ3SvClgt65Oh4b jQO2T5W0fbrYkNX7Er2+7btvS/JIOwlnuYZsBSJWYaPP2vpHB1lQL9VCpdKfy6OxiV+o 9P4fsyxleBSig6svcYqQnaScRXvTIbGgfwZJLxaGJWJDM/ZtdhL7dwI3MGS2WAChrtYr FkyKNyzvBH19CrbPwhQcCdyNiFs5SvLKOTX8Ute3B3tD7Kh3R/3cOUPNNTUC7uDl2mTP p7+ky6iJTGmJ6Idu7R3ucqkTXHdSr6NqLGN45PV8yriTLrJK/LIuPjlfKp8y4eH1eGKC xnUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786135852; x=1786740652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=I5BZy2hwsKHXRFfC3cUWApKwBxDn8y4JzUdYjcaPm6s=; b=GCSfpJe/Nf1+Ge6u5EocgTySjwIOSIYrsdzhviRBR/zoED81RAA97ybAIZ+tjHlKSr /W6quK8AR0oYE0fIZxZ+usWG+SspF/yQUCE4uPeRlGaRwPcLwsr/cgGCNNYt+y8IyT4R MTvbdqKYVh1rxfjDLatgZhV0jZWp8kEA/ThLnRGY83L0geIpv9mtSmBfRStsuYxyIs97 q/mta9+LirnJquky48m5lU4xbYdJ8Ybc9p23W2fYmQn1KHPCt+6LypiRo9uce1Gcubbj muTrhA6kYSpk1IqBXRm13+JKNy6b4EjlPia/iROXqn9iH6C3nt0wSBxjGzEPDJW9eSgi wnnA== X-Forwarded-Encrypted: i=1; AHgh+RpHDmpUyqFPx7YFRVyYdyBei8c2/DP/L0Oa4Ob9nBN/C2bvgglqkIvw3AJ3LyNWf42ks/JRz3wdSFE/r84=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkk3IBbfiPYLFVGroI1Ovxj2PysOy1jijEj03vjXK6XdV7U3bM +gt/dqGZNpNwTg9kfnChf/ciEbgi3GqlMP9jRzWqCX5Ui4outSkyCR2w X-Gm-Gg: AR+sD10N1ZNAeUGBwYFa+s0EUYJ+5omgbLikGEQyQYMni8F7C6eZFscQ0L1MDpPYYdF AViMHu7X6AiEkZegvj1+9htnR527XeXX/aIpiOhYhpuek7biQ8gAKUpldbi1N6qvpzmXT2vCH3h PJsXvUQT4nanK/bBJ6+JTKSaq6HXvMWiwTmfGQsxUpxCWrdockWoT7hti4vXdeTvwTRwlrV6Jn1 yJiiLQptL9wK8K+AkCk4l2lafP0p9JtxPMSZGRqMgXNOaoi7GgxY88FZe051YK32iXAsKurR+eM UAm+VS+cQ+JqQe7zlp07RDwqV85d8kr3FuWrL5a/xQKmGNEI1pZmjSbuatGC3tuyiLanWRDtsE7 08QuRG34tJ1tAyXr8cVcI88KNK15dNTUbp3Qg/RSgaHVuTmHfA2+2yX08I0fjALkd9jxXlvQk34 5gKkaRb0lQ0LhN5Gf9Kf5gLX75NsM6aO1vpZh5JLnLwKOu0ZJJSFfQxgMTiSe5uH2ILe/EEXbPI FPCYzo57idBJr69MUvxKg9F4rglIruQjOpLdwCEGhSdTKxintFVrU5LW34ooLDq1zvXzH/LadCd 1tObXdyNeLuPNKK8LVFi1AuxihP7SiED5Cdx7N6Sq39xQlPLb5zb9OijxG13GvovE9Uc X-Received: by 2002:a05:600c:e549:10b0:495:6934:414c with SMTP id 5b1f17b1804b1-4994e7df489mr277825025e9.19.1786135851912; Fri, 07 Aug 2026 13:50:51 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-b105-e101-a437-493a-4de9-ee3e.310.pool.telefonica.de. [2a02:3100:b105:e101:a437:493a:4de9:ee3e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499542851d6sm192408105e9.12.2026.08.07.13.50.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 07 Aug 2026 13:50:51 -0700 (PDT) From: Karl Mehltretter To: Andrew Morton Cc: Karl Mehltretter , Andrey Konovalov , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Bradley Morgan , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot , Steven Rostedt , Sebastian Andrzej Siewior , Clark Williams , linux-rt-devel@lists.linux.dev Subject: [PATCH 4/5] sched: pause KCOV in try_to_wake_up() Date: Fri, 7 Aug 2026 22:50:26 +0200 Message-Id: <20260807205027.31972-5-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260807205027.31972-1-kmehltretter@gmail.com> References: <20260807205027.31972-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit try_to_wake_up() is uninstrumented, but it calls instrumented helpers such as kthread_is_per_cpu(), CPU capacity helpers and SCHED_HRTICK arming. They can record into current while in_task() is true. CONFIG_KCOV_SELFTEST exposes this under PREEMPT_RT. The interrupt selftest fails on x86_64 in kthread_is_per_cpu(): RT runs the timer softirq in a thread, so the wakeup runs in task context during the selftest's spin. The same helpers leak into non-RT syscall wakeups such as a pipe write waking a reader. Pause all of try_to_wake_up(). Wrapping only select_task_rq() would miss SCHED_HRTICK arming during enqueue. Fixes: 5c9a8750a640 ("kernel: add kcov code coverage") Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Karl Mehltretter --- kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index d5663df6c702..1e562a7ff0af 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4252,6 +4252,8 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) { guard(preempt)(); int cpu, success = 0; + /* KCOV: sched/ is uninstrumented but the wakeup callees are not. */ + unsigned int kcov_paused = kcov_pause(current); wake_flags |= WF_TTWU; @@ -4418,6 +4420,7 @@ int try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags) if (success) ttwu_stat(p, task_cpu(p), wake_flags); + kcov_resume(current, kcov_paused); return success; } -- 2.53.0