From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <error27@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH v2 1/2] staging: rtl8723bs: remove unused 'pwrdown' from struct hal_com_data
Date: Sat, 08 Aug 2026 21:55:17 +0300 [thread overview]
Message-ID: <20260808-rtl8723bs_efuse-v2-1-54488b13d554@gmail.com> (raw)
In-Reply-To: <20260808-rtl8723bs_efuse-v2-0-54488b13d554@gmail.com>
This field is used only in the HalDetectPwrDownMode() functions. Replace
it with a direct return of a boolean value.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 +-------
drivers/staging/rtl8723bs/include/hal_data.h | 3 ---
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 57d2925642e7..b9a7b03e2586 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -544,18 +544,12 @@ static void _RfPowerSave(struct adapter *padapter)
static bool HalDetectPwrDownMode(struct adapter *Adapter)
{
u8 tmpvalue;
- struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter);
rtw_efuse_shadow_read(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue);
/* 2010/08/25 MH INF priority > PDN Efuse value. */
- if (tmpvalue & BIT(4) && pwrctrlpriv->reg_pdnmode)
- pHalData->pwrdown = true;
- else
- pHalData->pwrdown = false;
-
- return pHalData->pwrdown;
+ return (tmpvalue & BIT(4)) && pwrctrlpriv->reg_pdnmode;
} /* HalDetectPwrDownMode */
u32 rtl8723bs_hal_init(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index f67ca496902a..57a18da67fc9 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -234,9 +234,6 @@ struct hal_com_data {
u8 u1ForcedIgiLb; /* forced IGI lower bound */
- /* 2010/08/09 MH Add CU power down mode. */
- bool pwrdown;
-
u8 OutEpQueueSel;
u8 OutEpNumber;
--
2.55.0
next prev parent reply other threads:[~2026-08-08 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 18:55 [PATCH v2 0/2] staging: rtl8723bs: remove pwrdown field & related function Nikolay Kulikov
2026-08-08 18:55 ` Nikolay Kulikov [this message]
2026-08-08 18:55 ` [PATCH v2 2/2] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Nikolay Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808-rtl8723bs_efuse-v2-1-54488b13d554@gmail.com \
--to=nikolayof23@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®