From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF6FE3A9636 for ; Sat, 8 Aug 2026 18:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786215335; cv=none; b=HWDK4mbRzV6kU8RU4GqJKMPwKxzTxgX9KiR1hx16fWYCqyIFvUFbYsV2g40aiADiuv8bmVPxkDft7I5mApJCQpVubVwksyHe81rNEu2Qlj3dpWqPlKjWGLzttBdYqJHcgcegVcNhV+l4sDU5nOYqO09Oa1bW6rhx4K26V2Rj7qE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786215335; c=relaxed/simple; bh=V7YvHYMb5ddxIvvnMHPY6ZgKf6bTBpA9t73up12PLcA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZTQuKhyf9JDcDp6VSBzWQiOO+LghmsNHKfO/OSgeqEUAsnVUZsUEAjTeUrxzb9WfN0W83SAq0PgZmQG7iH5mjDJG0rIVJqmN2JsL0S5v+eIUlWq8FF8vV+obY5/lfj+J/qEMisNZt34PZmenw9C/fTua5NTSOkV4RfGINW5oW4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mwzSSG6o; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mwzSSG6o" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-39f20d19895so4030461fa.2 for ; Sat, 08 Aug 2026 11:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786215331; x=1786820131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jaL0+BIDNSFkuj07Uyj8QdpIAZkBHvQd3SBnoAer9KY=; b=mwzSSG6oZMgoFmKDm557JiwKoNnFyB5MP4273TfDfRGETcL4XcqLiqKBg+9CuRXzH/ 9n4zEib7fY/iBxofX6+ZmVKVMJZy4Xk7QRUOq3mQgRwENmIJP9jvQ7wHRgds7JWb2Ymz VmUa7M6VcZHhPrlJ4hZNTsGkvBUtn0suRfAi3deSO+N48PuwlwiCwmPSM3ZTnIaO4AE1 pPdvdbQRQpuxcJBxzpIRQB1VS7yjP64ngHZtmOb+mPWWYAyLE9NHK2dz22s7w8bIFfbk HJipiFC/0qMP7D0Gl2yGUCH5GKddWDkIwlCmW7UJJDhXO57i5XVFTEB77Xw9a3fgC6hr xwtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786215331; x=1786820131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jaL0+BIDNSFkuj07Uyj8QdpIAZkBHvQd3SBnoAer9KY=; b=axNbVDJUgcHHQcaPt6FHdhF5j9oNzo20jl+gz6irw1b3YLTma1V+HMzwAeoJAqiyOk 1MwDRr7ptPcdJPYfcCZ0NG4arUzEtS3SMU8rzI7/sdlH5W/fCqZjDCBsH5bDlf7TxmoP 4bdM8t7mUMxHAc4tePfdBkSeh4atadTYnJ1dfyj8ZXMoTGRkuuOtIuWR9zr3oFsxYidE BSk4yyGDA7Oi/0GBPPBbC11MnIrI7vqP7e3xCjnFboyjY+k1aCGzy+gAlxGu/jgHWWQy OGyskgdg70TMSfVW9MnfeUgDI6VYhYqBjURzsvkyJzlvI8JbIEZxKkDOVn7BKx5GL4OV P8bg== X-Forwarded-Encrypted: i=1; AHgh+RrnTa9SJYmO0DLWcgrV0Js3ufJuSair3YMframLbt9JItbHtJq/GnnwhzlX2D2vTA16c7zAuVbqv0WmmrU=@vger.kernel.org X-Gm-Message-State: AOJu0YxMSCEjE1YQ+ckKFmnkCcSN5q4XJRyF+cngwVR35tqqd/SgE7Z8 ebQeBW9LACiuDVsXhFekahPJmF1pjm/3KU4lPpnHH3H8SGSZDmUIp7Bx X-Gm-Gg: AR+sD10vj61FFUhUnCjt5cAaHTEqhnzwcagHt1XIUanA8T362DVcXYPjTc4g8VCD+Ci JbgSAnqoQKLBjgbIj8gQehmQ13MpBWrN1/eEI/F38IDd+kbukhcHlMmRpBPI/DXnlYZvidn60JY VJqkmAGkHvskzHTgm3BZscvOMT6Q2yYjG6u4mqcq/DhfexQVHu87+vKBdBBA4Jd6qOTOS9pnUAp PJ30lXZvjL7TH/FruOadc0JgfWQJ7KSuH1BQR4e4bfK4bt+yl+xxFti3ZxjPXVb6kwqBV+v0wft +fZ0pqlRVSZRaT6gBCqfygXy/VmoDBuxmg9bbQA2LJj7uLm64Qk4TPUClkccKHmM2OMsy4gZYeX qZSA4kfDhJK23IY4bkE56exQGagMSfuGMR+M6O0X172NkHIGOPBHyhn8s2LHz8gATzjm5ulmB5I A0UNP770cIWZ+cH0pWbUTiY1+UxabyqvE/+C7I8vA3H+9feB3Tf0v1aFJ7t76aRUDZ7meeUw== X-Received: by 2002:a05:651c:a210:20b0:39c:7859:a2d8 with SMTP id 38308e7fff4ca-39fbb2db42fmr27240261fa.27.1786215330584; Sat, 08 Aug 2026 11:55:30 -0700 (PDT) Received: from [192.168.243.250] ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39fdda80e00sm11770001fa.9.2026.08.08.11.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 11:55:30 -0700 (PDT) From: Nikolay Kulikov Date: Sat, 08 Aug 2026 21:55:18 +0300 Subject: [PATCH v2 2/2] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260808-rtl8723bs_efuse-v2-2-54488b13d554@gmail.com> References: <20260808-rtl8723bs_efuse-v2-0-54488b13d554@gmail.com> In-Reply-To: <20260808-rtl8723bs_efuse-v2-0-54488b13d554@gmail.com> To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Nikolay Kulikov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786215325; l=5416; i=nikolayof23@gmail.com; s=20260402; h=from:subject:message-id; bh=V7YvHYMb5ddxIvvnMHPY6ZgKf6bTBpA9t73up12PLcA=; b=7DsVJv7p+4uSg9pzCwgvZThSuhRxGQwwcYLiSat0vMy6Mu5EWex9RVAdPOQCslRPJwwJOaTIo DBxMdsETQcPBi2oIjVml4LXW02d29vxxncMywzuzigtOaGzlYZ5vOWA X-Developer-Key: i=nikolayof23@gmail.com; a=ed25519; pk=2GWUU1isl5NJpkwSCQ4OG80EinZ3EUZXlrgAg6Pz5zI= The return value of this function is ignored at the call site, and since the function has no side effects, it can be removed. At the same time, remove the efuse shadow functions, as they are becoming unused. Signed-off-by: Nikolay Kulikov --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 75 --------------------------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 18 ------- drivers/staging/rtl8723bs/include/rtw_efuse.h | 1 - 3 files changed, 94 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c index 168ecb7a998f..7e215c9845f6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -145,54 +145,6 @@ static void Efuse_ReadAllMap(struct adapter *padapter, u8 efuseType, u8 *Efuse) Hal_EfusePowerSwitch(padapter, false); } -/*----------------------------------------------------------------------------- - * Function: efuse_ShadowRead1Byte - * efuse_ShadowRead2Byte - * efuse_ShadowRead4Byte - * - * Overview: Read from efuse init map by one/two/four bytes !!!!! - * - * Input: NONE - * - * Output: NONE - * - * Return: NONE - * - * Revised History: - * When Who Remark - * 11/12/2008 MHC Create Version 0. - * - */ -static void efuse_ShadowRead1Byte(struct adapter *padapter, u16 Offset, u8 *Value) -{ - struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter); - - *Value = pEEPROM->efuse_eeprom_data[Offset]; - -} /* EFUSE_ShadowRead1Byte */ - -/* Read Two Bytes */ -static void efuse_ShadowRead2Byte(struct adapter *padapter, u16 Offset, u16 *Value) -{ - struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter); - - *Value = pEEPROM->efuse_eeprom_data[Offset]; - *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8; - -} /* EFUSE_ShadowRead2Byte */ - -/* Read Four Bytes */ -static void efuse_ShadowRead4Byte(struct adapter *padapter, u16 Offset, u32 *Value) -{ - struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter); - - *Value = pEEPROM->efuse_eeprom_data[Offset]; - *Value |= pEEPROM->efuse_eeprom_data[Offset + 1] << 8; - *Value |= pEEPROM->efuse_eeprom_data[Offset + 2] << 16; - *Value |= pEEPROM->efuse_eeprom_data[Offset + 3] << 24; - -} /* efuse_ShadowRead4Byte */ - /*----------------------------------------------------------------------------- * Function: rtw_efuse_shadow_map_update * @@ -224,30 +176,3 @@ void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType) /* PlatformMoveMemory((void *)&pHalData->EfuseMap[EFUSE_MODIFY_MAP][0], */ /* void *)&pHalData->EfuseMap[EFUSE_INIT_MAP][0], mapLen); */ } /* rtw_efuse_shadow_map_update */ - -/*----------------------------------------------------------------------------- - * Function: rtw_efuse_shadow_read - * - * Overview: Read from efuse init map !!!!! - * - * Input: NONE - * - * Output: NONE - * - * Return: NONE - * - * Revised History: - * When Who Remark - * 11/12/2008 MHC Create Version 0. - * - */ -void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value) -{ - if (Type == 1) - efuse_ShadowRead1Byte(padapter, Offset, (u8 *)Value); - else if (Type == 2) - efuse_ShadowRead2Byte(padapter, Offset, (u16 *)Value); - else if (Type == 4) - efuse_ShadowRead4Byte(padapter, Offset, (u32 *)Value); - -} /* rtw_efuse_shadow_read*/ diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c index b9a7b03e2586..001b4b32c02e 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -538,20 +538,6 @@ static void _RfPowerSave(struct adapter *padapter) /* YJ, TODO */ } -/* */ -/* 2010/08/09 MH Add for power down check. */ -/* */ -static bool HalDetectPwrDownMode(struct adapter *Adapter) -{ - u8 tmpvalue; - struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(Adapter); - - rtw_efuse_shadow_read(Adapter, 1, 0x7B/*EEPROM_RF_OPT3_92C*/, (u32 *)&tmpvalue); - - /* 2010/08/25 MH INF priority > PDN Efuse value. */ - return (tmpvalue & BIT(4)) && pwrctrlpriv->reg_pdnmode; -} /* HalDetectPwrDownMode */ - u32 rtl8723bs_hal_init(struct adapter *padapter) { s32 ret; @@ -626,10 +612,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate = rf_off; - /* 2010/08/09 MH We need to check if we need to turnon or off RF after detecting */ - /* HW GPIO pin. Before PHY_RFConfig8192C. */ - HalDetectPwrDownMode(padapter); - /* Save target channel */ /* Current Channel will be updated again later. */ pHalData->CurrentChannel = 6; diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h index 808ba94a5998..a60e05cf699c 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -73,6 +73,5 @@ u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data); u8 rtw_efuse_read_1_byte(struct adapter *padapter, u16 Address); void rtw_efuse_shadow_map_update(struct adapter *padapter, u8 efuseType); -void rtw_efuse_shadow_read(struct adapter *padapter, u8 Type, u16 Offset, u32 *Value); #endif -- 2.55.0