From: Bryam Vargas <hexlabsecurity@proton.me>
To: Ming-Hung Tsai <mtsai@redhat.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Benjamin Marzinski <bmarzins@redhat.com>,
Alasdair Kergon <agk@redhat.com>, Joe Thornber <ejt@redhat.com>,
dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dm array: reject an array block whose value size is not the caller's
Date: Sat, 08 Aug 2026 08:59:53 +0000 [thread overview]
Message-ID: <20260808085950.422128-1-hexlabsecurity@proton.me> (raw)
In-Reply-To: <CALjSBEvYWGOryNrLiCM3SNivnzv_LXSFfcXonFfqrBQFQyyU=w@mail.gmail.com>
On Mon, Aug 03, 2026 at 10:24:10PM +0800, Ming-Hung Tsai wrote:
> The fix addresses more than crafted metadata. A lost write on disk
> drives can cause a stale block that was freed as a hint block,
> triggering this out-of-bounds access issue.
You're right, and the commit message claims the opposite. Its last
sentence should read:
Arrays only ever read their own blocks, so a mismatch means the block is
not one this array wrote: a crafted image, or a lost write leaving a
stale block that was freed as a hint block.
Mikulas, that is a message-only change -- fold it in when applying if you
agree.
Bryam
prev parent reply other threads:[~2026-08-08 9:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 22:54 [PATCH v2 0/2] dm array: validate array block headers, and against the caller Bryam Vargas via B4 Relay
2026-07-31 22:54 ` [PATCH v2 1/2] dm array: validate array block headers on read Bryam Vargas via B4 Relay
2026-08-03 13:41 ` Ming Hung Tsai
2026-08-08 8:59 ` Bryam Vargas
2026-08-10 9:09 ` Ming Hung Tsai
2026-07-31 22:54 ` [PATCH v2 2/2] dm array: reject an array block whose value size is not the caller's Bryam Vargas via B4 Relay
2026-08-03 14:24 ` Ming Hung Tsai
2026-08-08 8:59 ` Bryam Vargas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808085950.422128-1-hexlabsecurity@proton.me \
--to=hexlabsecurity@proton.me \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=ejt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=mtsai@redhat.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®