From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D6C52D7393 for ; Sat, 8 Aug 2026 10:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786184471; cv=none; b=H1q5R3F+uk98fwfJZ6+RuXcgPc30Wvzpl2I+eaxmqbesE6lFAwkan4IKovvUxNir5F6fyO8DOZ++HNtP98rM6n7a2khfXh2eQYXRqdrqKzlELyCURuDy2CIAQQKvx1c5yAFdQfPQMOvcCEg8pj4C70xmbpnGoRUgKnqr5FSm7kg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786184471; c=relaxed/simple; bh=RXpVzpt7di1+nGOPxTbhDa4AoMa4uRQ9RAyXrUYqYH8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=iKR1yF/liIBYCr4z/ive/7KZ2K7eisJpNPocEFpZfugLdvjLb6VWRLO8fEzjW39EfjWpPQnU82FpI8XZBLq2oVrHSugcs3wS3zUa3BhB27Psf9UZyQZCrrebUcxDn976izqeeVhxpV5pJyc4PqQ81Vmb6C+5j57n4sobOUeVMXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=quFBL+oQ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="quFBL+oQ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so1508375e9.2 for ; Sat, 08 Aug 2026 03:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786184468; x=1786789268; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=xQRg1mejXL46bQBa0p78UFbpH6Ut5RwhVRoCIO1su08=; b=quFBL+oQvWu8pzBnRtRQEKaW4d/OVtub9aNNuJ0wiEJT7nJ3d5B6i072GUnY5muwZT 90yZIybX+v/zMJyK0ci92DEUPp5/PflLc+cmDhS5ztxH0Oo8RNmsrqaAYJkIXNpQGaqn KWwFuz7rv++8A4YW4EjT6XQiGFC7/+3W7TVGOogoBPwRPc/RJ8vOWIU5MuwNUNR6IJJ1 Je+oifvhzVdJplKJ8Arnucj4pFkAQCLxmCZQd7tUt9Keiy7NPAEYvm2zWsKPgkdOnKdP JVoFpt1h6R50Ys6XTLfLstTB4kC11r1wYyUhUN9+/Avga/Efkl9cof3N+wHUcitXzVvN 1dDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786184468; x=1786789268; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xQRg1mejXL46bQBa0p78UFbpH6Ut5RwhVRoCIO1su08=; b=SWWkejTxoiXO8LlcnmbYuPuab/8r/rWii1dUBQymQTYADPmKpYvXF6U9IGvhxZDyFU Spzrqc3aCPsicx7kMPy39bKP6Affx5AsRlm90tWau9baYviyz18mlXNg3ZCoH2CRfPJb dLRSkkAXltUW0VLOeBuuCqIbiclxhtUjO4SYDqHvXCzonI82BPLPKwesvB4n3wHEh8AF HMCpnCtrvh7plD8QtSBkgWTI9++e+jj01CjiLpq2cRRMgXOXCKRaTR9Jk79Zb/yKGaMr s4eHp2bP+vu4qPDjlX7nHX2uuJ+Muy+cv0IKq8pRQmvZ1Z17/SQakjcS7e180Xh3atD/ 9IpA== X-Forwarded-Encrypted: i=1; AHgh+Ro69JNxe7jae7vRoG5WN8YkcddD+pDbTfNgv49KwHj6OEimKni6C9w6vlvOw8ii5h9a+7fzxN8yzQo5cHE=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ9AbeF5caBAlkDxv700AeASxaWcHMmsU4CP3hh/L2Sed3lBNy tXxC2MUYjGLDx46lzQ5Lg9LaFl9fX1ygmCydFgZQ7tGI3uM4ouIc3JHj X-Gm-Gg: AR+sD13vea1Gr6Xo7vnDmh/QEL6VW55KlVkInIka65kuWU2D/qcH8uK1hNdsObVjwpj fXAcHzoWPh9wpMsvvI22b70RgSpusmWPYB/RpyfQAlYNYjfuy2vn/wlStHxBKCJYG8UKafQcTPp mvB5sgs4HD/VDm3myU7eQj2UxsF/Ycj6xxSuaynPrjDo2sOW9O5Lbi2YX42LDrAXTfU1Xcc5R/D 9UUDzG+ueOaYXE46BXhCAE+bFpGmo1C6OW9DLUN0Z4BiGOk9pxBeC8YiTFHWCjhuS7QGNTvxiVy tjW+4yMS7zW7CSnwNeNmPOQVzDMk8WXDjZ5O05Ches0CEjpmJzW10ep1k+fTbUPCE33NjH6TX+4 ulgn2TSOYktpw0kgYTEKAnGHLvsCx8os8peJlA9YDVwfRvgWLECJPLmupkn2OEQ+xLbGHBiiKUK tt3S6/IbzQMX86cc67a3/V/QOc0I3FQKXawojQRpQkkpPlCSwYqiOfSWMP4tlM6E7zoIAMoPpHH 1Ls84JZsTpBH2bKJSBGtjMe6bvrk7alBHWN1YaVOibbFhWuyFCuCWRGR3iRE3/ouakoTEHE4zM+ 0YscWepDw/LfVT3WKA7A X-Received: by 2002:a05:600c:1987:b0:495:3de8:33a6 with SMTP id 5b1f17b1804b1-4995e0dfb2emr138243805e9.16.1786184468167; Sat, 08 Aug 2026 03:21:08 -0700 (PDT) Received: from localhost.localdomain (dynamic-077-007-004-134.77.7.pool.telefonica.de. [77.7.4.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021e8c5asm15256604f8f.18.2026.08.08.03.21.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 08 Aug 2026 03:21:07 -0700 (PDT) From: Karl Mehltretter To: Heiner Kallweit , nic_swsd@realtek.com Cc: Karl Mehltretter , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Javen Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH net] r8169: give RTL_GIGA_MAC_VER_EXTENDED a distinct value Date: Sat, 8 Aug 2026 12:19:41 +0200 Message-Id: <20260808101941.57666-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit RTL_GIGA_MAC_VER_EXTENDED implicitly follows RTL_GIGA_MAC_VER_LAST = RTL_GIGA_MAC_NONE - 1, so it has the same value as RTL_GIGA_MAC_NONE. rtl_init_one() therefore sends unknown chips through extended detection. If TX_CONFIG_V2 reads as zero, they are misidentified as RTL9151AS instead of being rejected. Give RTL_GIGA_MAC_VER_EXTENDED a distinct value. It is only a detection marker and is never stored in tp->mac_version. Found by Clang's -Wduplicate-enum and verified with a QEMU stub. Fixes: 5e3c5a2b85da9 ("r8169: add support for extended chip version id and RTL9151AS") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- drivers/net/ethernet/realtek/r8169.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.h b/drivers/net/ethernet/realtek/r8169.h index 0b9c1d4eb48ba..fb772cc043105 100644 --- a/drivers/net/ethernet/realtek/r8169.h +++ b/drivers/net/ethernet/realtek/r8169.h @@ -74,7 +74,7 @@ enum mac_version { RTL_GIGA_MAC_VER_80, RTL_GIGA_MAC_NONE, RTL_GIGA_MAC_VER_LAST = RTL_GIGA_MAC_NONE - 1, - RTL_GIGA_MAC_VER_EXTENDED + RTL_GIGA_MAC_VER_EXTENDED = RTL_GIGA_MAC_NONE + 1 }; struct rtl8169_private; -- 2.53.0