From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4898341754 for ; Sat, 8 Aug 2026 13:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786195044; cv=none; b=iK4wMk5+d39k45M1n4YKRLbzfZMSf8J8AfygNnY7xKD/fIijtZT/4V9KfstWA461twgcssZ0DJzoVvNJgWvqHb2KSgXlPkN5nDZ1/rNzdL5OAfDMik9cdjoe05fA2r9Hk7RpFGlHf3lcjMPmYbzlVtHZ39Imrx4qOZdzeR2VS5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786195044; c=relaxed/simple; bh=uNXKSJdgCM/gcLD9oVG87DBC0E23vzXLQvQaP902Z2U=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=druTM32e7/qeHuq6LdA4EtaGimSUUTi3/pknlVi1JNi4Y0/dHQbBPy4nBXerELyaQ3HOP8heaJtpJq+3445gGf4L8RUXmaC6Og2r4l9NNzjGqh4tLV1UWyed0flX10z5YzYtENjZXor7iQh/RB/Jo+z4Sx8Q5v5BmoP/V7/TWJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V9AmlLeH; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V9AmlLeH" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47fecbb7000so168454f8f.2 for ; Sat, 08 Aug 2026 06:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786195041; x=1786799841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=k7rLDJgiGBNy28Y0Cch7JU2d64DR0itzNJWdOavO6CM=; b=V9AmlLeHBaOlhcZ8QuNIJ6v1xG0zgD8CrXJsoPGvycOYI6j2UkZxhpEsUv5RyKI3wn R/HDbp+dh3J4zz0Kb6LDKq3TR+/OBEolgKdS14jy5Jmvs1Vr+3KHnH5OL9QkhJWT8Um/ ZrkVySZiehMJGOkUZWZEMa60MULy9eTth/q/0eeYtVEyq8vd2SNldTNKe4fh+0NqgMN1 v+ly1oXAkMrF7Ni9NV+tsNGcQ7gknLTNyLyA3fOlBN7uxlFEG5Ns8jiq2B0UPprO+U/u kXcKBG2NT+u5vGUWbQzvwm0H3cmfuJvTbvWu2UW+rwHEHO6qSHQzR01CXJjxO7641l20 91hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786195041; x=1786799841; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k7rLDJgiGBNy28Y0Cch7JU2d64DR0itzNJWdOavO6CM=; b=s6jKw/uIVCas0F8iuw7ovxnsDitsqBqP5hT/zIMZUxyvRB2pgKDM/GtiWRiA16Z8by KIShNPtsZ8YXzzcYclAgbR7TIzObi7vdKBXeRzJVzg17znpoU19IiWtukxOKp5yxIzg/ CeX32TiTETwt+qH9RqsbAb+8uOWPm2exQDYDahCqAkVu9qnqPz2Cic4F3l8Pbg3sxfDD dOhXNSMksJRXFzss8hrYD32xFBkvEBaqk21fygkja1k6Gdd/7U0Py+Cj01tl0W5WSACj Dc32qx/78jkdBVQEV1ipbaP4lLQCTfotBIZSZizyL399dZBa2l2X/tGjSlWoLKF6XT56 Lr6w== X-Forwarded-Encrypted: i=1; AHgh+RoyQ/jwLCBPj/4ZD7i9Nln+nwcl1UuQgi6Vsr1qlXlSK/9dy2m/O2AHe0umqUq6QvEA99i+RiawQLxtN8M=@vger.kernel.org X-Gm-Message-State: AOJu0YyBphvDtD488QEQfUQ77pY3sgf2Hmu8D/DRxtmgD11BznbTYC7a I+7tvsb+i2GewryKPftwi10FN0fUkgA8LXMuq54bCgwsWe7HM7Z474yb X-Gm-Gg: AR+sD10boCC7ysod4sUBl/gPwKt7asE4Rgx3lwfLPdB4xR4D8s4DTeZrtLJPNWfNJ/I 2Z6f6zB1L0ppfK2N0EZ8Nfv1bAvvJOpkmSgmEVS5oHvcjhOwRLYBm2mJBclYJ35y+1Mnsthpwni U9hBDYfjNnuuKNYGHY2Y2YAymkZ0oQoKwZ2I1+3izIaxL4P8qMvw4I1JCJ6dLomFETGgqA9SDPT gtziSvf3+/a6ONEpJRsLv+pQGX6ovN7oet4Aj6cSdpxeA1/9DFNOFCO7ZerdWnWtp1Qf0xA457I AvV49mr2AVnm1nB7AyQXOzW6eRhhHXKRPzXAOIRLll9pFlhAO3uZqY5vQuIBCVFWmV8OmTq/42P rWgcVSN2CAhTAPud6lLphXmBDzj2Q56zdfMoqUCQi0CTvCUqZwPSmGZVXczBi2ygVhu+d3k3HGb 2eWMhnpIv9RtgdAZg1IyVcAX/NX6f1ZTuWXWmHy5FfGXzpXniUvXG1TvbiaGrA3DnaSnIU0UatI TJuMHaf/+FbcO8nhMZUF6vMbWpq3NSfOjdgV60tu09vAnh7+UntbznwRyOKs3eAMhhKxk5zHb2x 15oOylzVbaeeyN1e7dIwAI/LEBwF14b7pHE= X-Received: by 2002:a05:6000:41ed:b0:47f:8d71:210a with SMTP id ffacd0b85a97d-48130ed871emr9891239f8f.15.1786195041367; Sat, 08 Aug 2026 06:17:21 -0700 (PDT) Received: from MacBook-Pro-von-Karl.localdomain (dynamic-077-007-004-134.77.7.pool.telefonica.de. [77.7.4.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021509a5sm14087590f8f.16.2026.08.08.06.17.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 08 Aug 2026 06:17:20 -0700 (PDT) From: Karl Mehltretter To: Greg Kroah-Hartman Cc: Karl Mehltretter , Alan Stern , Michael Grzeschik , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: core: handle port status errors in disable_show() Date: Sat, 8 Aug 2026 15:16:01 +0200 Message-Id: <20260808131601.75096-1-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit usb_hub_port_status() leaves its output arguments untouched when the status request fails. disable_show() nevertheless uses portstatus, so a sysfs read may report the wrong port state instead of an error. Propagate the status request error. Fixes: f061f43d7418c ("usb: hub: port: add sysfs entry to switch port power") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- drivers/usb/core/port.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c index b4452b665f591..0022473e526d7 100644 --- a/drivers/usb/core/port.c +++ b/drivers/usb/core/port.c @@ -96,7 +96,9 @@ static ssize_t disable_show(struct device *dev, goto out_hdev_lock; } - usb_hub_port_status(hub, port1, &portstatus, &unused); + rc = usb_hub_port_status(hub, port1, &portstatus, &unused); + if (rc < 0) + goto out_hdev_lock; disabled = !usb_port_is_power_on(hub, portstatus); out_hdev_lock: -- 2.53.0