From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DAA397E9A for ; Sat, 8 Aug 2026 17:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786209227; cv=none; b=mzdnG74YLKPflooseuljmOAG2FsXmZESMKZfwZjn3jtIPJPnE9/sXai/tMMRTyHuo64rSyT1hlbEwQJ6JbebiuypphLBn7b1HICX70kQ/6qKJoH9wN7hrP/ncmeEMBZ8w+KbOclyvn4bae+F+RAtEdRE71TVvwtda6kS+9wayT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786209227; c=relaxed/simple; bh=BL4aaXl8jSrSD7KD2HElXnbVIvexcjEn3VDaSsBViDU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NEajcoQSPnsPeaN1BlrLm+QPaHWBrTDVtARN7g3HEvfq/Y5SfAp5iQkcvjWs5UNEtdg/NvgucKO7YU8g7ex5s5wUh5p5qsIT3oQZJgI2DL5ud3tq9F310rdm6OoDyL/rwGPnYSQjOFNiAJ7jPNvm8d1sWCfQTr4QgEINbNLLgSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jOOkCpU3; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jOOkCpU3" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ced3386430so7057595ad.1 for ; Sat, 08 Aug 2026 10:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786209225; x=1786814025; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=x7rcP/EoxmNlfdqa20sdJaHCXqVdRdQPLgQvgF3F3BM=; b=jOOkCpU3TwwvIzptV2TCsfE2z1xndCkhY2b875nOUyWOAoT/ttM0117IIvrR/Vg6fL mR3plKzlShIRqpBzWDZot7/cko7MCcMGGKpwH19cZGy1SuNAz6r0UT3LQNyWzvZfcM33 kF3y+iw1prQEv54KFCK82dVHjXJk9SykdZzxCtIOZ5PQixhcrAKRa2EMO3NC5nRLAWQI BrR7uFv0JAaZqGYJwsne84S1TJNw46+mVgV8AGuKS94AFcLeSm/3cwOcP3s3WvNGoDm5 BugKrp/KtnrqVWaojmgAloJnqtx2RNpKjUsBwjR1CrszEQUd5yQXP9jOVWBhtgO92z2l Z+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786209225; x=1786814025; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x7rcP/EoxmNlfdqa20sdJaHCXqVdRdQPLgQvgF3F3BM=; b=SiMsiwvp5lDA64rtwPYdQOZLutQiWSI+jxCHJfZCWWLUUo5Pq/AXSDZWoZZ/ogWzs8 161ir/l5EnQZMvvcQg7ZWQuzCbgiPZD2KSmJWr26M8xqzdvI3ZS4yLfFko19DR7BeSmv rlg2yWJnE/uMTj8I19353dul1DPGgz23QnOan0/LLmzL+LtU6GI6Hv6sSxK9DJ7dn6Do ZIsMjxZ0og2K+ptoFTt/6f65hFe4/vr0jda9xWTLYNKNzPGj/f7qORGG94QYB+K2ZBOw iuxgLgbv5ltUTfFjn1sMjrq5U++f7qa7/5OIk5Ov2qCt1dgSiqagcvg/rDw4E6I3GcpW 1uEw== X-Forwarded-Encrypted: i=1; AHgh+RrYBxPCl0CZAw8+PMsqFLi+PuJu4PDvTSAUpvhX22CH93qV3+kMW2nC2mHBOT8ZCx1iyOlHsVP8g5kd7BY=@vger.kernel.org X-Gm-Message-State: AOJu0YwP3HgmafhXjCOkXOVllahRe3BIgnERv7G6ewT7L+u6jrIzvhzF J6dASx6ui74CJMUq+DOe/3W4EMJVcJ8VFSo1wJsOn3kA/JAZGFWwFsX5 X-Gm-Gg: AR+sD11y9R0eLk849sbr9/SlE6YqFlEPv/j68lS9djuCHVDA3l5d3sKuWsyKP+JGvWx KIi5zqKyce/i99dnOoNXLQzS4dD8Q2nvGM79wZUhPLlAteZli377AVxLDUXtonyhxHrC3fxJumg DS0jc0Zfb4no9GO7vmmp9ajSSbB1t5Unx2lLW5CLq2umi6Za9410O9M0Vkd63hCx2a0fq017kNl ja3N1Nz+fsBRPVJhYnrTL/6A2oDTxDG4nibLTOhl87C6dolwWHyN2ymFPVHs3Ad7kK8ixgLFer8 iFdG3rISue7fmdmCdSoZRncm8omayCZ5fBebFQ2SC1j7Mr8LrhBfMme+mQHZOHa3Y6BiHiNopXV PJDgBQ95qU/rVXAuvX6SUneq8v15nOSs/I9eVCdtDCzlaBsOCkXy0q56vZV/ErMfQTGpD9KOIQK yDgYb6N7cKlUYLvSgPddnGFS9jCyUjInUON8SAxkx1ZPez0k2LFIW7R2GYlqA= X-Received: by 2002:a17:902:f68f:b0:2bf:dd0:c8b1 with SMTP id d9443c01a7336-2d2948d4921mr135028925ad.0.1786209224584; Sat, 08 Aug 2026 10:13:44 -0700 (PDT) Received: from PC.. ([103.172.209.59]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bebde308sm21597494eec.20.2026.08.08.10.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 10:13:44 -0700 (PDT) From: Mohit Mishra To: Johan Hovold , Alex Elder , Greg Kroah-Hartman , Rui Miguel Silva Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mohit Mishra Subject: [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf() Date: Sat, 8 Aug 2026 22:43:38 +0530 Message-ID: <20260808171338.72672-1-mishraloopmohit@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit color_show() and fade_show callbacks use sprintf() to format sysfs output into the page buffer. Convert them to sysfs_emit(), which is the preferred helper for sysfs show() callbacks as it enforces page boundary checks. Similar conversions have already been made elsewhere in this subsystem (e.g. loopback.c, arche-platform.c). Signed-off-by: Mohit Mishra --- drivers/staging/greybus/light.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index cab02b5da867..2689f9a7524a 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \ struct led_classdev *cdev = dev_get_drvdata(dev); \ struct gb_channel *channel = get_channel_from_cdev(cdev); \ \ - return sprintf(buf, "%u\n", channel->fade_##__dir); \ + return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \ } \ \ static ssize_t fade_##__dir##_store(struct device *dev, \ @@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr, struct led_classdev *cdev = dev_get_drvdata(dev); struct gb_channel *channel = get_channel_from_cdev(cdev); - return sprintf(buf, "0x%08x\n", channel->color); + return sysfs_emit(buf, "0x%08x\n", channel->color); } static ssize_t color_store(struct device *dev, struct device_attribute *attr, -- 2.43.0