From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20C13382F33 for ; Sat, 8 Aug 2026 23:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786232428; cv=none; b=BMWPCvIMKkwY8KKRvHx8VJILkSPc9qVpSSwa5ldx6SSaeksWjMa+MnsXMlYAQJ6EtAlEkcWBtsonHegjhvItnHtw46WBJbyqPy8uvidDQoNP/dfqbmSGrqV2hAF2CN1LgEtNqcLc79EKfxnoDWwUJQOloAwmMx1Z3Id7A4bxDt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786232428; c=relaxed/simple; bh=ywgQQybimAbetQ1b5A6qf3bB8zSZlHCCG8IDtXjEdvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SghkrMyCbnwmKhUw5sj5X0m9agdJh7v3Rh33LDNcWjZ1JazF2KGNqwKN6hCgzxUYvosGEW2GASQs/FrvMvcPjLp5y71rY6mx864N/U0Pt0Y3fR+C2/5Ct+KC3nLddg6/jHBhua/U4HliNMceC9dHjHiKav7YlE2sT2rdDPDTU3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com; spf=pass smtp.mailfrom=peridio.com; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b=wDkLS/uM; arc=none smtp.client-ip=209.85.222.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peridio.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b="wDkLS/uM" Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-977bdbe1410so16301241.0 for ; Sat, 08 Aug 2026 16:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peridio.com; s=google; t=1786232426; x=1786837226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LW37IMt7/aNr6Ztw5VvHFxxJ0NK7pezHWunpaqvkaIs=; b=wDkLS/uM9luPF2w1zNMs4ay56CjiLJjnmWFyscupdx9ovG+0ZQwNfwPTqDCvDWiWYZ 6Ap0dWfFHagk+BTujC11DBES606j7ABciMaZOW5g3cHhUdx4ZixeJh6miWsog49REZX2 YeNmApM3zQlkZNqRf4UrixRknV3ZLi7mfQF5BvBF3UWMTmErAaWSbVyvnCHtw27Okvul Foept6ZtOnkA33SDVKejilEVPRgv+Yf9ixrpm1JbNmnAymZicVaDYJzTLdB/0QtIMHb7 LcqZJ7pPF66qWJD5FS3x4bBqMtYE5Q5avtbkTDhKGJ/e9O4I7vf+qOOA2s40j0PHNo47 MhOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786232426; x=1786837226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LW37IMt7/aNr6Ztw5VvHFxxJ0NK7pezHWunpaqvkaIs=; b=rtK71hObdtsiWpp9WcacsCbK9vpDM5vI8nv49WoZINXBn+Wo+7GIO2id7NCOOYh4eP mcTfjCN6ijcjHf25t8pm4HYGjqWCZ3hSDD2RVVA4uElPim88sWVuPt+JCShfxUL6GBSB DU5oaXuijZMiyVESDL6LVQhr9pxaAhkfYG3Yp1t2DWfA153Dgz/8wKFWwbvd3qEy+jsX l7/JwQ+bIEnbH/IIHM2L8H/m0LmqrMtT7aCYDcjEbOFABd+Nwl0SxTGrEo7dhTPpS/tC bA409bMjUnDjt4QmgZIhYq+iukOuSR65eBGJrWkRUKkifvnDAToqg0HGcbgLCYZAN9NA ys9Q== X-Forwarded-Encrypted: i=1; AHgh+Rp3HWveY8v3T3Hfz47/6NTIOv1Q1TefAoRLw8jAXdFZ+1Kv89+iH3bMB/2F/WnUzEQ6uJToPeySyCNxFzw=@vger.kernel.org X-Gm-Message-State: AOJu0YzrcGsazL05Qcoyik+dFS5NqJabGTbJc9NJm4n8v9Gaakpb2hJT eJWXjXon2aUHLmSu7hgsxwzd3/D7qFEPC+KO6fRXQ31wZtCCYfJAa3H09PI4tdof5d4= X-Gm-Gg: AR+sD11psR+FvK6jnYdCkl/trhxkF4LPmkrEPZBXHggHLxTUok7hYSJYhrqJjmsMcBO iTqEsD6Jx81hBsWXRdhB8/Z0KUTnuPqd137n6jm7fAjMDV77/0Z/Q2970ORTrLqSRqwXY9hhSD4 2mf0yhvlhYxREXXoCzSd8IABcMQXS7l/JK18xgB32SoZKLp9jypoCuzPaI599irAgGxK8Qa5vJF GmO6sZ0l6Ine96xdIm8cfCPWSXaX6Yg2Aia105+zfH5A6zQ+CT5jJGkJi6y+pWCLYWz4uErjzcr mW5vBarJF97Cw3abVINgqXUbmNEmNxzotLhJNhAVIVEotn2VqJcA89sBTF/AYMj+WIY95/J3g+t NBI8UmBeogbKvdVh3NYY3lh6RAcq8AUF2g9QJCxeXuYZsW6fqAb1k9RvTAuRfVgseHpe8/+fiZe Zvev2sOOUzRZmeGIN2H5d6u1AqtPO7FeKjSj/EMjn4KVvL0v9DvSUtME4= X-Received: by 2002:a05:6102:f84:b0:729:5cd5:8cc4 with SMTP id ada2fe7eead31-760e8d39fbbmr4540581137.4.1786232425895; Sat, 08 Aug 2026 16:40:25 -0700 (PDT) Received: from localhost ([190.113.101.40]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-76400dfe071sm2787519137.9.2026.08.08.16.40.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 16:40:25 -0700 (PDT) Sender: Javier Tia From: Javier Tia X-Google-Original-From: Javier Tia To: Carlos Maiolino Cc: "Darrick J . Wong" , Dave Chinner , Allison Henderson , Andrey Albershteyn , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] xfs: give the deferred barrier op type a name Date: Sat, 8 Aug 2026 17:40:19 -0600 Message-ID: <20260808234016.246054-9-floss@jetm.me> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260808234016.246054-7-floss@jetm.me> References: <20260808234016.246054-7-floss@jetm.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1319; i=floss@jetm.me; h=from:subject; bh=ywgQQybimAbetQ1b5A6qf3bB8zSZlHCCG8IDtXjEdvc=; b=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqd75hkyHuFdJdaJJvBanQA8vDJHIyzfr6C0JDF SLwZve0RxeJAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCane+YQAKCRC17sMLqGd3 H4C9C/9aSX0wUJHvMFvjKAOVvtRJww4qJJMkOB//QqPz+by++DLH//1CU1eSdMY0pHTlMwrFbKZ FJ6eltM8wcIhjYCBN11wyw1xX/itPHP5jj6tzsOF5RmuuCLGq/zcwstXKWw4u+kDQBgdQIJasZQ bhZKRZWrEN5uS1hTIRWJ8I9n6u7RXm0ACGDLE4xuYSDQeaiElag3dnVNCXwurf4wEmDbaRJvZcy 9TFFhBgIrF8VcxHHSAjsuI44hcaV26BkDy2spFrsN4eYI3ozC7tMmPyiarkeeacECA8XJ3fXZLE f1I3jY3ceh0PguIKZ/bxzTAKwiiburUrzpugLN1kjYrm/YEfuwYog9YrkOEC7Jz6lGDZzvE868x cMhySLjbniailI0P2Qv8gI6YICBfzs0VJz6wMHmZpGcp1EfZZav4x03YZh6WnGbMos5H6vT/9+Q wao0kMbzskKfUiBQXgL+Jzr67LMK1DxYPUwzhho7Pzs4bISqg5i9lVFbUFShsXsJP3uCY= X-Developer-Key: i=floss@jetm.me; a=openpgp; fpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F Content-Transfer-Encoding: 8bit xfs_barrier_defer_type is the only xfs_defer_op_type with no .name. Every other one carries a short string used for tracing and reporting: attr, bmap, extent_free, agfl_free, rtextent_free, refcount, rtrefcount, rmap, rtrmap and exchmaps. That has been harmless because nothing dereferences the field, but it leaves a NULL in a table where every other entry is populated, so the first caller to print it gets "(null)" in the kernel and undefined behaviour in the userspace libxfs build of this file, where xfs_alert lands in fprintf. xfs_defer_add() already treats a missing member of this table as worth shutting the filesystem down for, so an unpopulated one is out of step with how the file handles its own ops tables. Signed-off-by: Javier Tia --- fs/xfs/libxfs/xfs_defer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c index 843c33304441..75f0d37914d5 100644 --- a/fs/xfs/libxfs/xfs_defer.c +++ b/fs/xfs/libxfs/xfs_defer.c @@ -229,6 +229,7 @@ xfs_defer_barrier_cancel_item( } static const struct xfs_defer_op_type xfs_barrier_defer_type = { + .name = "barrier", .max_items = 1, .create_intent = xfs_defer_barrier_create_intent, .abort_intent = xfs_defer_barrier_abort_intent, -- Javier Tia