From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB2C202C29 for ; Sun, 9 Aug 2026 00:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786237062; cv=none; b=q4HrdRE2diM3Ve+UtdmNOysfiOY5ZVow6OuLqCM0VzRVlk/lvw7gXan89GXMbSQ6rywT/48ms83MMd+qp2Tl9Mes/JwVKylCzZjQwa8nWKJXuIgMmwwxxYo5LJGj8BIdReLYKnAMyG9OM/3dgbm7O/zBjdPcNm1U5X3rhgV2h0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786237062; c=relaxed/simple; bh=YFv1wVIfc6tMCRAvNnVt4Iu9dWgpQczxlDTzev+0DH0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oiNT8zAwmnknRnlO1+TIKYNvdIjpxIiB5YVPNDkR8rF/okhskv5MW7JEbpG4wdQcKZvPTTw7BhlNYIjidTHOLZinbJnMEHIEvMl9mT+ozRo4uGUpSvBmkrqNC9pWHiqtpnrDIYiJDuqsjykewJrww3AtJuUyaVWohVfyCejDMXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QNZILmvO; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QNZILmvO" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so516246b3a.3 for ; Sat, 08 Aug 2026 17:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786237060; x=1786841860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=I6kSW5p92W8/kaqT2ruoYIIYu+uhyEIgxwAMS+IbMAY=; b=QNZILmvO6gcpLp0O2hLlebDeaz4jV7ZNKbODIH9ya9nKPGXqxtvkgP9+AQIBdZMEwD p3ie7+yK4L6AsgI1XxyFnVwCVpu3pdywOEOyTlrQPUCr0gqHdtesmMH6B/tlVTS7ZDy5 2iFlGoiAnnuNYDfk/GyHysH16g79zqjY5avjDPaaMqhQb9yaphhZWCZcdqNtr5OOakS4 ohz+gPsZrRS+RQbTOg+yR+UziAzB+dpR4/2GBjM95Fu6Y2AlDZefGBhhC97y40gm7cHA R8V8Iux0gkW1qDXQ6EuTPQ0NYyrKStgtddiE7ZamadJFD6Umbx9XSAlaNGhas8MGvpDQ dKVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786237060; x=1786841860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=I6kSW5p92W8/kaqT2ruoYIIYu+uhyEIgxwAMS+IbMAY=; b=UpMMEHLxG+vG1sZBbaDZJJ7rP/cOqaC5UEe914oApxlKhrohz/qDC0V5bn5y1FDDea PjHGGaNU/Me8Zdh/zOYoJGII0y/zKu3mo/kJwmMc0fF15UhZaBlIXUGIQOEmw+U62BeT 0pc/bWnJWN81aSc6DljpQW4n1ezVcWoiULaQZdQmOr6iP9RRLKGqmFMHwch2mdBoe4lX rYGo7cmHftXkTEmu/Al5OF+ePR+S5VnTSTvqc0UEAdpk9uWlM18y8sTjZxXHnC4EdLMY xrH8ISLjPNUZ3zNlRnu/ciDNxsKnexVza4/pLbzzgfnDTQEOphUV8UNww8OO+BPd7fss ok5w== X-Forwarded-Encrypted: i=1; AHgh+Rrz0y+cH2cBzguQKsXoUMN73m1Ac4OeDP3BTqllBnPRONw/X/dy+hGlLG6xE/AtH+u3F2mZfksngRTERr8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr9gwfGg5tzijW6kcur15xeepmgElFsn62bxqVAs1RfCOR5A04 W1CjIm0ghBYFk4VJz92W84Yds+xgs5o4lsSR+BoeWqW9Kc+CT4cds0qy X-Gm-Gg: AR+sD13EK1wVwz5i0BWyz1ErFAFojTsZSXEN1Lyp7zPIiGPA5Vgwd5o9oYgkeAxleXP Kr+2G+69/j28i6NkHMjK6D1uVSpARHYsstO9OZDuxwH3MPYHyTvTLnH6vMUwwg32kSD3aKnGu6Y MopHcAF2VEOXjr7fgnkm73nBFficgRwxLnENoyu0Qv+vrZ01C0T5TCNi9Pg4wVWMUdrOmZxytNs 3kiHSEaopYAJgd8/bpjmZxi7BVqhheRr/nhrxZUhlBY9o2QwmSRmZhtMOyxiaFqr2a59M/P2Dsr y7jL+NADRUVr40cRQkmZFEDcAZdKzQlhOGRnZZHluT/N+jzzDvPXC/8gc6oxYM26LAInxpgjSTr YX0SSsEmKso+/yTHq4rAIeTcrhCg/tVXAT+j89rVlOwV9le8hlL7RK4DIEc1MvCP1MOJKJemuLR a6WuXUEOjmSlKlqo23rv1QTaxugDTFTzA3aqE/9g2WHRT4HyJjYAk1osGS0rb54RLw X-Received: by 2002:a05:6a00:9295:b0:84e:23f7:1188 with SMTP id d2e1a72fcca58-84f4febe528mr20371687b3a.28.1786237060578; Sat, 08 Aug 2026 17:57:40 -0700 (PDT) Received: from Inspiron5409 ([138.199.21.246]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a58dce5sm2471214b3a.58.2026.08.08.17.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 17:57:38 -0700 (PDT) From: Jianhui Xu To: mail@birger-koblitz.de Cc: andrew+netdev@lunn.ch, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com, hkallweit1@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org, neuromoments@gmail.com, pabeni@redhat.com Subject: Re: [PATCH net-next v6 02/13] ax88179_178a: Split driver into library and device specific code Date: Sun, 9 Aug 2026 08:57:32 +0800 Message-ID: <20260809005732.3084198-1-neuromoments@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260806-ax88179a-v6-2-fde7414619e6@birger-koblitz.de> References: <20260806-ax88179a-v6-2-fde7414619e6@birger-koblitz.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Birger, I noticed what looks like a typo in the newly added `ax88179_read_cmd()`: ```c if (size == 2) { u16 buf = 0; ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf); le16_to_cpus(&buf); *((u16 *)data) = buf; } else if (size == 2) { u32 buf = 0; ret = __ax88179_read_cmd(dev, cmd, value, index, size, &buf); le32_to_cpus(&buf); *((u32 *)data) = buf; } ``` The second condition should presumably be: ```c } else if (size == 4) { ``` The original implementation before this code was moved to `ax88179_lib.c` also used `else if (4 == size)`. As written, the `u32` branch is unreachable, so 4-byte reads fall through to `__ax88179_read_cmd()` without the `le32_to_cpus()` conversion. Regards, Jianhui