From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4D9285CB9 for ; Sun, 9 Aug 2026 01:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786239904; cv=none; b=iL5SBA1IZi1ig7gt8TieOQPtQ8dxevKexNviK+un1m7rdKm0Iu2k7jvEZEoFA8bEstIIM4s/mvLl55xrcg+TDLth2yFCiqZcnJJPZiKxqjW3l69mzb/hKhJ5u7DelYw7UpCcwqloXFHtgD0Sd9ehKkSbY7JbWzX9vKwmqaT0WHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786239904; c=relaxed/simple; bh=rZRfFdKn5ZeDJ2welL+LeLeoqqxzO8nk63PZPlAWJ4k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qMf7hUukhP9UOHsRbvEycFjr+eOLWkkuGjCdV3x61OYQKn9Ur/TsO0cVl0128XXtLhbdU9xz/+BgbvSKiz473vIMVohDvVIp7ndAUZKQ71C/j0IoGxCbNPy9AlK+Ay9NBK/JNoyd6t7JWnT6sqrM+24Bvd7JSCV34Fn3hi3w4sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OnqiHMgE; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnqiHMgE" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-c1c4c7ddaf6so100106966b.3 for ; Sat, 08 Aug 2026 18:45:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786239901; x=1786844701; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to:content-type; bh=I3u5rsUSFhTfhPe8GhsmZTZBY8QySwMvot5AxopxwNk=; b=OnqiHMgEcrxD7kKvJA5p2wPUSiwNWt4NgRsfdoGxmr/UwsAYnHOepCltlvnUNrCBRU A1Jn83OUS55D1H3r4WuX5pqL9ttwA1pdfgpTbSp8mrEt3EobbefGSVaCD39q3uS6pcx5 G03ULTLJDDs3N9CDWpsBB1KGWiR27s6u9ObjTo9VdMTwr8eUxZzDNGgSl1ips9J1HGGB QMDMbS0OSMUXEbi+dP4Ue3YCNOUx3iX79XJ7HQYuhwWZ3TRYC9SH4m9t9hD+1A9TDfc7 BEWUvy28924Zdbv3zOTSW6opxpcv9jv8Sojb0NBx0K0ZC31XCL6Rwy75rOvAfqLaJloR NqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786239901; x=1786844701; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=I3u5rsUSFhTfhPe8GhsmZTZBY8QySwMvot5AxopxwNk=; b=LlWXauU0SgeyPpEKBoC4NEyG0qFlm16pqOW6/mbHTTIZjFG6WYE//q7EHPkPRXq2N4 /OKy5sOe+8MiklIjSgmSfwJpXz4Wmao5naUeZHxW/uHX0tOGxjxt4tLXzrVyLs4rRQlF qxwYQfSsIjp0xJLwQP7l9Kf3uLt6962XJLcdx3jB55ShJB5ommmtXSydqMNhQXcO/mCK KBcLhFjO5BtAhu3J0lK1+aCmSSH1vIStLM7Ev68a2diaJyDCeGXdld/qMDsO8lmEB/7G gb9hikPsSo7U1ZD00fZbZPsPNuWMWM1gTorBak6Y5pEEAOjj/FRfmLle6x8C7416ZCv6 cz6A== X-Forwarded-Encrypted: i=1; AHgh+Rq+Q0WXwiLj653x96XYEwNJ27CLKN0EE+/nsAwKQzTCrt8eVXz3OV2cqGXW6rIe6ZbVhZDyo+Cr9LlhBOk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8VvRPZQjzU24rjoVDaRoPLMuCvLsv023TRPYubTC4Y5KF8Vi8 Hf0uZJeJR+KAbMNGaZtelpbc1P9J0svXwh7WGuwvOxjG1jNfYNcmf0dv X-Gm-Gg: AR+sD118fTFmQndwqwpisjHvJmJpYqqesz+D7XPgrHDin2SVL7QDxTMQuCuRPouIuHm waqE1fhMErabp9pof1VtsEKkDEvSBaN3nqggZKPEE55jvO7NOJ3vOUkjYlObWKHxvlWi9SA4kIq SfUdfqH9ckQ04Tf1OoxmYGTp25KrbTtBkAXfngmYbN6nYODb8YwLVecCd8CiujQC+1FPmAw4GSx oYNFFFE4Vw7k+aSfnzQL2IOUsst/6itqUd2tjjwAqyEhEIsiVSt+M4R1n036jwHkRrAL10/bYkF HSs28Vdc6MTo99g57d4E0eg3D9aw+g6LLN6tOSZO8QPmxwxpOoNcfLXCmZbmTjWawA8WhI6QhLB ahiJQHNHJV6cIcRDrKDt+b8cdU83BOjn/2sbBH+6P9LVbqMxvA9C+EZwXEvb8PeHbFtauILg1um y3KPwAJGUAq3PCxrLh0g++SQ7QwXP258ogDcx3tfA1jP7AUlZImjytElZxFKs= X-Received: by 2002:a17:907:3e10:b0:c15:ca27:5818 with SMTP id a640c23a62f3a-c2039f6e7f8mr1627969866b.28.1786239900597; Sat, 08 Aug 2026 18:45:00 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2080a743ffsm207864166b.23.2026.08.08.18.44.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 08 Aug 2026 18:44:59 -0700 (PDT) Date: Sun, 9 Aug 2026 01:44:58 +0000 From: Wei Yang To: Karl Mehltretter Cc: Andrew Morton , Wei Yang , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] lib/interval_tree: fix allocation warning messages Message-ID: <20260809014458.b4bqt2t6sx5s4rrl@master> Reply-To: Wei Yang References: <20260808123608.73613-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260808123608.73613-1-kmehltretter@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) On Sat, Aug 08, 2026 at 02:36:08PM +0200, Karl Mehltretter wrote: >WARN_ON_ONCE() takes a condition, not a message. The string literals >are always true, so the warnings still trigger but the messages are >never printed. > >Use WARN_ONCE(1, ...) instead to print the messages and keep the >once-only behavior. > >Found with a Coccinelle script. Clang's -Wstring-conversion also flags >such calls but is not enabled in kernel builds. > >Fixes: 82114e45131f ("lib/interval_tree: add test case for interval_tree_iter_xxx() helpers") >Assisted-by: Claude:claude-fable-5 coccinelle >Signed-off-by: Karl Mehltretter Oops, thanks for fixing it. Reviewed-by: Wei Yang >--- > lib/interval_tree_test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/lib/interval_tree_test.c b/lib/interval_tree_test.c >index eba2d3e28980..b0b07270ce7c 100644 >--- a/lib/interval_tree_test.c >+++ b/lib/interval_tree_test.c >@@ -140,13 +140,13 @@ static int intersection_range_check(void) > > intxn1 = bitmap_alloc(nnodes, GFP_KERNEL); > if (!intxn1) { >- WARN_ON_ONCE("Failed to allocate intxn1\n"); >+ WARN_ONCE(1, "Failed to allocate intxn1\n"); > return -ENOMEM; > } > > intxn2 = bitmap_alloc(nnodes, GFP_KERNEL); > if (!intxn2) { >- WARN_ON_ONCE("Failed to allocate intxn2\n"); >+ WARN_ONCE(1, "Failed to allocate intxn2\n"); > bitmap_free(intxn1); > return -ENOMEM; > } >-- >2.39.5 (Apple Git-154) -- Wei Yang Help you, Help me