From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E570137A840 for ; Sun, 9 Aug 2026 05:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252421; cv=none; b=GDgm7kEvMUCHy3118XysU9Oy0639DuyfnYL/8IcoS7fsrqWmVXvcLT0HqPo5UurDfXbB4jJsPWnaBFbvXOlLUfJ5dheQY2mXq8SoSmAJNmxcTBLAt1qec7Rd0iJU8zEULGjFnaFY1onxrC1iJgNKwdvBdw8+2Ky7cPfW7II4ylM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786252421; c=relaxed/simple; bh=y0zMskDwVEjMDQcAHD6HmVFV4GEVmq+PJEhAepuOUOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNZxSLR526hvzZHOm8dWzL4s4YtSni2boVrz4zs6H8wRxwUx9QEXN9nRSewZJX9jqJJdOcGRlxx1IDFd5D7p9tiiPdX3V1w+iDjbHGdyVNbJr0oorl/hjHr13IOUamWKQib9u/Y7jmK+XzgCEkS307CVqBmoZe7r9aeoCd09oZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kSWjT95u; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kSWjT95u" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2caced6038eso7520265ad.0 for ; Sat, 08 Aug 2026 22:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786252419; x=1786857219; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3uV1jDlXdjYzrBZ5UiAE52SxJwX6HGbMM4vfraaFeu8=; b=kSWjT95uPnCo3RQuf+yIZ2JPtY3fYAJXJJWGQQnk7dTf6agH+p2rHe/4m8ijKyZX3R liQ+ehSJBkjWUJmZ52YwGSkgSeyMR1PbqbwoYxpJcLxJRGPyyuf1Oi6FD/RVkJNAjzr5 YwK8CRW5iZNnFx36QYy5RmH4El6JFPxZ/tIXllq+Vl1xjgyxRs/U9HrcmO+0vYmjIOjR uaihcKW1on+VqrZBENxS48NlY7v5nNGWPEcqrxKp3IUJpkDJI/R7n659fKAPghPfNIMC OkCpKwKS4VftjNhv3QuZ2X9gcQoxnomg2q5tu02wftr6xMCGu1IZiycBr3/crC5cLU/f sH7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786252419; x=1786857219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3uV1jDlXdjYzrBZ5UiAE52SxJwX6HGbMM4vfraaFeu8=; b=MmCdSFIpQ+cyHbZ9s5Jp2yZAhK9kwzcRVgSdCWkB5gtTjspsf5gtwmySawOI39QBg7 +W9cjTdpF6aqy8Qd7FHrPyGB/9pS2/rjZWPu3GlrXGvCks7c0Mzn1GGGVqh89H0TNN6w vhjS+Vy1FUCncJsaa1cTUwpiiMpMkMdbzJqSMnf4mxB/zUBDDyS8X34+TRCeCzirsZuH itxYcLNupYtcZ+Wd5KtQOE9YUrbcD8MYnh3DMil4hppf4WtBlQBlGghrxISO4E+v/mhj bFxXaqVi9xhXpjAZcbGiLml/dF4KaLaRPU7xJo6QK9Mkx+BBjpWC8dqaNW/WwcD8oRR8 XlUw== X-Forwarded-Encrypted: i=1; AHgh+Rq8SUi3efhcdclCDV7SusSB1vzhtdli0XH8oz8B8h6ZdNouPCw3vQ3AiRDjUGvRVAtaftCFmCPb/5V633o=@vger.kernel.org X-Gm-Message-State: AOJu0YzXIQniHw1qkSQKhe+qS1soMh401N24ixSK5/DP18yPYbKVkrYk uhCI10Ea72hHobe7+WqyjVnxmKxb+npXg/UVETBOxgKeZg4YodNqXYEV X-Gm-Gg: AR+sD10XzBM1f+vzIwLyvsFhdjGqSRynltxvF+fmyFX+PTQT6RO7+gIr9LuUopFxg1X clXumfFr10QmL7qWbXVEY1IDFdW0zL8nbnXmgWW0cDvXdFRXckrw5sUEIlGeaEwyhQ/IHbnhclF 6tkt99ljmAC/V7H+xicyJu8v69Ap/022Hj17bCDmvajOoGP0SranQT4cbUs7kd4F74bV6ggscJ0 VrIk+CIqyqMP1CKb3oTWVAcIjCLbq4s9srD1W/OusdR2gHhPoXuA7A18HMosCX2GxGww3Hkke9h TO3jcaTOlSpcDSnlUcyX59baSpKz+sbGcWJwQOt1rMAl0Toosym/JPJd0Dadk8TjnnpaNUFbV0L pkIenDJcvgnvbbOJHVCG+/eq57iBcC9YwBtr7oVEFa21maV7J6ME5T1S8xi6NOneU3xFYteYUK3 wMxtHk3KkfLlPHqRqAya17wbuzrvwU0y9QvRrmR0i/xQP+fOOPbrinfSo2a+sWi1m/wlM19Lvl9 X2OCpUIroii X-Received: by 2002:a17:902:f612:b0:2d2:a982:a388 with SMTP id d9443c01a7336-2d2b2eb169fmr124489795ad.15.1786252418944; Sat, 08 Aug 2026 22:13:38 -0700 (PDT) Received: from localhost.localdomain ([103.178.204.108]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be8a7395sm27095702eec.9.2026.08.08.22.13.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Aug 2026 22:13:38 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v3 5/6] drm/amdgpu/aca: Fix off-by-one buffer size parameter in add_aca_sysfs Date: Sun, 9 Aug 2026 05:11:59 +0000 Message-ID: <20260809051200.3276-6-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809051200.3276-1-sreekuttan2156239@gmail.com> References: <20260809051200.3276-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit snprintf() guarantees NUL-termination within the size limit specified by its second argument. Passing 'sizeof(handle->attr_name) - 1' unnecessarily reduces the usable buffer capacity by one byte, causing sysfs attribute names to be truncated early. Pass 'sizeof(handle->attr_name)' directly to snprintf() in add_aca_sysfs() to allow full use of the allocated buffer space. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index 79326389d75c..4305092f134b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -682,7 +682,7 @@ static int add_aca_sysfs(struct amdgpu_device *adev, struct aca_handle *handle) { struct device_attribute *aca_attr = &handle->aca_attr; - snprintf(handle->attr_name, sizeof(handle->attr_name) - 1, "aca_%s", handle->name); + snprintf(handle->attr_name, sizeof(handle->attr_name), "aca_%s", handle->name); aca_attr->show = aca_sysfs_read; aca_attr->attr.name = handle->attr_name; aca_attr->attr.mode = S_IRUGO; -- 2.54.0