From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C17332E401 for ; Sun, 9 Aug 2026 08:49:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265400; cv=none; b=SNOpxYsfXBBKVobwn//yaXVLlra9fPI/Wk39NNKhKize7Caj1Le9n+EzrV05eC2QhzkbMJxxEmxh47SgNljZmGe8VQMySJsiwIcbtCwA7de5ccF8S1SRTCvB5VhArNipdQ48Tqv3X/eS06lMiJsWPcph2pMFScEcYX/bynVlzFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786265400; c=relaxed/simple; bh=cOe7wAtEpKGz1IubsJOZd5Kh2Q649IZb8GAt4BDiQGs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O4I9rqD8xwCW4cRUPJB2eCUI/ckeJqTWuI6EECycTpVG7DDyTa+z2uAi0ix2gbn++Tmg27pg+AWoHHAG8IE7E7BODl8ygP1XUC0gC4FJGr/wDwHa2aHXD/hW0SQcmw+gPgdT+6V3K20URc9U2NW17kCApW4jVWgMxs8sMICWSNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CU7NT3VT; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CU7NT3VT" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-cbb8b54fcf8so622515a12.0 for ; Sun, 09 Aug 2026 01:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786265398; x=1786870198; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ohuKFNYedefwgEV1kOLtJZIOQiLf64k0Qg77YlHmp8s=; b=CU7NT3VTDbdpc3ww8VftkEztVyh0bX0ZE5WswcGgu6J+PJspJS/Z9kW4b/GLL5BFdT ZXSe5IDCaCllkiymq8ptI7q/Ur0TNpSTBeebHqBDqQ3lE33Qin98oXIZ32VZ540e3Pxk uz1BftYF6103TwVZXERFEC/dQjoLsSMuR/8PlO4si/vY6UqsaT2FI1hE1LmRNKgtyUFM bZqClOkufJetREJPL7G2U2qJnlTjisfWmPTVKcHzK2t6Vi4gxwFVttQ6roBRSiHUvpG9 q7xqUb2S7NY3AtuSGIMl7Nyp5JOZfwH85YuOEbP4DGH3Di3hNSJxbVWXCtan0Yi9Wlzx j0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786265398; x=1786870198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ohuKFNYedefwgEV1kOLtJZIOQiLf64k0Qg77YlHmp8s=; b=EuW/VdnIWy1MeiYEIsyFHnpBY4wXROK9CBo7xiSr9QeRHFBpEzha7FOkpwD+jU89Zb YCfyicyYkuEW8qCErDRW9bG0ItH1ImT1zvaw1DwR4fcBkkvX9u+jTKy/AGYwka8CRks6 kTkRKcAXOyJMBAZWilT8rSFbm/FF4AYhMpx94S0FEGzK7hRjyN6lz2jqw8OZCvlvKDia yF1AyQ+yffaS0o1rW7JLYj9Hp9H7ooQZL841sq+NpbXVdtSEkk6XO/O2iFvW5UpqRMxU olgBXHBSV6VlyYQizGVfoj/FiQ7HqAso02u3Vum4DWV+ui3pcFJUDj1BeKLZXjtUUKZQ DDBQ== X-Forwarded-Encrypted: i=1; AHgh+RopdbEMvQ8GNywxdm+sVreN6ZRWurXk5WlpoYuIDSJap38eQFiG1zMpe0SbnF+7kBITy72wi5cjbSCM5NQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1XDvjwH+QNmBTFTEAlKqc8pzdE/iqKXevQZZhTDMCChJsdbZa bH0NwTK586JJ71rBKzP5J6TVItQRBb/8ahFS+3HiSpIoVvW+Fo5oXxqq X-Gm-Gg: AR+sD12sADzVzORRTxjxL8oQGm+kvdPWn9tAHWri6/yQwoHhh63plBCT4F6I3BIpIIW fQeo4+rXs8OqabPg+4eVjWSkN7Er7gDWRSfFuhpFPDd/ukPDJUcvGGcpJJaAkV+lQYJXh9KxG+w PVDd6BJEYDUnoPg3AhTk6WOQTaG3rn4BUpuvjpN+jpBmPENKNQV4+2zPIIlyaa72T16AVYwKRCF x/y/Gd3G4S5tyawa1jWz8n6zip4x6V8tjNPmeQYXpgCti/m/Kk57/7tMAh01ljpuV71SNpLx/yZ 6c85uKVacAlfI2BQkhIvJEuywwwHjN/QZgTVzVnCi47mKB3/7aME8HppFyxR71oFSPrthovbMBs a0gf4zfXZEECVqmuPbgKmoj7zq6lk8AKRasHbh1BE9Koosc68MQtO0Jw1YbXSyPpBc0iV17N0aR ZZl/Zc6vsXelII5NUjxcMYCjz57G/ZGlnAUigrkK35z3xziFEbuNSFIdsmWbGl3PCq8G2tEZE/R LOtnag3lXg= X-Received: by 2002:a05:6a20:6f02:b0:3c4:511e:26ab with SMTP id adf61e73a8af0-3cb85ded984mr46153927637.3.1786265398022; Sun, 09 Aug 2026 01:49:58 -0700 (PDT) Received: from localhost.localdomain ([103.178.205.91]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86fc7bsm28800025eec.1.2026.08.09.01.49.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 01:49:57 -0700 (PDT) From: Sreeraj S Kurup To: alexander.deucher@amd.com, christian.koenig@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, Sreeraj S Kurup Subject: [PATCH v4 5/6] drm/amdgpu/aca: Fix off-by-one buffer size parameter in add_aca_sysfs Date: Sun, 9 Aug 2026 08:47:34 +0000 Message-ID: <20260809084735.9743-6-sreekuttan2156239@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260809084735.9743-1-sreekuttan2156239@gmail.com> References: <20260809084735.9743-1-sreekuttan2156239@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit snprintf() guarantees NUL-termination within the size limit specified by its second argument. Passing 'sizeof(handle->attr_name) - 1' unnecessarily reduces the usable buffer capacity by one byte, causing sysfs attribute names to be truncated early. Pass 'sizeof(handle->attr_name)' directly to snprintf() in add_aca_sysfs() to allow full use of the allocated buffer space. Signed-off-by: Sreeraj S Kurup --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c index dcddeb381628..3da3d369a918 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c @@ -682,7 +682,7 @@ static int add_aca_sysfs(struct amdgpu_device *adev, struct aca_handle *handle) { struct device_attribute *aca_attr = &handle->aca_attr; - snprintf(handle->attr_name, sizeof(handle->attr_name) - 1, "aca_%s", handle->name); + snprintf(handle->attr_name, sizeof(handle->attr_name), "aca_%s", handle->name); aca_attr->show = aca_sysfs_read; aca_attr->attr.name = handle->attr_name; aca_attr->attr.mode = S_IRUGO; -- 2.54.0