From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AEAB42D76A for ; Mon, 10 Aug 2026 16:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786380473; cv=none; b=rl55rXVcmlg5Czwnt7pc9BOYORfODHS1zootbTwJReGtLktsXe6DrGxjVDab7eVARZe4a90eNmlV3lEOY0TmmusmpEOwAplLFX5FDRAGA/scvXENdJTuYc3VJvJpezk6zInP3xTKjd6RN4Y7HYMxHm3/CotRkcMpqJ1gtWjg4h0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786380473; c=relaxed/simple; bh=XcdFhWSjpZ8I1EIIuQNMMN7Zy0MPKSEdmoyU+VFfNMg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hcJCpOeDEgQQMhp39Ekka3Wmxai8gqWJ3nkUDSdhLM7sY4T2Gjz/Lv0aO2YWhC9qtd7AO9q+NZpuhlEpdiNCV+wfjAM6DtV+6W46giuvCyOXIFfL56cExwFlG7FpCQGbv9dlB3jEzojU8Ef7WIxTspDZ+vtH1SRFpAL+ADvgXWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WW3zCKck; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WW3zCKck" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4706f016316so166922f8f.3 for ; Mon, 10 Aug 2026 09:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786380470; x=1786985270; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Lb5+5JTC9yhaPKpWNbGAJrFXvPh/cPi2R9FXngaeHD4=; b=WW3zCKcke63q0GO2C+CsKnxGf2PCGjErAAl4/ODYxJibWkar0Usmzxh4T1n6US0Y9A UBlSJmUfzH80U4i1yg792j2MYUB7F57FZwOJBuRbhauDReKpl2G0ufoDF8xcT8OdK6Qv xBmM2lrGSy8bejbW0Gmq+leIoVSyGLviVYL1hUmtwbmpqBl88vcZZDhSCjHv4Ptt38Yk GIxqjcYivjVymbIIL5Soc/kh4mlFQHX5AqeGnmPoBi7p/7KGcHfA3OJ6EJmPtU0Zwz4Y XG8O25oBx3NOD1f2qkXpdXTsJbWMIaK8lY51vd7btnR8iM9LK7eqmGioPUaWbMOcGtdc AA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786380470; x=1786985270; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Lb5+5JTC9yhaPKpWNbGAJrFXvPh/cPi2R9FXngaeHD4=; b=fbUyzmRv830hkwQm3hynRg1o4w1chwDTac72uS0fKbX4RVUMc1Tp9l0oe+d7tgvjMJ jdrxpeqVSyLdzZUz0OlWkgzvf3oujry8jsGk57y2+hzneIpZJrHJoLVk6RAnD4zgW5CO 3o0ISJk3I5g4rWSSxZdEq0qq1mQ0z/Merk0Y4MVk6q5AA2gQOiqr2ty4upXBOjmx2rD/ /YTWbngIj2z+P3O1/yF95UYN8k1N8GsR7Cl+2VB1EvaVrv32ezoYBLLvPs+o+pn4mxtr EsBNxr54EYuEQFV09cTgcFoYJEQAeYciktUZ7oFSlEdnV7pIL7DoPfl2QGVzs0KHwonQ hdLA== X-Forwarded-Encrypted: i=1; AHgh+RokVPLvMT6UfOMYw/a/+7hVu7w8oZhm3wPEAB5FjQFufo9VI+PDhLoBWKxKKC7D5Jtc82jngtHmYoHL2Tw=@vger.kernel.org X-Gm-Message-State: AOJu0YyOPXHhs17rIdS17UE/m1xZjAk+FFwb1Bf9GcPoQDfcVBnZdWwb GKh5K5ZdvTDwtpm3ypoS0HaPqlXV5dBjkvqPcOm5Qse2fueSg/J6yh5F X-Gm-Gg: AR+sD10RPVfiD8MTe1leLlwhPpx2/dXkgQ88LtYkOKeq6O0TuK59zYVny7dUyPu9PDr PBImVo4CTNPs8wwk+3hDyEKihiNHEnr/QQJfWqKkyidCGEO6Ki9njgOqV4aqngVFy1Sq7TWNhJl ZrsVEVAuJrRHEMgec9QnSk3D97Tgt2K7h81bj2KFcaGXdfPutnfIAiRej6oCKiJ+9g3heHbu2KQ OGQ7j/+Iq49x8LAARtGLaPdlE/RAUYt7Ae88cN/tp7ybnb2Ep4ayQiPknxd8DJndMCL1zSJSB9m jwUjejmCOI8niugSnZreye+nwRxSV7mK1nGcdHvTowws1/Ey9CDDEOPMxSvD2H3DjhV/D1FoxYW LLu4nuZK/n01lfFVctt/WoxfF3aPP7ptQVlC2JKTR0fIy3YpFPZzB+Vdzbo5/rZHHQLjK1caNM0 aW0zrfzHrqq9xChMhXrHFE3tbOmGH1Qu/39lvnqEiJ5HPkeWmUdaIE3Q== X-Received: by 2002:a05:6000:290a:b0:47f:7526:5a0 with SMTP id ffacd0b85a97d-47fec47628bmr32828119f8f.0.1786380470283; Mon, 10 Aug 2026 09:47:50 -0700 (PDT) Received: from localhost ([2620:10d:c092:500::7:692b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021f9182sm37080011f8f.28.2026.08.10.09.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 09:47:49 -0700 (PDT) From: Gustavo Luiz Duarte Date: Mon, 10 Aug 2026 17:47:28 +0100 Subject: [PATCH net-next v2 4/6] netconsole: reject a target mixing IPv4 and IPv6 addresses Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260810-netcons_ipv6-v2-4-3d4fc987a90f@gmail.com> References: <20260810-netcons_ipv6-v2-0-3d4fc987a90f@gmail.com> In-Reply-To: <20260810-netcons_ipv6-v2-0-3d4fc987a90f@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.15.2 The local_ip and remote_ip configfs attributes are written independently and nothing stops a user from mixing ipv4 and ipv6. This leads to an ipv4 address being zero-extended into an ipv6 header or an ipv6 address being truncated to its first 4 bytes for an ipv4 header. The command-line parser already refuses such a mismatch. This adds a similar check when a dynamic target is being enabled. Signed-off-by: Gustavo Luiz Duarte --- drivers/net/netconsole.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 7fcdff53b3a4..054c39066043 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -475,6 +475,12 @@ static int netcons_netpoll_setup(struct netconsole_target *nt) return -EDESTADDRREQ; } + if (nt->local_ip.family != AF_UNSPEC && + nt->local_ip.family != nt->remote_ip.family) { + np_err(np, "local and remote IP address families differ, aborting\n"); + return -EINVAL; + } + rtnl_lock(); if (np->dev_name[0]) ndev = __dev_get_by_name(net, np->dev_name); -- 2.55.0