From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91DED41D121; Mon, 10 Aug 2026 15:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786375348; cv=none; b=cUqv1JxsM+0hyE5r4Hbd5oNPHCJ1yPVJQaDG1gJn4IIdCbdUi9n8VDr4CJ7Xf50eH06mBm476uRJQXK2XrDBx7vm+r9768OEAE9uUicrkIvqoT7lh7KR2W/sW9k5fkYBzONmNUUcacYVtHc/hhkZ2mzeq2TAVA7Tz5zrRhzZpUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786375348; c=relaxed/simple; bh=HzMa2TTTRJC/kAywH5NeQSXaEXmOU6CGDcW/QAwpxFc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FtkpFTixPp14dECYbHiX4xbfR2OPcnXOWdwvY2Q2ICX4a1oeffSza6mR0ThBmOnRbhDc0GkRjkum9Snnqc455J2v+N1d/5ZYRA0z5SKULxWTDO8AUuY/PhhHVRwP0l10+VAuHn16Ya1Ytwd9EztX8nm8JkK9rNkjMKupBLOf1W0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=M5e99HWy; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="M5e99HWy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1786375344; bh=HzMa2TTTRJC/kAywH5NeQSXaEXmOU6CGDcW/QAwpxFc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=M5e99HWylpG40RkL06JrSwYDxRNs/1/5J0ycDw3+7Qp4D2IvfiPhsxcsBU3ZTaz6m Yn94hdayDeeVmVRSE7P1QJmuZJlazLBEKTgGAJXTEBTRlnQ0vVFSCxuMn4PTTNZ6LI wn9nAwSXROAOCMac/vK8cnIJtNE5BmonT5f1+gPh6g8uX+ppDptf4MbCP81Jn/9Ogp e9tY0YHVXc6lEF2ytpkNTsUbdCRnaZyecP73esfsLp5QQ/Zz3C3DiEkmSVQ8bF6sVx rOSjzUT3K8HjdTf+CSXD7aq0GmEkuMkfHNDBAz33yOJs1ZJnuQ+qarcyOAqJtQWDLA iH54CYCoOkFtg== Received: from [192.168.0.15] (unknown [100.64.0.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3D72317E0899; Mon, 10 Aug 2026 17:22:23 +0200 (CEST) From: Detlev Casanova Date: Mon, 10 Aug 2026 11:22:12 -0400 Subject: [PATCH v2 2/5] media: rkvdec: Remove unused need_reset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260810-rkvdec-multicore-v2-2-986f89d22cdc@collabora.com> References: <20260810-rkvdec-multicore-v2-0-986f89d22cdc@collabora.com> In-Reply-To: <20260810-rkvdec-multicore-v2-0-986f89d22cdc@collabora.com> To: Mauro Carvalho Chehab , Ezequiel Garcia , Heiko Stuebner , Nicolas Dufresne , Hans Verkuil , Jonas Karlman Cc: =?utf-8?q?Sven_P=C3=BCschel?= , kernel@collabora.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Detlev Casanova X-Mailer: b4 0.15.2 A left-over from the iommu restore mecanism was forgotten. As need_reset is never set to true, the if has no use. The actual restore function is called above it vase the IRQ isn't in a success status. Signed-off-by: Detlev Casanova --- drivers/media/platform/rockchip/rkvdec/rkvdec.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/media/platform/rockchip/rkvdec/rkvdec.c b/drivers/media/platform/rockchip/rkvdec/rkvdec.c index 31ddfcc58894..db2731af06cf 100644 --- a/drivers/media/platform/rockchip/rkvdec/rkvdec.c +++ b/drivers/media/platform/rockchip/rkvdec/rkvdec.c @@ -1462,7 +1462,6 @@ static irqreturn_t vdpu381_irq_handler(struct rkvdec_ctx *ctx) { struct rkvdec_dev *rkvdec = ctx->dev; enum vb2_buffer_state state; - bool need_reset = 0; u32 status; status = readl(rkvdec->regs + VDPU381_REG_STA_INT); @@ -1478,9 +1477,6 @@ static irqreturn_t vdpu381_irq_handler(struct rkvdec_ctx *ctx) rkvdec_iommu_restore(rkvdec); } - if (need_reset) - rkvdec_iommu_restore(rkvdec); - if (cancel_delayed_work(&rkvdec->watchdog_work)) rkvdec_job_finish(ctx, state); @@ -1491,7 +1487,6 @@ static irqreturn_t vdpu383_irq_handler(struct rkvdec_ctx *ctx) { struct rkvdec_dev *rkvdec = ctx->dev; enum vb2_buffer_state state; - bool need_reset = 0; u32 status; status = readl(rkvdec->link + VDPU383_LINK_STA_INT); @@ -1507,9 +1502,6 @@ static irqreturn_t vdpu383_irq_handler(struct rkvdec_ctx *ctx) rkvdec_iommu_restore(rkvdec); } - if (need_reset) - rkvdec_iommu_restore(rkvdec); - if (cancel_delayed_work(&rkvdec->watchdog_work)) rkvdec_job_finish(ctx, state); -- 2.55.0