From: Jonathan Cameron <jic23@kernel.org>
To: Yash Suthar <yashsuthar983@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: accel: bmc150: use iio_push_to_buffers_with_ts()
Date: Mon, 10 Aug 2026 00:19:46 +0100 [thread overview]
Message-ID: <20260810001946.2f5b3a55@jic23-huawei> (raw)
In-Reply-To: <20260809174928.565911-1-yashsuthar983@gmail.com>
On Sun, 9 Aug 2026 23:19:28 +0530
Yash Suthar <yashsuthar983@gmail.com> wrote:
> Replace deprecated iio_push_to_buffers_with_timestamp() with
> iio_push_to_buffers_with_ts() to allow source size runtime checks.
>
> Suggested-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Yash Suthar <yashsuthar983@gmail.com>
See the other thread. Given there will be dependencies between
the patches, for v3, send them as a thread with an appropriate cover
letter.
Thanks,
Jonathan
> ---
> v2:
> - Add Suggested-by tag
>
> drivers/iio/accel/bmc150-accel-core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index dc8a6285cf3d..d904136720d5 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -1011,8 +1011,8 @@ static int __bmc150_accel_fifo_flush(struct iio_dev *indio_dev,
> memcpy(&data->scan.channels[j++], &buffer[i * 3 + bit],
> sizeof(data->scan.channels[0]));
>
> - iio_push_to_buffers_with_timestamp(indio_dev, &data->scan,
> - tstamp);
> + iio_push_to_buffers_with_ts(indio_dev, &data->scan,
> + sizeof(data->scan), tstamp);
>
> tstamp += sample_period;
> }
> @@ -1196,8 +1196,8 @@ static irqreturn_t bmc150_accel_trigger_handler(int irq, void *p)
> if (ret < 0)
> goto err_read;
>
> - iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
> - pf->timestamp);
> + iio_push_to_buffers_with_ts(indio_dev, data->buffer,
> + sizeof(data->buffer), pf->timestamp);
> err_read:
> iio_trigger_notify_done(indio_dev->trig);
>
prev parent reply other threads:[~2026-08-09 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 11:13 [PATCH] " Yash Suthar
2026-08-09 16:59 ` Andy Shevchenko
2026-08-09 17:49 ` [PATCH v2] " Yash Suthar
2026-08-09 23:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810001946.2f5b3a55@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=yashsuthar983@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®