From: svav2021@gmail.com
To: hansg@kernel.org, ilpo.jarvinen@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Arav Verma <svav2021@gmail.com>
Subject: [PATCH] platform/x86: intel: wmi: Use sysfs_emit and remove dead callbacks
Date: Sun, 9 Aug 2026 19:40:36 -0500 [thread overview]
Message-ID: <20260810004044.3636731-1-svav2021@gmail.com> (raw)
From: Arav Verma <svav2021@gmail.com>
Modernize firmware_update_request_show by replacing legacy
sprintf() call with sysfs_emit(). When altering string, also
corrected format specifier from %d to %u to match u32 type of
target variable.
Additionally, remove empty .probe and .remove callbacks from
wmi_driver struct, as they were print-only and redundant.
Signed-off-by: Arav Verma <svav2021@gmail.com>
---
drivers/platform/x86/intel/wmi/sbl-fw-update.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/platform/x86/intel/wmi/sbl-fw-update.c b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
index 62c9c7f18..7e07cfab2 100644
--- a/drivers/platform/x86/intel/wmi/sbl-fw-update.c
+++ b/drivers/platform/x86/intel/wmi/sbl-fw-update.c
@@ -61,7 +61,7 @@ static ssize_t firmware_update_request_show(struct device *dev,
if (ret)
return ret;
- return sprintf(buf, "%d\n", val);
+ return sysfs_emit(buf, "%u\n", val);
}
static ssize_t firmware_update_request_store(struct device *dev,
@@ -93,18 +93,6 @@ static struct attribute *firmware_update_attrs[] = {
};
ATTRIBUTE_GROUPS(firmware_update);
-static int intel_wmi_sbl_fw_update_probe(struct wmi_device *wdev,
- const void *context)
-{
- dev_info(&wdev->dev, "Slim Bootloader signaling driver attached\n");
- return 0;
-}
-
-static void intel_wmi_sbl_fw_update_remove(struct wmi_device *wdev)
-{
- dev_info(&wdev->dev, "Slim Bootloader signaling driver removed\n");
-}
-
static const struct wmi_device_id intel_wmi_sbl_id_table[] = {
{ .guid_string = INTEL_WMI_SBL_GUID },
{}
@@ -116,8 +104,6 @@ static struct wmi_driver intel_wmi_sbl_fw_update_driver = {
.name = "intel-wmi-sbl-fw-update",
.dev_groups = firmware_update_groups,
},
- .probe = intel_wmi_sbl_fw_update_probe,
- .remove = intel_wmi_sbl_fw_update_remove,
.id_table = intel_wmi_sbl_id_table,
.no_singleton = true,
};
--
2.47.3
next reply other threads:[~2026-08-10 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 0:40 svav2021 [this message]
2026-08-18 13:09 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810004044.3636731-1-svav2021@gmail.com \
--to=svav2021@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®