From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E990399369 for ; Mon, 10 Aug 2026 05:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786338919; cv=none; b=RCD+SflUMGjb5PtBEoWPg5Jc7Ctigy6NGRWYKj2K3JQXboTqgqfXrtGI/ILumP432MqyXHZOOle5m2Voq4T3415dbMQ2fgGWOtNQWHmSiZJCYZri3krUzhQj1VY+Ak1BOOJe/BNT+P+/+GxSmUVh68xe4Rq/V7Qr9fsS2PkYDs0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786338919; c=relaxed/simple; bh=zav2p/QVOlzjJl8PWalEICH7C0E9wyu1bnc1VlxxYa8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fPscqQbsOgzmsMdbWzsaD/F6x3gO4I3AKbUFvM6OQviHb49OdF4uCGHlFKneY2AJ47jLii9+eQ1wwIIjqLrpSEnY6/ScftXXXsNFTXodP9IP8UtXdWWl03syBY+gLsr0BJhtzTLKro4bdNReSqsRPd2Kw3kf2OZzMyVeKzZkffg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=e1JA1els; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e1JA1els" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so1042686a91.0 for ; Sun, 09 Aug 2026 22:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786338918; x=1786943718; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0YZwlgtilaKnaw3bFD0t+VHhRkaxeSpx4Q+6Q/sn9GI=; b=e1JA1elsg9sJppJU53GOlXqpxk78WuXbMh8TVRVbSU7nHPrONTCPZUJ5JUvY84hsCO I1Ut0e+sxfUTePe+zMX9Z0w610EJZ+x9M+TMzothhkkfyNXWuEMpwjC39S4eRTRLpiMh 1wwAxTmoghH7DpQ8LML4vz7CAwT66DQItj5C5MLTGWVWWWkXtq01nQyMLCXqfZftKsvN +yfAbzI8EcDwLLuBdL4w1NaFUnCeB1wdFNUmBe5UqHqGYctAhtu6SNBo2bMn9nsN+Qoa KTBnu5Z+24i544yRHLqI5FNvagjaA05EVptz1PN5dM9y/KaxZwYoZ0NaxaxCxO18U5Eu VsmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786338918; x=1786943718; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0YZwlgtilaKnaw3bFD0t+VHhRkaxeSpx4Q+6Q/sn9GI=; b=QDjgT0txVcNo4mGXTzK4xkaE1NMZpB5jz56gNUsJmav8cO717RIknRcfABO12O5mUw LvoJNSJCrcuBYrbGhlOiMlaRbLH5HspsCQ7TK6ki2TqUbZnwlKdUB8xupPfnq34z+FLX uQgI6qjvSBnBsjtdg0v/gx2+p2Q1Y8xVe+W6QTGHW15URbukkpgVpGrluEJAoMD522Aq J5MzonXRJYnwnKeF4imSGgxaaZdgJBRsWuNv6xRzF+oO765TIt2XJQc2YizOhQhJw4he D1sRwKaZB3Kvsq9Vpq0skgP2vxNa9H2BMgKkt4ntUJUiM2fLeQNKolP2AEx3HwnE3vzN J8OQ== X-Forwarded-Encrypted: i=1; AHgh+RqGhvRFFXnlgJPzdTFXDssF2hGA8I9IMVACREdEFr0lY985IVe0J5hqb56Rz/DBtCuiLwAsbu3PrrBBAYo=@vger.kernel.org X-Gm-Message-State: AOJu0YxWMLcOwBCrOEapoR1BxCvewAF6EdoiiVLj4pZcP3XmcXFxk0J9 5hPXl2Z82Fe9bDYzGXUhqeyCypGota1I7O45KzNmB4BRJBxohw5AZ3Ye X-Gm-Gg: AR+sD11viFbSTVagFC50jG9DfApCJgmJDQKvEgf913rXwUBajHAfvW57h0J8LuwNXIX tG7rLpgERf5vd0w0QawQUdAQpvMBcWUC1L6SfrmMwH7zb+007FiG01JYk98+y4rV/LViVY2HprU 4SxPv8wtxbzRwdapXppUC7CxworeHBQPEWAHRwp5feCEjtMRVrEYhGUSr4aEWXVMNn0LnmUgWsn PxFpYE6PEOafO2uN+J2BqKWd5mju0EP7+wWbDlzJuDDUurX0IE8FHC/lW4J2xn/wHTYrSO+9KDM AVrAS0BG36IK3/dl8aNVCAMxG3KQLoSuozkiB4s0CHuy3BMpDWhaDccYJAV53xpQtCQm5a5rpRD 0z9+uv2dYn0OZULZqv0ywo8oUtV76PulnvNCGUAaMvHVs8MBQVHlwWklDKSMGVUATYYbW3PGkZX VYgow0bKW2VZaXFc3mqdDoq439KlST+QR63EXGIlJmAJUr2QDwppGYLz6WWdi9u130i90qwww1C sKcOX0wCFrXJ5J4Cnseg+oqAtv/UxZmaNj3xKdwr9XhErJdq4BZt2R3hjAM4eLINCUOIYBLi/Qo +dzJ X-Received: by 2002:a17:90b:3805:b0:387:d5bd:622f with SMTP id 98e67ed59e1d1-3928472ab9bmr6277812a91.18.1786338917920; Sun, 09 Aug 2026 22:15:17 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-390b13b0c74sm4719672a91.0.2026.08.09.22.15.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 22:15:17 -0700 (PDT) From: phucduc.bui@gmail.com To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/2] rtc: m48t59: Propagate errors from optional IRQ lookup Date: Mon, 10 Aug 2026 12:15:03 +0700 Message-ID: <20260810051504.26912-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available, while other errors should be propagated. Propagate all error codes returned by platform_get_irq_optional() other than -ENXIO, so that failures are properly reported to the caller. Preserve NO_IRQ for the case where no optional IRQ is available. Signed-off-by: bui duc phuc --- drivers/rtc/rtc-m48t59.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-m48t59.c b/drivers/rtc/rtc-m48t59.c index 4e608bc8bbd3..1150f3f6b008 100644 --- a/drivers/rtc/rtc-m48t59.c +++ b/drivers/rtc/rtc-m48t59.c @@ -404,15 +404,17 @@ static int m48t59_rtc_probe(struct platform_device *pdev) * the mode without IRQ. */ m48t59->irq = platform_get_irq_optional(pdev, 0); - if (m48t59->irq <= 0) - m48t59->irq = NO_IRQ; + if (m48t59->irq < 0 && m48t59->irq != -ENXIO) + return m48t59->irq; - if (m48t59->irq != NO_IRQ) { + if (m48t59->irq > 0) { ret = devm_request_irq(&pdev->dev, m48t59->irq, m48t59_rtc_interrupt, IRQF_SHARED, "rtc-m48t59", &pdev->dev); if (ret) return ret; + } else { + m48t59->irq = NO_IRQ; } m48t59->rtc = devm_rtc_allocate_device(&pdev->dev); -- 2.43.0