From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F1B837F8DD for ; Mon, 10 Aug 2026 05:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786339610; cv=none; b=KhaRhFgmlYx//iUHw6XUcWCTUmupieArCzX3HtlMWQiKgnD1KlicC64zPixhPUh/9l06FQufFMTnMxMMWn/pgkBSncME4ayQJ1cbfNgBm4n3/K9WPuQd3V24wEXi4+lvgfrIPfOfqcxEj5oC96Rc3jVYEgaZxEJrVJa+Uv8wPQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786339610; c=relaxed/simple; bh=1OfKgQbTMms8n5dYEYf/DXGJSmrmavWK4rq2w1ycwNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EUMEyW5dzSMSbdJWwuzQNthiiXM2QkXdNwYQRuBjoPtAfhpZAJTEcVpjH3Q2SYq3ZVHFHuh9KZZkJMIWsP9gfkhro0ZvzAbhFK8ZTzFNONEUdmgWyIeF77sFX4dmMmwKAzO5kNsB7pbWoIHMtNVTYIvsV7CjSxoS9ptB3lXUq8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WOujgiqA; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WOujgiqA" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ccf2360620so11639805ad.3 for ; Sun, 09 Aug 2026 22:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786339608; x=1786944408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=x/8UpHFVXIXFBzrWjWV03c7PuH/XZDR/ITp80Qbxq5I=; b=WOujgiqAhQC+Leux4Q28wHSaHNGneERCLjdtstCV/dGvhDhAe9o2bbGjUUNgxHAtt3 5Exsw5ZekEW5Cmafjfm8aL0rAoK6gLLNGqIORUJsvsn3VW5hHc7jAiqbDM6eSambn0vj HC2H1x1ABss/p7UnPh7/3VgXrObhtJc2zAgLjB2LzXGmtvGKtQDL7/wlKPOTwWLKf2+9 fUMlFxIx7GiE5S/Scu8ikUNn8Qm6MI5RwdSdzB1vgaF3qTZi65agsNRIukKk5h26dcov sWQBkI7ZSu4TXRVsvUlh949Bb6lCbPSo1vHfG0UPU+JgO9SzielfgPirlngoG85bhEyj U2hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786339608; x=1786944408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=x/8UpHFVXIXFBzrWjWV03c7PuH/XZDR/ITp80Qbxq5I=; b=RTz0KBGnIuKqopxAtFXbHKNKbHQehz9D9YV1BxREDGHbhiQ4EQK42oKDoFKewAXVLP XZcJgOQ7JmqAuI2Nb7bRUZpVE8W27r8cCGIYpM8NdLsXjplVE3hSosEirxI3UWEF94qV e2CGZvCB19KX0ugLLW1khWLmn1jgXd2Wx1J5yf7f6L5UupMqRdT6CO7GSwOza7JWymNZ r9ncj2pbJSf2QgGRpSwdkRgrvwv22viQJR3U7ifMSPVgBdS43kIWzFfMVKyEPQoDnN/U uMYYKTbjh+Y4JBGniSFY3ABNDOzb5LTzkf0WV3b4a+CdanJsQw4XshZAnMW38OQZvMxb jrlQ== X-Forwarded-Encrypted: i=1; AHgh+RpDNr0GW92vFkT2JCNey+7HCCauuQvjyh+CXN+sFY/6kfZZVjZxXbGkmFhwwidwbjRPkeKNhTcMkjJaH6Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+N/2ufJI6jYubJhNptNuCGeVvJtwO1ywvzO/QN+xKZRjW/kso eo/DxBOVZEahUVIJ7vT/T2CJKpTg6SXuuah91SjnK8UoYhCu1s5iux4k X-Gm-Gg: AR+sD12XHZQMQGn74G+XxjvpAGWpvK4RkOMQyVFr08teX3cBZScvxsFjJBygAWY4RT/ 4GTs/en7l9eKon88swBYx6WeuhTj1Mvvgjn8Jt9Ef2jjF4/9DeR+siOER5qcgVYqQxXjpvJQodd FuKmRfSOKeFl5MiTyW+aWvJLccq8dogJ5TyXQIfTU4S23+JDiFvX6qdwg3SXNZcy4/F7SU7tBCT 2WVhe1XCOcAMW6v/yZxSrUoaKpEjcPlw15rrq+S7Rk0OO706yVqtiNQMNa/AQDTs1NZXYquW4vn gEIfNREHVy5SThog7dZTk43MMkqcdim3xsb5VzorrWVTR3q3hbRF0OTF0vebaXDIBPzJfWV7yCv 9G+T9xw7hewh2L8s/aUX00x3lbTCt875b62uIWhrpni1ipsGa5IgcSwNnmw+mJa/v7BrjdIVYUL 0KgLsB5uAvSNnkxklX08P2jZ9m408zpqsQlf9deLExzwdUrrTJISy9+RrUAeWvMXeBJWBtbTBp7 wXB/OQ8IgGiMxNAujB1GAdjAWmLYE6rDhXJvqVqnlGtpN3zcPuw9NTi7tTkP8kDPK8kWy6WjjW8 CUKn X-Received: by 2002:a17:903:1a83:b0:2cc:307c:51fc with SMTP id d9443c01a7336-2d106e81d72mr302441485ad.21.1786339608582; Sun, 09 Aug 2026 22:26:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c50cfc1sm29350025ad.82.2026.08.09.22.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 22:26:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Eric Piel , Hans de Goede , ilpo.jarvinen@linux.intel.com, Zha Qipeng Cc: Mika Westerberg , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/3] platform/x86: intel: punit_ipc: Propagate errors from optional IRQ lookup Date: Mon, 10 Aug 2026 12:26:24 +0700 Message-ID: <20260810052625.27614-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810052625.27614-1-phucduc.bui@gmail.com> References: <20260810052625.27614-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available and the driver can fall back to polling mode. Other errors should be propagated so that the caller can handle them appropriately. Treat -ENXIO as the only case where the driver falls back to polling mode, and propagate all other errors returned by platform_get_irq_optional(). Signed-off-by: bui duc phuc --- drivers/platform/x86/intel/punit_ipc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/platform/x86/intel/punit_ipc.c b/drivers/platform/x86/intel/punit_ipc.c index 6d770b950dfb..590b145fd5ca 100644 --- a/drivers/platform/x86/intel/punit_ipc.c +++ b/drivers/platform/x86/intel/punit_ipc.c @@ -245,6 +245,8 @@ static int intel_punit_ipc_probe(struct platform_device *pdev) irq = platform_get_irq_optional(pdev, 0); if (irq < 0) { + if (irq != -ENXIO) + return irq; dev_warn(&pdev->dev, "Invalid IRQ, using polling mode\n"); } else { ret = devm_request_irq(&pdev->dev, irq, intel_punit_ioc, -- 2.43.0