From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 517043242BC for ; Mon, 10 Aug 2026 05:26:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786339616; cv=none; b=L/n5iL59dOi97UdVKUzXh0HXq75qdizJmESj1eD7wysPw9NTts44VoBqKyYt+6vbEEMFqfKaJuxn9djjZOmF2XrrqIFXbTFyNkPOBMOBVY8n3mRNUlWW65KZ26M8wm3FVnmKT276mtp2ATunvrLHf1kFcySnUoyaKppr81uOXUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786339616; c=relaxed/simple; bh=0XBPYgMbzdfFCCRwEL0HVkGxwmcGEHskftRPioA2ZHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nC9TL2RyvH+tQB6wQLUK8mvKguNhAqX3NvUciAa16nu3InSf6DKxf6yf4K6UoJUl2BU7nwx4A+gHsaY81nf5LCt2K6syFk664qSiC5jHVX4J8EEGtPQ4msezr1r8KKrWkFBxH6zsGQoLOhC+gRh5N0wE1POwu74p6hPea/NO2CY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h/bYWblL; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h/bYWblL" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ccf2360620so11641165ad.3 for ; Sun, 09 Aug 2026 22:26:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786339615; x=1786944415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=inTYPJw01jcYRsAE34wz2vxcs3Bl64hbVk5OMtr6xYc=; b=h/bYWblLnFu2OLxJzUwhUqsC7JQZ01e83J4RmsPqPL8F7cZZdfwQj/HItsgLGVZxkw U9iC4n9cGG2O6uNLVtC8OeJufWIAPwzyl5P9GBvSHdiryM5AjoRdkrMH1VzxiG0QhC/S DzYhl6QvXXraKH7Cre+5Qm7/l53Xw+WTY2dG1AoPB3RflfE+gKpAnYFImtfl6TzgOzr1 6tZdLEX3992ECYBKrS43CazZbUnee9Z0nov21i24GQiVwa2AadBhYtDotRorNaUuCiHz eo3YgtbUd4EgRRU31djha1kXogV4mFy18433zVgISzBlq493487v8AJFb7zPNeO072Vr +u+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786339615; x=1786944415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=inTYPJw01jcYRsAE34wz2vxcs3Bl64hbVk5OMtr6xYc=; b=aATzx+M/SG42/u7s5//tEPTiNP0EHKwQZm9U1yeYR/Zg90W/6FKNQ+6fYxf6oR7UO8 B56xSCiAB+nnxGH34VfuB8776XdH70NqIEVgCuTzX2eQtnuZmP2Mezvnz6abcXIyS4cM jfW63kJ6BS1FE7uB7aikugzlie4LdYL5tyKFMMlFHUwB7EGCQSfQX/xRbSj/KD95d5n/ qivWGR9imzL/mP0nt/4lUFqhjS1G+42IRC+BQV+GJXGxbQ1v6R78tcbHJPQhPPZFSbnB PAZYLFHwb5ZnrUwAUfsnNc3UXEoegmy0K/GQOkeW3l5jwps8HOvBw+YpU5XRp4a/NOC0 wlWQ== X-Forwarded-Encrypted: i=1; AHgh+RqWjBeRq/rvD3QfCgp7pqCSBtKjPduPyWAdKZFsLSRRRAfSwPyeKo7mUpxsn4Dxtpr3aMwlv14L0VRiO2M=@vger.kernel.org X-Gm-Message-State: AOJu0YxLOlOZYsAwAHrHltRJ2j6rMaSTT+t6RPeiw5bFaZbx2K/ac09+ 2n54v3Dnp8B5a9GNToX5v90eJX9dtZS7+xJyM5qxW8tPKGWhMZcR17vt X-Gm-Gg: AR+sD13BMdcgFUREwjRUKyovs+Q/1/pGCOUxIY2knl48kkQB6rVzCf5l7BnhSloOpOd KlGfUJVOvU2SJEwqI3sXy6FADO9DD33IxScOxj2nMiPJtC1KfhEK91SAOnvk+jXvAluENc/ywKU AwMBKvnjPXKA87z4CAFHE0gjLXK1HIfej/UpuOx12OamjW1RnayhBUfK7HA+Il+VIi0moZAFi6y qbtzbZkR4ansBme+ALfhipMAbKSXTNJ70I52pUB00/gcc41YGL0lGzRpRaHG8qLzVddeeDSYKrZ a84d7L/xW1FvbDYdyQDI/oLOivbd25M4HrjiSm7siqVhckly8xd3irCVwogn3Y1JFyzC3zxb2/D Tx7v4GZgsI2gRzRQ6Iqq9eyk+HtkAapE1AgKvqdHRyYgkAa3x1oc4GKn8nenAqRVDv8uCX/zlQb aoH+gV5XoeyTwjaI6WtlZ8b93qvPgueXbCaNWIgRxZNAqQ/f7MB/0N586FQ2hARTSehymPvOSQJ GdguHyYEXwVcn8Rt6ZXUHkTOqkCWEPF0VKiBIGRZAjhGVS/cV6BZPUthdRLKoTJfDwRusc99MVJ KZePYE/SWAr4Sbk= X-Received: by 2002:a17:903:1aa6:b0:2c8:f34c:82c0 with SMTP id d9443c01a7336-2d106a18e41mr333320905ad.2.1786339614723; Sun, 09 Aug 2026 22:26:54 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d16c50cfc1sm29350025ad.82.2026.08.09.22.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 22:26:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Eric Piel , Hans de Goede , ilpo.jarvinen@linux.intel.com, Zha Qipeng Cc: Mika Westerberg , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] platform/x86: intel_scu_ipc: Handle errors from optional IRQ lookup Date: Mon, 10 Aug 2026 12:26:25 +0700 Message-ID: <20260810052625.27614-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260810052625.27614-1-phucduc.bui@gmail.com> References: <20260810052625.27614-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() can return errors such as -EPROBE_DEFER, but the driver currently stores the return value directly in scu_data.irq and continues probing. Propagate negative errors other than -ENXIO using dev_err_probe(), and only assign the IRQ to scu_data.irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- drivers/platform/x86/intel_scu_pltdrv.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_scu_pltdrv.c b/drivers/platform/x86/intel_scu_pltdrv.c index d5ab62cbf5cc..4686960c44ac 100644 --- a/drivers/platform/x86/intel_scu_pltdrv.c +++ b/drivers/platform/x86/intel_scu_pltdrv.c @@ -21,8 +21,14 @@ static int intel_scu_platform_probe(struct platform_device *pdev) struct intel_scu_ipc_data scu_data = {}; struct intel_scu_ipc_dev *scu; const struct resource *res; + int ret; + + ret = platform_get_irq_optional(pdev, 0); + if (ret < 0 && ret != -ENXIO) + return ret; + if (ret > 0) + scu_data.irq = ret; - scu_data.irq = platform_get_irq_optional(pdev, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) return -ENOMEM; -- 2.43.0